From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109AbcBCLR3 (ORCPT ); Wed, 3 Feb 2016 06:17:29 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:36819 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbcBCLR0 (ORCPT ); Wed, 3 Feb 2016 06:17:26 -0500 MIME-Version: 1.0 In-Reply-To: <20151215172649.GK1854@localhost> References: <1366967214-20776-1-git-send-email-linus.walleij@linaro.org> <20150710081411.GF836@localhost> <20151215172649.GK1854@localhost> Date: Wed, 3 Feb 2016 12:17:24 +0100 X-Google-Sender-Auth: NKhVA7ayAzLIJexfyZ0rzjzSA04 Message-ID: Subject: Re: [PATCH] dmaengine: use phys_addr_t for slave configuration From: Geert Uytterhoeven To: Vinod Koul Cc: Linus Walleij , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Lee Jones , dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , =?UTF-8?Q?Niklas_S=C3=B6derlund?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul wrote: > On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote: >> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul wrote: >> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote: >> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij (yes, 2013) >> >> wrote: >> >> > The documentation already says these are physical addresses, and >> >> > we have concluded that any translation into the DMA address space >> >> > needs to reside in the dmaengine driver, so change the type of >> >> > the passed arguments. >> >> > >> >> > Cc: Arnd Bergmann >> >> > Cc: Lee Jones >> >> > Cc: Vinod Koul >> >> > Signed-off-by: Linus Walleij >> >> >> >> What's the status of this one, which has been acked by Lee and Arnd? >> > Looks to have slipped thru. I will redo it >> >> Ping? > > I should be able to do this in next few days... Ping? This is a dependency for adding iommu support to the rcar-dmac driver, cfr. "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers". http://www.spinics.net/lists/linux-renesas-soc/msg00066.html https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html Thank you for applying! >> >> > --- >> >> > include/linux/dmaengine.h | 4 ++-- >> >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> > >> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h >> >> > index 91ac8da..681df5f9 100644 >> >> > --- a/include/linux/dmaengine.h >> >> > +++ b/include/linux/dmaengine.h >> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth { >> >> > */ >> >> > struct dma_slave_config { >> >> > enum dma_transfer_direction direction; >> >> > - dma_addr_t src_addr; >> >> > - dma_addr_t dst_addr; >> >> > + phys_addr_t src_addr; >> >> > + phys_addr_t dst_addr; >> >> > enum dma_slave_buswidth src_addr_width; >> >> > enum dma_slave_buswidth dst_addr_width; >> >> > u32 src_maxburst; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Wed, 3 Feb 2016 12:17:24 +0100 Subject: [PATCH] dmaengine: use phys_addr_t for slave configuration In-Reply-To: <20151215172649.GK1854@localhost> References: <1366967214-20776-1-git-send-email-linus.walleij@linaro.org> <20150710081411.GF836@localhost> <20151215172649.GK1854@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Vinod, On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul wrote: > On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote: >> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul wrote: >> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote: >> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij (yes, 2013) >> >> wrote: >> >> > The documentation already says these are physical addresses, and >> >> > we have concluded that any translation into the DMA address space >> >> > needs to reside in the dmaengine driver, so change the type of >> >> > the passed arguments. >> >> > >> >> > Cc: Arnd Bergmann >> >> > Cc: Lee Jones >> >> > Cc: Vinod Koul >> >> > Signed-off-by: Linus Walleij >> >> >> >> What's the status of this one, which has been acked by Lee and Arnd? >> > Looks to have slipped thru. I will redo it >> >> Ping? > > I should be able to do this in next few days... Ping? This is a dependency for adding iommu support to the rcar-dmac driver, cfr. "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers". http://www.spinics.net/lists/linux-renesas-soc/msg00066.html https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html Thank you for applying! >> >> > --- >> >> > include/linux/dmaengine.h | 4 ++-- >> >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> > >> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h >> >> > index 91ac8da..681df5f9 100644 >> >> > --- a/include/linux/dmaengine.h >> >> > +++ b/include/linux/dmaengine.h >> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth { >> >> > */ >> >> > struct dma_slave_config { >> >> > enum dma_transfer_direction direction; >> >> > - dma_addr_t src_addr; >> >> > - dma_addr_t dst_addr; >> >> > + phys_addr_t src_addr; >> >> > + phys_addr_t dst_addr; >> >> > enum dma_slave_buswidth src_addr_width; >> >> > enum dma_slave_buswidth dst_addr_width; >> >> > u32 src_maxburst; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds