From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32D3C433E6 for ; Tue, 16 Feb 2021 20:34:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE15E64EC2 for ; Tue, 16 Feb 2021 20:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230108AbhBPUee (ORCPT ); Tue, 16 Feb 2021 15:34:34 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:43729 "EHLO mail-oi1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhBPUeb (ORCPT ); Tue, 16 Feb 2021 15:34:31 -0500 Received: by mail-oi1-f180.google.com with SMTP id d20so12569066oiw.10; Tue, 16 Feb 2021 12:34:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SckgAh/+jPmp0yNvSHKEdHbO4vysHXL5ojv3MhSdbzc=; b=KKSElomRTJrzBrrearbunv+rOCe8JYuNEkuRFqhf1o57Szxqkm3ICrf2x4s4S7fsh0 f54YqVqO2kyp1fSfX7/ftqYm8tMUZTPeStYobutmBrEIW6iZT4HmWnbLWKT49yZ+caav VK7SmZXWC8+yyqpL5853Nwo9+5RM7u0GOnTon//J7v8GPQO47UBclRjJiLBmXcilYSNw YEue3hwK2/JW0OF4VrOl0RV2ZMnjTsXDis/GS+OjSsZ2maddRf/+fOZkUUOheagELMaj zeHVI5RtUnOkb2RUnropzFuDSnYyrpJkwkgCneoU3vAIQ4sLqZE8BO3Dihe5LrXRTdFt vlMA== X-Gm-Message-State: AOAM530dejuPIGnJKGm+qsdXXtVEAt/6fqXFTEY+Q36HEHBHiSC+Keb5 OqXcxUiC+VhfgV4+nDQ0Ih5NidkXNZhs3R/TxQ8= X-Google-Smtp-Source: ABdhPJyZE1MGdELiCoijLBBkIxYpdSgDMV2rBV4TNuua1VMGf1JhbvfJO90pNBvSJf7k9MB6wKFpdqGlgCvODv6w1Ws= X-Received: by 2002:aca:d8c6:: with SMTP id p189mr3784710oig.54.1613507630086; Tue, 16 Feb 2021 12:33:50 -0800 (PST) MIME-Version: 1.0 References: <20210216123958.3180014-1-geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 16 Feb 2021 21:33:39 +0100 Message-ID: Subject: Re: [PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when PM domain is added To: Saravana Kannan Cc: Magnus Damm , Sebastian Reichel , Linux-Renesas , linux-arm-kernel , Linux PM , LKML , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, On Tue, Feb 16, 2021 at 7:26 PM Saravana Kannan wrote: > On Tue, Feb 16, 2021 at 4:40 AM Geert Uytterhoeven > wrote: > > Currently, there are two drivers binding to the R-Mobile System > > Controller (SYSC): > > - The rmobile-sysc driver registers PM domains from a core_initcall(), > > and does not use a platform driver, > > - The optional rmobile-reset driver registers a reset handler, and > > does use a platform driver. > > > > As fw_devlink only considers devices, commit bab2d712eeaf9d60 ("PM: > > domains: Mark fwnodes when their powerdomain is added/removed") works > > only for PM Domain drivers where the DT node is a real device node, and > > not for PM Domain drivers using a hierarchical representation inside a > > subnode. Hence if fw_devlink is enabled, probing of on-chip devices > > that are part of the SYSC PM domain is deferred until the optional > > rmobile-reset driver has been bound. If the rmobile-reset driver is > > not available, this will never happen, and thus lead to complete system > > boot failures. > > > > Fix this by explicitly marking the fwnode initialized. > > > > Suggested-by: Saravana Kannan > > Signed-off-by: Geert Uytterhoeven > > --- > > This is v2 of "soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb > > reset handling". > > To be queued in renesas-devel as a fix for v5.12 if v5.12-rc1 will have > > fw_devlink enabled. > Acked-by: Saravana Kannan Thanks! > Keep in mind that this might have to land in driver-core-next since > that API is currently only in driver-core-next. That will be resolved once driver-core-next has been merged in v5.12-rc1. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD28C433E0 for ; Tue, 16 Feb 2021 20:35:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE32C64E7D for ; Tue, 16 Feb 2021 20:35:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE32C64E7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mbWI0Lx2lrjNMiYfSKRHje0M5E+c2L50yO3r23fod+A=; b=DjTAe2ckPNsaO3oTqhdVnW7fk xDn3GmNKTrF4tzYr5n3S45YEWtY28+wOj0t7sj8LL1ykH07RS0LPNiQ3AVPJNYFICqHc0zVC93dAi xkfJpgBiFLX6URK2CSsMVBSLc9hB2mPnfUgSJqqGA0INTumuazo6c52v0uugGuTcaevKgG/ZY/BE0 dJ/IeVtPAZPoUa+rknlas/7GhhGRgSADDE+1zZEZIGlWVRPDgEFexdW6Z7pXXSFrMuKlCb/e9Ov2f VuBFQ43EaAxi+LnTGZxtNCj3gDTb7jL6dLlVjL885FNVLqKnYiNPZfpnbwvdZF93griu3cYkNGLhS F68JkxXVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lC72g-00015U-Lc; Tue, 16 Feb 2021 20:33:54 +0000 Received: from mail-oi1-f173.google.com ([209.85.167.173]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lC72e-00014c-8H for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2021 20:33:53 +0000 Received: by mail-oi1-f173.google.com with SMTP id l19so12590238oih.6 for ; Tue, 16 Feb 2021 12:33:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SckgAh/+jPmp0yNvSHKEdHbO4vysHXL5ojv3MhSdbzc=; b=fpnHlKtoA7I3J9cUr8sLrgST93vEGSYxZV8o30txooDjKpJpJQFpQVNWuO92ExxBKw 12ni8L7WJDuoPNM6bIkkaaDGfG4H/4LivY7FUIVcs7dNVV8d+zWuUmgn4YrNz+iaueF7 dWA5P8olsILjU9dGNmbcO6HePxc7jVFShlVvv6cdv6zkSHCuiURD3H+LV07rLq+Ur9hH 2AEQbf8HY+hIyidtR9bgbvg1JrXbFM9jWyW4KfcEd5hiaE+ZvkfyjOJSYg16p5GbjvDS ZDgVM8CQsx9kZ7VF9V8cNKPaVpTkJ1JkPTQEUe1TrkAW4BZTQZB6YBPOrYrmJdefjq7l VRvQ== X-Gm-Message-State: AOAM530gMcI4lEO1CAu0vNahaoU+YNO5q/Y4MhHzJg6M7/j41pAAHGQY m6cxVZuek1jYfOStau4zHseXx8VzJwk712rryf0= X-Google-Smtp-Source: ABdhPJyZE1MGdELiCoijLBBkIxYpdSgDMV2rBV4TNuua1VMGf1JhbvfJO90pNBvSJf7k9MB6wKFpdqGlgCvODv6w1Ws= X-Received: by 2002:aca:d8c6:: with SMTP id p189mr3784710oig.54.1613507630086; Tue, 16 Feb 2021 12:33:50 -0800 (PST) MIME-Version: 1.0 References: <20210216123958.3180014-1-geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 16 Feb 2021 21:33:39 +0100 Message-ID: Subject: Re: [PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when PM domain is added To: Saravana Kannan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_153352_370132_4E17A1CE X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux PM , Greg Kroah-Hartman , Magnus Damm , LKML , Sebastian Reichel , Linux-Renesas , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Saravana, On Tue, Feb 16, 2021 at 7:26 PM Saravana Kannan wrote: > On Tue, Feb 16, 2021 at 4:40 AM Geert Uytterhoeven > wrote: > > Currently, there are two drivers binding to the R-Mobile System > > Controller (SYSC): > > - The rmobile-sysc driver registers PM domains from a core_initcall(), > > and does not use a platform driver, > > - The optional rmobile-reset driver registers a reset handler, and > > does use a platform driver. > > > > As fw_devlink only considers devices, commit bab2d712eeaf9d60 ("PM: > > domains: Mark fwnodes when their powerdomain is added/removed") works > > only for PM Domain drivers where the DT node is a real device node, and > > not for PM Domain drivers using a hierarchical representation inside a > > subnode. Hence if fw_devlink is enabled, probing of on-chip devices > > that are part of the SYSC PM domain is deferred until the optional > > rmobile-reset driver has been bound. If the rmobile-reset driver is > > not available, this will never happen, and thus lead to complete system > > boot failures. > > > > Fix this by explicitly marking the fwnode initialized. > > > > Suggested-by: Saravana Kannan > > Signed-off-by: Geert Uytterhoeven > > --- > > This is v2 of "soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb > > reset handling". > > To be queued in renesas-devel as a fix for v5.12 if v5.12-rc1 will have > > fw_devlink enabled. > Acked-by: Saravana Kannan Thanks! > Keep in mind that this might have to land in driver-core-next since > that API is currently only in driver-core-next. That will be resolved once driver-core-next has been merged in v5.12-rc1. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel