From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Chris Brandt <Chris.Brandt@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH v4] clk: renesas: cpg-mssr: Add R7S9210 support
Date: Mon, 10 Sep 2018 16:30:45 +0200 [thread overview]
Message-ID: <CAMuHMdXgDu2SeTqbx0ZVzSZ_QASery--2O23LXJoMgsn3StU7w@mail.gmail.com> (raw)
In-Reply-To: <TY1PR01MB1562E64853EEB282E7D6227B8A050@TY1PR01MB1562.jpnprd01.prod.outlook.com>
Hi Chris,
On Mon, Sep 10, 2018 at 4:16 PM Chris Brandt <Chris.Brandt@renesas.com> wrote:
> On Monday, September 10, 2018 1, Geert Uytterhoeven wrote:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in clk-renesas-for-v4.20.
>
> Thank you!
>
> Now that I have a clock, I can go ahead and submit a Device Tree.
> However, I still don't have a solution for my OSTM timer driver when
> using this new clock driver architecture.
>
> Should I remove the ostm entries in r7s9210_mod_clks[] before you queue
> it up?????
I see no issue with converting the OSTM driver to a platform driver (assumed
it works for you ;-)
> > One possible area for improvement is removing the unused entries in the
> > module clocks part of the priv->clks[] array:
> >
> > + .num_hw_mod_clks = 11 * 32, /* includes STBCR0 which doesn't exist
> > */
> >
> > Due to having 8-bit instead of 32-bit registers, 11 * 24 entries are not
> > used.
> > Fixing that means adding more checks in several functions, though, so I
> > don't know if you want to go that far...
>
> That's basically why I didn't touch it. I didn't see any big benefit
> from a system resource point of view.
OK, so you are aware of it.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-09-10 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 16:58 [PATCH v4] clk: renesas: cpg-mssr: Add R7S9210 support Chris Brandt
2018-09-10 14:04 ` Geert Uytterhoeven
2018-09-10 14:16 ` Chris Brandt
2018-09-10 14:16 ` Chris Brandt
2018-09-10 14:30 ` Geert Uytterhoeven [this message]
2018-09-10 18:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXgDu2SeTqbx0ZVzSZ_QASery--2O23LXJoMgsn3StU7w@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Chris.Brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.