From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: m68k: [v5] Convert to genirq (WIP)
Date: Sun, 28 Aug 2011 09:53:22 +0200 [thread overview]
Message-ID: <CAMuHMdXk6_1CO8mvfNtbjf3V0Awh=zFYOcrpbUe2-pZkL5knxQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.00.1108271506320.190@ibook.local>
On Sun, Aug 28, 2011 at 04:08, Finn Thain <fthain@telegraphics.com.au> wrote:
> On Fri, 26 Aug 2011, Geert Uytterhoeven wrote:
>> - [PATCH 18/24]: m68k/mac: Optimize interrupts using chain handlers (NEW)
>
> That patch has a mistake --
>
> irq_set_chained_handler(IRQ_AUTO_4, psc_irq);
> irq_set_handler_data(IRQ_AUTO_3, (void *)0x40);
> irq_set_chained_handler(IRQ_AUTO_5, psc_irq);
> irq_set_handler_data(IRQ_AUTO_3, (void *)0x50);
> irq_set_chained_handler(IRQ_AUTO_6, psc_irq);
> irq_set_handler_data(IRQ_AUTO_3, (void *)0x60);
>
> should be
>
> irq_set_chained_handler(IRQ_AUTO_4, psc_irq);
> irq_set_handler_data(IRQ_AUTO_4, (void *)0x40);
> irq_set_chained_handler(IRQ_AUTO_5, psc_irq);
> irq_set_handler_data(IRQ_AUTO_5, (void *)0x50);
> irq_set_chained_handler(IRQ_AUTO_6, psc_irq);
> irq_set_handler_data(IRQ_AUTO_6, (void *)0x60);
Woops, of course. Thanks!
> On one VIA-based machine that I tested, !CONFIG_USE_GENERIC_HARDIRQS
> gives:
>
> # cat /proc/interrupts
> auto 1: 2299 via1
> auto 2: 3876 via2
> auto 4: 562 SCC
> auto 7: 0 NMI
> mac 10: 590 pmu-shift
> mac 12: 90 pmu-clock
> mac 14: 1635 timer
> mac 17: 3876 nubus
> mac 56: 3879 sonic
>
> whereas, CONFIG_USE_GENERIC_HARDIRQS=y gives:
>
> # cat /proc/interrupts
> CPU0
> 4: 5303 auto SCC
> 7: 0 auto NMI
> 10: 2136 mac pmu-shift
> 12: 607 mac pmu-clock
> 14: 41858 mac timer
> 56: 66876 mac sonic
> ERR: 0
>
> Are there no counters for chained IRQs?
I noticed the same for Amiga.
> Other than these issues everything looks OK. I will test OSS and Baboon
> when I get the relevant hardware set up.
Thanks again!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2011-08-28 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 20:34 m68k: [v5] Convert to genirq (WIP) Geert Uytterhoeven
2011-08-28 2:08 ` Finn Thain
2011-08-28 7:53 ` Geert Uytterhoeven [this message]
2011-08-29 7:36 ` Geert Uytterhoeven
2011-09-02 12:14 ` Finn Thain
2011-09-02 17:24 ` Geert Uytterhoeven
2011-09-02 18:24 ` Geert Uytterhoeven
[not found] ` <4E63291D.5050801@gmail.com>
[not found] ` <CAMuHMdXB5nBRVvUmqake-kV1mbWq+k8vOGHPOSL+2ix6PJW80w@mail.gmail.com>
[not found] ` <CAOmrzkKCGhL2GfDTC_gqKtKfU2vKeqDh1CMZ+BdUCtLEufQhqw@mail.gmail.com>
[not found] ` <4E647F80.8050903@gmail.com>
2011-09-05 20:18 ` Michael Schmitz
2011-09-02 19:53 ` Thomas Gleixner
2011-09-03 2:40 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXk6_1CO8mvfNtbjf3V0Awh=zFYOcrpbUe2-pZkL5knxQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.