From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F21C433E9 for ; Thu, 3 Sep 2020 12:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B40B220767 for ; Thu, 3 Sep 2020 12:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728604AbgICMZM (ORCPT ); Thu, 3 Sep 2020 08:25:12 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42161 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728788AbgICMUo (ORCPT ); Thu, 3 Sep 2020 08:20:44 -0400 Received: by mail-oi1-f193.google.com with SMTP id x14so2883154oic.9; Thu, 03 Sep 2020 05:20:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b0ZpySPy7yqyV6pHx8W2hSYMz0jzeiFIxsxLxJiD2v0=; b=UreiSPv7jZpNexLepp754X/0i2pAh15YPG19kwE7alEtsHrxNuYvoI8WInwIlZvy0e Wft4K/5FHIt3yhrwAoTyFV1iD5cjHqtVCxrcWe/64qYXxAWCCJcxEJdUY0cqfVX0YTpj A3srpaz9YJSNp4Y0d5khGw9B6hoEgRuwlETmQFztjU2sjq+D4JabnDcXDAHPABqGG9mu 2N9KMJr7bGPIhvGioUJi57XY9CdXU8lL7N4j+Tfwkr1HAk0f3DdzFrjhmgRAn2ngO58r vA2+hqKzjo8BSOa/xSACr1o2oU3POrKjyVUB5wrZzi0W54ytu466LhR26SxtwwZin63e 68WQ== X-Gm-Message-State: AOAM531pQsFVbQndflilVDV8gHW/rCG+nGeY9leZMpvsTcxtI7+acgvn VZaW/zCCR2mElVn9r2xy6eA/CmboFMViy8UcKt0= X-Google-Smtp-Source: ABdhPJzi0RqG44kBfG7yCJKST/WW8DdmYKQRVvygPG19xSbPCTmfEGN6JDpJovKl1yQPxiTTd5NyotNlR35Bf088kaU= X-Received: by 2002:aca:b742:: with SMTP id h63mr1755272oif.148.1599135622590; Thu, 03 Sep 2020 05:20:22 -0700 (PDT) MIME-Version: 1.0 References: <20200825162718.5838-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200825162718.5838-5-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20200825162718.5838-5-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 3 Sep 2020 14:20:11 +0200 Message-ID: Subject: Re: [PATCH 4/4] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication To: Lad Prabhakar Cc: Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Prabhakar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar wrote: > Add support for LED trigger on SD2 interface. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > @@ -63,6 +63,16 @@ > enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>; > }; > > + leds { > + compatible = "gpio-leds"; > + > + sdhi2_led { > + label = "sdio-led"; > + gpios = <&gpio5 22 GPIO_ACTIVE_LOW>; GPIO_ACTIVE_HIGH? The LED is driven by an NPN transistor, with the LED between 3.3V and the transistor's collector. > + linux,default-trigger = "mmc1"; > + }; > + }; > + > lvds-receiver { > compatible = "ti,ds90cf384a", "lvds-decoder"; > vcc-supply = <&vcc_3v3_tft1>; With the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds