From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE56C43334 for ; Tue, 7 Jun 2022 08:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238380AbiFGIn3 (ORCPT ); Tue, 7 Jun 2022 04:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbiFGInX (ORCPT ); Tue, 7 Jun 2022 04:43:23 -0400 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3A685F8DF; Tue, 7 Jun 2022 01:43:21 -0700 (PDT) Received: by mail-qt1-f179.google.com with SMTP id hf10so12123902qtb.7; Tue, 07 Jun 2022 01:43:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=trIBU79MD2ZqYXz6AJVM4tpcbmd/BhR2QCKmFEHT7ZI=; b=vVnrsf+qmaxh1j0aAZbPCPAnMyFPkwXtNkrwo2u0qV06wpdcWrK09/aruC+01Y32yw Lbb9BdfUsmRVlQ8VhZVVcvoMA8GmLmvA6XiavHvgwCa019mDKxbcgR5fdyktTuNApHy4 KnOJS0gOZAmfXxOaf/gw9Lpb2L+jLIbevFQqIDnrN4R2R3/rlWaqF1C4Lqt0MD49AEi9 v27vYSgQTZrjkyr/r92Pcm9qESTXtaxhscy2G3gAKYbkJYgav/r/jiDR4x0RRrU8AKbv vK2JI0dz4ksmxosvDcmws6dLYZjOyj0pCNuz+1bQFsHh+Xo4E6yEVzq98rFRaLA+L5X7 FEkQ== X-Gm-Message-State: AOAM531cEWpfTbJDFLmPhSQBeyU2oU8rNmXWWJ0SV1amcpyxIEIQMT+K /J9PZtFxcib/0VhL29ufCLRt45c392spsw== X-Google-Smtp-Source: ABdhPJxGN2dmQfazk+egpqsUQyK9Eyi/WXgiXZRRqrWAvcUfzkHha8aa6QX4EOhk9phjm6dKasAA1Q== X-Received: by 2002:ac8:5d8b:0:b0:2fb:1a6:61f5 with SMTP id d11-20020ac85d8b000000b002fb01a661f5mr21692276qtx.603.1654591400852; Tue, 07 Jun 2022 01:43:20 -0700 (PDT) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id v128-20020a37dc86000000b0069fc13ce244sm13496872qki.117.2022.06.07.01.43.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 01:43:20 -0700 (PDT) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-30c1c9b9b6cso167429027b3.13; Tue, 07 Jun 2022 01:43:20 -0700 (PDT) X-Received: by 2002:a0d:d481:0:b0:30c:44f1:2721 with SMTP id w123-20020a0dd481000000b0030c44f12721mr30757906ywd.283.1654591400102; Tue, 07 Jun 2022 01:43:20 -0700 (PDT) MIME-Version: 1.0 References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr> <20220604163000.211077-1-mailhol.vincent@wanadoo.fr> <20220604163000.211077-5-mailhol.vincent@wanadoo.fr> In-Reply-To: <20220604163000.211077-5-mailhol.vincent@wanadoo.fr> From: Geert Uytterhoeven Date: Tue, 7 Jun 2022 10:43:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/7] can: Kconfig: add CONFIG_CAN_RX_OFFLOAD To: Vincent Mailhol Cc: Marc Kleine-Budde , linux-can@vger.kernel.org, Linux Kernel Mailing List , Max Staudt , Oliver Hartkopp , netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi Vincent, On Sun, Jun 5, 2022 at 12:25 AM Vincent Mailhol wrote: > Only a few drivers rely on the CAN rx offload framework (as of the > writing of this patch, only four: flexcan, m_can, mcp251xfd and > ti_hecc). Give the option to the user to deselect this features during > compilation. Thanks for your patch! > The drivers relying on CAN rx offload are in different sub > folders. All of these drivers get tagged with "select CAN_RX_OFFLOAD" > so that the option is automatically enabled whenever one of those > driver is chosen. Great! But... > > Signed-off-by: Vincent Mailhol > --- a/drivers/net/can/Kconfig > +++ b/drivers/net/can/Kconfig > @@ -102,6 +102,20 @@ config CAN_CALC_BITTIMING > > If unsure, say Y. > > +config CAN_RX_OFFLOAD > + bool "CAN RX offload" > + default y ... then why does this default to "y"? > + help > + Framework to offload the controller's RX FIFO during one > + interrupt. The CAN frames of the FIFO are read and put into a skb > + queue during that interrupt and transmitted afterwards in a NAPI > + context. > + > + The additional features selected by this option will be added to the > + can-dev module. > + > + If unsure, say Y. ... and do you suggest to enable this? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds