From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9272EC4338F for ; Mon, 9 Aug 2021 15:15:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B83960F8F for ; Mon, 9 Aug 2021 15:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235326AbhHIPPu (ORCPT ); Mon, 9 Aug 2021 11:15:50 -0400 Received: from mail-ua1-f52.google.com ([209.85.222.52]:43785 "EHLO mail-ua1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234075AbhHIPPt (ORCPT ); Mon, 9 Aug 2021 11:15:49 -0400 Received: by mail-ua1-f52.google.com with SMTP id 91so7168477uas.10 for ; Mon, 09 Aug 2021 08:15:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehvDAZzdXJSc27GvA0fWut4GARnIXIBF9w/5HJVeQDw=; b=OPGiktWWhZK3HBFovlxH5mOCPdWuDe2UhtoBm4OMBAbs0bBcW8m5ldCbPpg+qqT3+6 J1GcAuywUush/ohjOHXWRuWgJ2PwcA1BA3KjXxWTO8biBlCvZne2Fr1jehlTPKF/OgPp uAaEnuGgWiob/Lor/Jd/Cm/feDg+HAaIrJk6iAQxorp1uyDi5ixbA6Vs2sGe4zbu8S83 4dQu++vpa+8cMu602TYfoYgp8dfJ7LFos823UoIrwM+/O+m4A7I2vUTRdc7xXbLCUMhr ikeuaM1yogcuN5oikw6LeWyB8hazlmTIYfr81hm97wDw4DGXWxU3Ya44IvIbI+NvDcoE BLKA== X-Gm-Message-State: AOAM533M2AryM5csrl/v1FMQn+SX4wT+OV9v36R+juEr87IaE/Feys+o Tf6haV7lm+Bu1F/GQKSgyThSD8LceixTKdFZFrc= X-Google-Smtp-Source: ABdhPJx13QvlWE82lmqYd1A4xsQv/vLk/nFwWnXoXrYRwmZu/glnNQK2zXj/Aai5Ut2bimNcDxzESJb0alo4cTnqPzg= X-Received: by 2002:ab0:1d05:: with SMTP id j5mr1649669uak.2.1628522129038; Mon, 09 Aug 2021 08:15:29 -0700 (PDT) MIME-Version: 1.0 References: <20210803155452.435812-1-lee.jones@linaro.org> <20210803155452.435812-2-lee.jones@linaro.org> In-Reply-To: <20210803155452.435812-2-lee.jones@linaro.org> From: Geert Uytterhoeven Date: Mon, 9 Aug 2021 17:15:17 +0200 Message-ID: Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules To: Lee Jones Cc: Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 3, 2021 at 5:56 PM Lee Jones wrote: > A recent attempt to convert the Power Reset Restart driver to tristate > failed because of the following compile error (reported once merged by > Stephen Rothwell via Linux Next): > > ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined! > > This error occurs since some of the machine_restart() instances are > not currently exported for use in modules. This patch aims to rectify > that. > > Signed-off-by: Lee Jones > NB: If it's safe to omit some of these, let me know and I'll revise the patch. How do you plan to handle that? Isn't this an all-or-nothing export? > arch/m68k/kernel/process.c | 1 + Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CD0C4338F for ; Mon, 9 Aug 2021 15:18:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5225F60F35 for ; Mon, 9 Aug 2021 15:18:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5225F60F35 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cczwn4dB7IONu8kByAVgAe4b1PDBebIhRsU0p5db1ak=; b=xpc7/P9MQMsaH8 MGMpUyQx/zvx66LGrXdPsGsBmiBN5jWbvpNDxDA6Y7hMpLSJAbsg2VMBJmTK6AGX++vCc+dmDnsRm E3TeH5G5Hc8YM2A2jZBO64JlO8VaHIgTzZuigPpatclKBJsmcPeuXuT7UrypcwR/NODu88edFOuZt 9FiIvlb8B+s6kluc44D905/RTxMAV6CI6q6CZ4pqanSW4N6ZDxLV1NaORNM2QyzZzDY9biq+9jvoe K2xnSQgtTdLRjVFV9MnYUr2gXSAYn1xvFriXjFZGlmXkfuStOk9H3rk7EQjY0JdUwMe8/a6gV1MOW e0bZQZKxiKVuyZi60sWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD702-0015qn-3L; Mon, 09 Aug 2021 15:15:34 +0000 Received: from mail-ua1-f47.google.com ([209.85.222.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD6zy-0015q0-5D for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 15:15:31 +0000 Received: by mail-ua1-f47.google.com with SMTP id t26so7161133uao.12 for ; Mon, 09 Aug 2021 08:15:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehvDAZzdXJSc27GvA0fWut4GARnIXIBF9w/5HJVeQDw=; b=irgEHW2kK9MihU3q0d1j430HT/xk2XNMPV36qUtEYDAszoo5bxI47XcsfxPTmKlyRI G61m9uJ2BcBryveAtR9rKEdI7lFfZM8dVJvt/KXQWrAJdgwSv81PVDZPKDS1ZNZ7Q4Jf Zs3NJs//Aw7TqU4+JhqaCsICMKCyhH7dZdUwRgLDYYeSEOslSC24p3ruEkIEVL6Ddsms X7VSjAF0unI3/BvZvZmDBp9f45gvizn8PZN7+Ha06YFNNPqmP5qCIsaVdrp2eBMkIrNo OB4MYt/F6sFeF1iVEqHnqy88P5asY8a80fPsG0SCgYkl7kdMgsSrmKUkNnkhlcflAMcR OMlw== X-Gm-Message-State: AOAM531zd1P1o1fMi22ELMvMqjE/432QXP1+DlPnk3YQN18MySQyn2dG zAlBxP8oJsNKXSkGdVxZ+RBSToTwd4Q7Y0I4BpA= X-Google-Smtp-Source: ABdhPJx13QvlWE82lmqYd1A4xsQv/vLk/nFwWnXoXrYRwmZu/glnNQK2zXj/Aai5Ut2bimNcDxzESJb0alo4cTnqPzg= X-Received: by 2002:ab0:1d05:: with SMTP id j5mr1649669uak.2.1628522129038; Mon, 09 Aug 2021 08:15:29 -0700 (PDT) MIME-Version: 1.0 References: <20210803155452.435812-1-lee.jones@linaro.org> <20210803155452.435812-2-lee.jones@linaro.org> In-Reply-To: <20210803155452.435812-2-lee.jones@linaro.org> From: Geert Uytterhoeven Date: Mon, 9 Aug 2021 17:15:17 +0200 Message-ID: Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules To: Lee Jones Cc: Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_081530_247838_CD40F5D4 X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 3, 2021 at 5:56 PM Lee Jones wrote: > A recent attempt to convert the Power Reset Restart driver to tristate > failed because of the following compile error (reported once merged by > Stephen Rothwell via Linux Next): > > ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined! > > This error occurs since some of the machine_restart() instances are > not currently exported for use in modules. This patch aims to rectify > that. > > Signed-off-by: Lee Jones > NB: If it's safe to omit some of these, let me know and I'll revise the patch. How do you plan to handle that? Isn't this an all-or-nothing export? > arch/m68k/kernel/process.c | 1 + Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel