All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: git@vger.kernel.org
Subject: git send-email splits name with comma
Date: Mon, 4 Oct 2021 16:11:04 +0200	[thread overview]
Message-ID: <CAMuHMdXuTqUu6-b0y6VSFbEz7HKdH6U+__n7B8JRnO_ZWNeeLQ@mail.gmail.com> (raw)

Hi all,

If the name of an email address contains a comma, it will be split
incorrectly into multiple addresses.  A public example can be found
at[1].  I originally say this with git 2.25.1, as packaged by my distro,
but I could reproduce it with the latest version from git:

    $ git send-email  --to "foo bar, geert <geert@linux-m68k.org>"
/tmp/dummy.patch
    /tmp/dummy.patch
    (mbox) Adding cc: Geert Uytterhoeven <geert@linux-m68k.org> from
line 'From: Geert Uytterhoeven <geert@linux-m68k.org>'

    From: Geert Uytterhoeven <geert@linux-m68k.org>
    To: foo,
            bar,
            geert <geert@linux-m68k.org>
    Subject: [PATCH] dummy test
    Date: Mon,  4 Oct 2021 15:52:53 +0200
    Message-Id: <git-2.33.0.610.3.git.geert@linux-m68k.org
    X-Mailer: git-send-email 2.33.0.610.gcefe983a320c03d7
    MIME-Version: 1.0
    Content-Transfer-Encoding: 8bit

        The Cc list above has been expanded by additional
        addresses found in the patch commit message. By default
        send-email prompts before sending whenever this occurs.
        This behavior is controlled by the sendemail.confirm
        configuration setting.

        For additional information, run 'git send-email --help'.
        To retain the current behavior, but squelch this message,
        run 'git config --global sendemail.confirm auto'.

    Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll):
    OK. Log says:
    Sendmail: /usr/sbin/sendmail -i foo bar geert@linux-m68k.org
    From: Geert Uytterhoeven <geert@linux-m68k.org>
    To: foo,
            bar,
            geert <geert@linux-m68k.org>
    Subject: [PATCH] dummy test
    Date: Mon,  4 Oct 2021 15:52:53 +0200
    Message-Id: <git-2.33.0.610.3.git.geert@linux-m68k.org
    X-Mailer: git-send-email 2.33.0.610.gcefe983a320c03d7
    MIME-Version: 1.0
    Content-Transfer-Encoding: 8bit

    Result: OK

So "foo bar, geert <geert@linux-m68k.org>" is split in three parts,
and /usr/sbin/sendmail (exim 4.93 in my case) will have sent the email to
"foo" and "bar" (both  extended with my local non-public domain) and
"geert <geert@linux-m68k.org>".

Thanks!

[1] "Enrico Weigelt, metux IT consult <lkml@metux.net>" is split in 3 parts
    https://lore.kernel.org/linux-gpio/c987d0bf744150ca05bd952f5f9e5fb3244d27b0.1633350340.git.geert+renesas@glider.be/raw

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

             reply	other threads:[~2021-10-04 14:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 14:11 Geert Uytterhoeven [this message]
2021-10-04 14:31 ` git send-email splits name with comma Andreas Schwab
2021-10-04 17:18   ` Geert Uytterhoeven
2021-10-04 18:47     ` Junio C Hamano
2021-10-04 19:56       ` Geert Uytterhoeven
2021-10-04 23:47         ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXuTqUu6-b0y6VSFbEz7HKdH6U+__n7B8JRnO_ZWNeeLQ@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.