From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20190506234631.113226-1-chris.brandt@renesas.com> <20190506234631.113226-2-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 8 May 2019 08:59:33 +0200 Message-ID: Subject: Re: [PATCH 01/10] phy: renesas: rcar-gen3-usb2: Add uses_usb_x1 option Content-Type: text/plain; charset="UTF-8" To: Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas List-ID: Hi Chris, On Tue, May 7, 2019 at 10:27 PM Chris Brandt wrote: > On Tue, May 07, 2019 1, Geert Uytterhoeven wrote: > > > So with that said, does a uses-usb-x1 property make more sense? > > > > No ;-) > > So.... > > I guess the first patch in the series needs to add this to the .dtsi: > > usb_x1_clk: usb_x1 { > #clock-cells = <0>; > compatible = "fixed-clock"; > /* If clk present, value must be set by board */ > clock-frequency = <0>; > }; > > Then I can reference "usb_x1" in the driver and see if it is set to > non-zero. > > What do you think? Exactly! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F7AC04A6B for ; Wed, 8 May 2019 06:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12DE4214AF for ; Wed, 8 May 2019 06:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726464AbfEHG7r (ORCPT ); Wed, 8 May 2019 02:59:47 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:36392 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfEHG7r (ORCPT ); Wed, 8 May 2019 02:59:47 -0400 Received: by mail-vk1-f194.google.com with SMTP id d74so4707797vka.3; Tue, 07 May 2019 23:59:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hb3fPf5B0g2t3lQ+CxtsUvfMJ5uLadXuXQz78ww3fYU=; b=G7QEGx7GDDKHzNKCTQgVo1xdT5l5jA8HnO0Lb5xhAZRokOEALifEnhY2APdS3XVR3n uwn3kRwE1GADfAV1B07F4wIONZrTYGiQHTbUtTTSoix+Ci92IjKahK+jwFIUvF41dGMz Kra0KVz55NW7xU0xjxRPJ0yoAgaJETk6vFMuYiMpBZ72Wn8S/wpiCobtIwR0CrpFty7m CFXiyHZanCw8hqLA4p8sax3hfBV8ezXrm+rB9hbnUWJn8ad0H8aILXHuRAoR/7AwEjeb fLLwnbskRMNDKGwdqCb/WqiHddsp/WP9t6TTOxnf3KUwmDEZdkfIGctmeFn3kHZV6ALt n/Tg== X-Gm-Message-State: APjAAAVUMiIKAoyuqnkxk/ZFgU2VnjTZXq0FFjYVNI0GhdnKe/sHjJev aTcm4wFJC8rxh/PPaOXDPqzGxvgykrHDPJuagQE= X-Google-Smtp-Source: APXvYqzDHFkWbgySn+FGkvYLb5zdM4esJpytVoVC/45AAGMJR0HiALWM3MGwMRiitZNx7TU69wuIUv49l3BaA9SVOfQ= X-Received: by 2002:a1f:ff0b:: with SMTP id p11mr12708100vki.83.1557298786234; Tue, 07 May 2019 23:59:46 -0700 (PDT) MIME-Version: 1.0 References: <20190506234631.113226-1-chris.brandt@renesas.com> <20190506234631.113226-2-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 8 May 2019 08:59:33 +0200 Message-ID: Subject: Re: [PATCH 01/10] phy: renesas: rcar-gen3-usb2: Add uses_usb_x1 option To: Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Chris, On Tue, May 7, 2019 at 10:27 PM Chris Brandt wrote: > On Tue, May 07, 2019 1, Geert Uytterhoeven wrote: > > > So with that said, does a uses-usb-x1 property make more sense? > > > > No ;-) > > So.... > > I guess the first patch in the series needs to add this to the .dtsi: > > usb_x1_clk: usb_x1 { > #clock-cells = <0>; > compatible = "fixed-clock"; > /* If clk present, value must be set by board */ > clock-frequency = <0>; > }; > > Then I can reference "usb_x1" in the driver and see if it is set to > non-zero. > > What do you think? Exactly! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds