From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 21 Jan 2019 08:19:11 +0000 Subject: Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures Message-Id: List-Id: References: <20190118161835.2259170-1-arnd@arndb.de> <20190118161835.2259170-30-arnd@arndb.de> <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> In-Reply-To: <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russell King - ARM Linux admin Cc: Andy Lutomirski , Arnd Bergmann , y2038 Mailman List , Linux API , LKML , linux-arch , Matt Turner , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Michal Simek , Paul Burton , Helge Deller , Benjamin Herrenschmidt , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Rich Felker , "David S. Miller" Hi Russell, On Sat, Jan 19, 2019 at 3:29 PM Russell King - ARM Linux admin wrote: > On Fri, Jan 18, 2019 at 11:53:25AM -0800, Andy Lutomirski wrote: > > On Fri, Jan 18, 2019 at 11:33 AM Arnd Bergmann wrote: > > > On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > > > > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > > > > - Once we get to 512, we clash with the x32 numbers (unless > > > > > we remove x32 support first), and probably have to skip > > > > > a few more. I also considered using the 512..547 space > > > > > for 32-bit-only calls (which never clash with x32), but > > > > > that also seems to add a bit of complexity. > > > > > > > > I have a patch that I'll send soon to make x32 use its own table. As > > > > far as I'm concerned, 547 is *it*. 548 is just a normal number and is > > > > not special. But let's please not reuse 512..547 for other purposes > > > > on x86 variants -- that way lies even more confusion, IMO. > > > > > > Fair enough, the space for those numbers is cheap enough here. > > > I take it you mean we also should not reuse that number space if > > > we were to decide to remove x32 soon, but you are not worried > > > about clashing with arch/alpha when everything else uses consistent > > > numbers? > > > > > > > I think we have two issues if we reuse those numbers for new syscalls. > > First, I'd really like to see new syscalls be numbered consistently > > everywhere, or at least on all x86 variants, and we can't on x32 > > because they mean something else. Perhaps more importantly, due to > > what is arguably a rather severe bug, issuing a native x86_64 syscall > > (x32 bit clear) with nr in the range 512..547 does *not* return > > -ENOSYS on a kernel with x32 enabled. Instead it does something that > > is somewhat arbitrary. With my patch applied, it will return -ENOSYS, > > but old kernels will still exist, and this will break syscall probing. > > > > Can we perhaps just start the consistent numbers above 547 or maybe > > block out 512..547 in the new regime? > > I don't think you gain much with that kind of scheme - it won't take > very long before an architecture misses having a syscall added, and > then someone else adds their own. Been there with ARM - I was keeping > the syscall table in the same order as x86 for new syscalls, but now Same for m68k, and probably other architectures. > that others have been adding syscalls to the table since I converted > ARM to the tabular form, that's now gone out the window. > > So, I think it's completely pointless to do what you're suggesting. > We'll just end up with a big hole in the middle of the syscall table > and then revert back to random numbering of syscalls thereafter again. I believe the plan is to add future syscalls for all architectures in a single commit, to keep everything in sync. Regardless, I'm wondering what to do with the holes marked "room for arch specific calls". When is a syscall really arch-specific, and can it be added there, and when does it turn out (later) that it isn't, breaking the synchronization again? The pkey syscalls may be a bad example, as AFAIU they can be implemented on some architectures, but not on some others. Still, I had skipped them when adding new syscalls to m68k. Perhaps we should get rid of the notion of "arch-specific syscalls", and reserve a slot everywhere anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544EBC282DB for ; Mon, 21 Jan 2019 08:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 252DD20855 for ; Mon, 21 Jan 2019 08:19:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729255AbfAUIT0 (ORCPT ); Mon, 21 Jan 2019 03:19:26 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:41216 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbfAUITZ (ORCPT ); Mon, 21 Jan 2019 03:19:25 -0500 Received: by mail-vs1-f67.google.com with SMTP id t17so12087893vsc.8; Mon, 21 Jan 2019 00:19:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eNwdIYQYJT6Pc3PhNslPpG4rGotSgFNPjN+8uubEzLc=; b=Vo89ajKOwug4ns6UZvMUCUEmNFht3W/Wx6abnzf9O5tKN9U1kYLoWjLOEvNh+CMkSV pKemCXcpNgtHZ410WfIIjTv2OhiKv9Ix5wisMRvLmmoYJ7nWvORqFlYY0SiiawXuk/Eb iddRCgLYkPQAi2Q5k5QRKsIy1TKtyavXX+QwWjivTOlJZh+LGsiDekmyIR95X3xsPe+u 2lUqRxDJLfbbrBLK9tDoFeaM0VkVkIXWWegzPHR5VzDgzw7kGGHTCDWLTzd6o1jiiyF0 KJngLy/50a1MroFrwCkj68ZCpUrNlRRneAd8D3Po0LSDzBomPaLp/sYW8fIJHf/lnjXX WwTQ== X-Gm-Message-State: AJcUukfGB3cNe9n0b5lieVnxC07tAKkZPYVwdg7An2iD11h/pRk2BJNi Kyo0djFImCANX0FAajFDz793Fw6jDJs1RIkqPHQ= X-Google-Smtp-Source: ALg8bN7Na9+3XJsTlxP4CnU3flevzSwRj2I8fvGc/mex1gzD8KE0G4LYkLwzBJ2YcDmVU42ivUABTg84S/YKw2y1uBc= X-Received: by 2002:a67:3885:: with SMTP id n5mr10324892vsi.96.1548058763095; Mon, 21 Jan 2019 00:19:23 -0800 (PST) MIME-Version: 1.0 References: <20190118161835.2259170-1-arnd@arndb.de> <20190118161835.2259170-30-arnd@arndb.de> <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> In-Reply-To: <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> From: Geert Uytterhoeven Date: Mon, 21 Jan 2019 09:19:11 +0100 Message-ID: Subject: Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures To: Russell King - ARM Linux admin Cc: Andy Lutomirski , Arnd Bergmann , y2038 Mailman List , Linux API , LKML , linux-arch , Matt Turner , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Michal Simek , Paul Burton , Helge Deller , Benjamin Herrenschmidt , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , X86 ML , Max Filippov , Andrew Morton , Deepa Dinamani , "Eric W. Biederman" , Firoz Khan , alpha , linux-arm-kernel , "linux-ia64@vger.kernel.org" , linux-m68k , linux-mips@vger.kernel.org, Parisc List , linuxppc-dev , linux-s390 , Linux-sh list , sparclinux , Network Development , Linux FS Devel Content-Type: text/plain; charset="UTF-8" Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Hi Russell, On Sat, Jan 19, 2019 at 3:29 PM Russell King - ARM Linux admin wrote: > On Fri, Jan 18, 2019 at 11:53:25AM -0800, Andy Lutomirski wrote: > > On Fri, Jan 18, 2019 at 11:33 AM Arnd Bergmann wrote: > > > On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > > > > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > > > > - Once we get to 512, we clash with the x32 numbers (unless > > > > > we remove x32 support first), and probably have to skip > > > > > a few more. I also considered using the 512..547 space > > > > > for 32-bit-only calls (which never clash with x32), but > > > > > that also seems to add a bit of complexity. > > > > > > > > I have a patch that I'll send soon to make x32 use its own table. As > > > > far as I'm concerned, 547 is *it*. 548 is just a normal number and is > > > > not special. But let's please not reuse 512..547 for other purposes > > > > on x86 variants -- that way lies even more confusion, IMO. > > > > > > Fair enough, the space for those numbers is cheap enough here. > > > I take it you mean we also should not reuse that number space if > > > we were to decide to remove x32 soon, but you are not worried > > > about clashing with arch/alpha when everything else uses consistent > > > numbers? > > > > > > > I think we have two issues if we reuse those numbers for new syscalls. > > First, I'd really like to see new syscalls be numbered consistently > > everywhere, or at least on all x86 variants, and we can't on x32 > > because they mean something else. Perhaps more importantly, due to > > what is arguably a rather severe bug, issuing a native x86_64 syscall > > (x32 bit clear) with nr in the range 512..547 does *not* return > > -ENOSYS on a kernel with x32 enabled. Instead it does something that > > is somewhat arbitrary. With my patch applied, it will return -ENOSYS, > > but old kernels will still exist, and this will break syscall probing. > > > > Can we perhaps just start the consistent numbers above 547 or maybe > > block out 512..547 in the new regime? > > I don't think you gain much with that kind of scheme - it won't take > very long before an architecture misses having a syscall added, and > then someone else adds their own. Been there with ARM - I was keeping > the syscall table in the same order as x86 for new syscalls, but now Same for m68k, and probably other architectures. > that others have been adding syscalls to the table since I converted > ARM to the tabular form, that's now gone out the window. > > So, I think it's completely pointless to do what you're suggesting. > We'll just end up with a big hole in the middle of the syscall table > and then revert back to random numbering of syscalls thereafter again. I believe the plan is to add future syscalls for all architectures in a single commit, to keep everything in sync. Regardless, I'm wondering what to do with the holes marked "room for arch specific calls". When is a syscall really arch-specific, and can it be added there, and when does it turn out (later) that it isn't, breaking the synchronization again? The pkey syscalls may be a bad example, as AFAIU they can be implemented on some architectures, but not on some others. Still, I had skipped them when adding new syscalls to m68k. Perhaps we should get rid of the notion of "arch-specific syscalls", and reserve a slot everywhere anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures Date: Mon, 21 Jan 2019 09:19:11 +0100 Message-ID: References: <20190118161835.2259170-1-arnd@arndb.de> <20190118161835.2259170-30-arnd@arndb.de> <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux admin Cc: Andy Lutomirski , Arnd Bergmann , y2038 Mailman List , Linux API , LKML , linux-arch , Matt Turner , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Michal Simek , Paul Burton , Helge Deller , Benjamin Herrenschmidt , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Rich Felker , "David S. Miller" List-Id: linux-api@vger.kernel.org Hi Russell, On Sat, Jan 19, 2019 at 3:29 PM Russell King - ARM Linux admin wrote: > On Fri, Jan 18, 2019 at 11:53:25AM -0800, Andy Lutomirski wrote: > > On Fri, Jan 18, 2019 at 11:33 AM Arnd Bergmann wrote: > > > On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > > > > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > > > > - Once we get to 512, we clash with the x32 numbers (unless > > > > > we remove x32 support first), and probably have to skip > > > > > a few more. I also considered using the 512..547 space > > > > > for 32-bit-only calls (which never clash with x32), but > > > > > that also seems to add a bit of complexity. > > > > > > > > I have a patch that I'll send soon to make x32 use its own table. As > > > > far as I'm concerned, 547 is *it*. 548 is just a normal number and is > > > > not special. But let's please not reuse 512..547 for other purposes > > > > on x86 variants -- that way lies even more confusion, IMO. > > > > > > Fair enough, the space for those numbers is cheap enough here. > > > I take it you mean we also should not reuse that number space if > > > we were to decide to remove x32 soon, but you are not worried > > > about clashing with arch/alpha when everything else uses consistent > > > numbers? > > > > > > > I think we have two issues if we reuse those numbers for new syscalls. > > First, I'd really like to see new syscalls be numbered consistently > > everywhere, or at least on all x86 variants, and we can't on x32 > > because they mean something else. Perhaps more importantly, due to > > what is arguably a rather severe bug, issuing a native x86_64 syscall > > (x32 bit clear) with nr in the range 512..547 does *not* return > > -ENOSYS on a kernel with x32 enabled. Instead it does something that > > is somewhat arbitrary. With my patch applied, it will return -ENOSYS, > > but old kernels will still exist, and this will break syscall probing. > > > > Can we perhaps just start the consistent numbers above 547 or maybe > > block out 512..547 in the new regime? > > I don't think you gain much with that kind of scheme - it won't take > very long before an architecture misses having a syscall added, and > then someone else adds their own. Been there with ARM - I was keeping > the syscall table in the same order as x86 for new syscalls, but now Same for m68k, and probably other architectures. > that others have been adding syscalls to the table since I converted > ARM to the tabular form, that's now gone out the window. > > So, I think it's completely pointless to do what you're suggesting. > We'll just end up with a big hole in the middle of the syscall table > and then revert back to random numbering of syscalls thereafter again. I believe the plan is to add future syscalls for all architectures in a single commit, to keep everything in sync. Regardless, I'm wondering what to do with the holes marked "room for arch specific calls". When is a syscall really arch-specific, and can it be added there, and when does it turn out (later) that it isn't, breaking the synchronization again? The pkey syscalls may be a bad example, as AFAIU they can be implemented on some architectures, but not on some others. Still, I had skipped them when adding new syscalls to m68k. Perhaps we should get rid of the notion of "arch-specific syscalls", and reserve a slot everywhere anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B10C282DB for ; Mon, 21 Jan 2019 08:52:15 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39F0C2084A for ; Mon, 21 Jan 2019 08:52:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39F0C2084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43jlfj0GgDzDqWy for ; Mon, 21 Jan 2019 19:52:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=209.85.217.65; helo=mail-vs1-f65.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43jkws2FW1zDqD8 for ; Mon, 21 Jan 2019 19:19:25 +1100 (AEDT) Received: by mail-vs1-f65.google.com with SMTP id n13so12131335vsk.4 for ; Mon, 21 Jan 2019 00:19:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eNwdIYQYJT6Pc3PhNslPpG4rGotSgFNPjN+8uubEzLc=; b=iZTGoGDnA72iItJgFIySlFB5yOzJWpL8tcskDaOgMRpbIMrkMTDSXnwuJRbG8jFwXi 1Do8SYyVH8GJeamHRdweR7YoXbuRZZUs1VpD8bSUnNHMwDe+jjFimOENrXVnrq/ZYdJ6 KfOMgck08ILvFQoWS9Mx3WtB1muvH7IQ1n/kN4pcuoqRRHWpyEvQWT83dbKXYaJB6hdC Me3s8NF9GV7cR48KdlU/azxwRU+X7I39ClBpx5So2pmEZGZB+ZW8ofj9P5Ikt1xEq5Id XceiM55oGu5hw28aWfGD45G1bAcYDzqvGX/1B9WxC3Q+AIxE1507bbYsRHvu8PL5jdCe sUFg== X-Gm-Message-State: AJcUukdKRu7YI9gBY7c5urXNbw6WIeG7KdKni6tIBGw/YKw1ZDBZJDC+ tqgIsakxkGcjzMSpOnn/qVX4VExTqdnQndWvtpk= X-Google-Smtp-Source: ALg8bN7Na9+3XJsTlxP4CnU3flevzSwRj2I8fvGc/mex1gzD8KE0G4LYkLwzBJ2YcDmVU42ivUABTg84S/YKw2y1uBc= X-Received: by 2002:a67:3885:: with SMTP id n5mr10324892vsi.96.1548058763095; Mon, 21 Jan 2019 00:19:23 -0800 (PST) MIME-Version: 1.0 References: <20190118161835.2259170-1-arnd@arndb.de> <20190118161835.2259170-30-arnd@arndb.de> <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> In-Reply-To: <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> From: Geert Uytterhoeven Date: Mon, 21 Jan 2019 09:19:11 +0100 Message-ID: Subject: Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures To: Russell King - ARM Linux admin Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , "linux-ia64@vger.kernel.org" , Linux-sh list , Will Deacon , linux-mips@vger.kernel.org, Max Filippov , Network Development , Deepa Dinamani , "H. Peter Anvin" , sparclinux , linux-arch , linux-s390 , y2038 Mailman List , Helge Deller , X86 ML , Ingo Molnar , Firoz Khan , Catalin Marinas , Matt Turner , Fenghua Yu , Arnd Bergmann , Heiko Carstens , Linux FS Devel , linux-m68k , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel , Michal Simek , Tony Luck , Parisc List , Linux API , LKML , Paul Burton , "Eric W. Biederman" , alpha , Martin Schwidefsky , Andrew Morton , linuxppc-dev , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Russell, On Sat, Jan 19, 2019 at 3:29 PM Russell King - ARM Linux admin wrote: > On Fri, Jan 18, 2019 at 11:53:25AM -0800, Andy Lutomirski wrote: > > On Fri, Jan 18, 2019 at 11:33 AM Arnd Bergmann wrote: > > > On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > > > > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > > > > - Once we get to 512, we clash with the x32 numbers (unless > > > > > we remove x32 support first), and probably have to skip > > > > > a few more. I also considered using the 512..547 space > > > > > for 32-bit-only calls (which never clash with x32), but > > > > > that also seems to add a bit of complexity. > > > > > > > > I have a patch that I'll send soon to make x32 use its own table. As > > > > far as I'm concerned, 547 is *it*. 548 is just a normal number and is > > > > not special. But let's please not reuse 512..547 for other purposes > > > > on x86 variants -- that way lies even more confusion, IMO. > > > > > > Fair enough, the space for those numbers is cheap enough here. > > > I take it you mean we also should not reuse that number space if > > > we were to decide to remove x32 soon, but you are not worried > > > about clashing with arch/alpha when everything else uses consistent > > > numbers? > > > > > > > I think we have two issues if we reuse those numbers for new syscalls. > > First, I'd really like to see new syscalls be numbered consistently > > everywhere, or at least on all x86 variants, and we can't on x32 > > because they mean something else. Perhaps more importantly, due to > > what is arguably a rather severe bug, issuing a native x86_64 syscall > > (x32 bit clear) with nr in the range 512..547 does *not* return > > -ENOSYS on a kernel with x32 enabled. Instead it does something that > > is somewhat arbitrary. With my patch applied, it will return -ENOSYS, > > but old kernels will still exist, and this will break syscall probing. > > > > Can we perhaps just start the consistent numbers above 547 or maybe > > block out 512..547 in the new regime? > > I don't think you gain much with that kind of scheme - it won't take > very long before an architecture misses having a syscall added, and > then someone else adds their own. Been there with ARM - I was keeping > the syscall table in the same order as x86 for new syscalls, but now Same for m68k, and probably other architectures. > that others have been adding syscalls to the table since I converted > ARM to the tabular form, that's now gone out the window. > > So, I think it's completely pointless to do what you're suggesting. > We'll just end up with a big hole in the middle of the syscall table > and then revert back to random numbering of syscalls thereafter again. I believe the plan is to add future syscalls for all architectures in a single commit, to keep everything in sync. Regardless, I'm wondering what to do with the holes marked "room for arch specific calls". When is a syscall really arch-specific, and can it be added there, and when does it turn out (later) that it isn't, breaking the synchronization again? The pkey syscalls may be a bad example, as AFAIU they can be implemented on some architectures, but not on some others. Still, I had skipped them when adding new syscalls to m68k. Perhaps we should get rid of the notion of "arch-specific syscalls", and reserve a slot everywhere anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C17AC282F4 for ; Mon, 21 Jan 2019 08:19:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E44520855 for ; Mon, 21 Jan 2019 08:19:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Opp75V8r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E44520855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u1SFbafErbu853W1so+/UodjtHsaLd8E+4Hv2nmQPWA=; b=Opp75V8rGQjAf6 8mvVQZPros2DPoQgukgTr/EosVAlP6CwRWIT9t2PzW+XsBLGXe2+t9Wr5mNObYFQZJw/Lz9tnIM6m yHmUgt3GsEQisHd6a3aWhwmVaFPazN7W5rDAcKaKuiCswlPTe8QgFyyNrHnU7r2wnfD7JVOLiiaIO OpBw4eAjJ4eE6LgYxYMYDMiuxY3KlbHS4X0jdNKQ1G1vfUvEsUz3SiEjOaBtuHnkW/V1QHW9lxZup l53z/m5q2y4eJObccxKqdxRxYmTzncWH4J0MJEa9u5k0bsGMp65VLTD8BpoBArV5Jv6htInpKimbW 2QnHZ2QI6N787JSlBimQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glUoB-0007Ot-6H; Mon, 21 Jan 2019 08:19:51 +0000 Received: from mail-vs1-f66.google.com ([209.85.217.66]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glUnk-00078B-Vc for linux-arm-kernel@lists.infradead.org; Mon, 21 Jan 2019 08:19:46 +0000 Received: by mail-vs1-f66.google.com with SMTP id e7so12118494vsc.2 for ; Mon, 21 Jan 2019 00:19:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eNwdIYQYJT6Pc3PhNslPpG4rGotSgFNPjN+8uubEzLc=; b=tyKLxIpz+Ph2gAIA4CTk+dGRsLXEsH1rRWN3XYI9xgF94XrCSarIEl6qjNHZwSgA5A gIMd45BW+2C7YIX03jV7ulHRv0npDWx4hRpetCJlbO/nV+b4mi2z463NMYuT95mgg5OX OaISoVsyRnJXkT8uTnfbcb/dsFUPTlyfmwpFsMa2j1rcBNlqYiaEwPNNUh6aQaYbQGEt esb7bIs6Siwc6AYsZjeXKJZ50pRwMNf9pVgvji8Bw3cmobrWPjwPkwerEbHQcSwZ7BQX rujWvVGkhiLFdJ047jGYGAuQYyIVr2rjee2+6qMyAVD+6jcKnDX5ZHjFmHmCkIAOSyxE MOpw== X-Gm-Message-State: AJcUukdgXfJKifVGwRYYDTPR+7E55Ej1wto4+GWa1GlWclqhgl2fkgBc NZRwXWZDD/IVSUxU3cti79CvSYch0UaaNgPcxq8= X-Google-Smtp-Source: ALg8bN7Na9+3XJsTlxP4CnU3flevzSwRj2I8fvGc/mex1gzD8KE0G4LYkLwzBJ2YcDmVU42ivUABTg84S/YKw2y1uBc= X-Received: by 2002:a67:3885:: with SMTP id n5mr10324892vsi.96.1548058763095; Mon, 21 Jan 2019 00:19:23 -0800 (PST) MIME-Version: 1.0 References: <20190118161835.2259170-1-arnd@arndb.de> <20190118161835.2259170-30-arnd@arndb.de> <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> In-Reply-To: <20190119142852.cntdihah4mpa3lgx@e5254000004ec.dyn.armlinux.org.uk> From: Geert Uytterhoeven Date: Mon, 21 Jan 2019 09:19:11 +0100 Message-ID: Subject: Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures To: Russell King - ARM Linux admin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190121_001925_685452_5A1F7402 X-CRM114-Status: GOOD ( 30.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , "linux-ia64@vger.kernel.org" , Linux-sh list , Benjamin Herrenschmidt , Will Deacon , linux-mips@vger.kernel.org, Max Filippov , Network Development , Deepa Dinamani , "H. Peter Anvin" , sparclinux , linux-arch , linux-s390 , y2038 Mailman List , Michael Ellerman , Helge Deller , X86 ML , Ingo Molnar , Firoz Khan , Catalin Marinas , Matt Turner , Fenghua Yu , Arnd Bergmann , Heiko Carstens , Linux FS Devel , linux-m68k , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel , Michal Simek , Tony Luck , Parisc List , Linux API , LKML , Paul Burton , "Eric W. Biederman" , alpha , Martin Schwidefsky , Andrew Morton , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On Sat, Jan 19, 2019 at 3:29 PM Russell King - ARM Linux admin wrote: > On Fri, Jan 18, 2019 at 11:53:25AM -0800, Andy Lutomirski wrote: > > On Fri, Jan 18, 2019 at 11:33 AM Arnd Bergmann wrote: > > > On Fri, Jan 18, 2019 at 7:50 PM Andy Lutomirski wrote: > > > > On Fri, Jan 18, 2019 at 8:25 AM Arnd Bergmann wrote: > > > > > - Once we get to 512, we clash with the x32 numbers (unless > > > > > we remove x32 support first), and probably have to skip > > > > > a few more. I also considered using the 512..547 space > > > > > for 32-bit-only calls (which never clash with x32), but > > > > > that also seems to add a bit of complexity. > > > > > > > > I have a patch that I'll send soon to make x32 use its own table. As > > > > far as I'm concerned, 547 is *it*. 548 is just a normal number and is > > > > not special. But let's please not reuse 512..547 for other purposes > > > > on x86 variants -- that way lies even more confusion, IMO. > > > > > > Fair enough, the space for those numbers is cheap enough here. > > > I take it you mean we also should not reuse that number space if > > > we were to decide to remove x32 soon, but you are not worried > > > about clashing with arch/alpha when everything else uses consistent > > > numbers? > > > > > > > I think we have two issues if we reuse those numbers for new syscalls. > > First, I'd really like to see new syscalls be numbered consistently > > everywhere, or at least on all x86 variants, and we can't on x32 > > because they mean something else. Perhaps more importantly, due to > > what is arguably a rather severe bug, issuing a native x86_64 syscall > > (x32 bit clear) with nr in the range 512..547 does *not* return > > -ENOSYS on a kernel with x32 enabled. Instead it does something that > > is somewhat arbitrary. With my patch applied, it will return -ENOSYS, > > but old kernels will still exist, and this will break syscall probing. > > > > Can we perhaps just start the consistent numbers above 547 or maybe > > block out 512..547 in the new regime? > > I don't think you gain much with that kind of scheme - it won't take > very long before an architecture misses having a syscall added, and > then someone else adds their own. Been there with ARM - I was keeping > the syscall table in the same order as x86 for new syscalls, but now Same for m68k, and probably other architectures. > that others have been adding syscalls to the table since I converted > ARM to the tabular form, that's now gone out the window. > > So, I think it's completely pointless to do what you're suggesting. > We'll just end up with a big hole in the middle of the syscall table > and then revert back to random numbering of syscalls thereafter again. I believe the plan is to add future syscalls for all architectures in a single commit, to keep everything in sync. Regardless, I'm wondering what to do with the holes marked "room for arch specific calls". When is a syscall really arch-specific, and can it be added there, and when does it turn out (later) that it isn't, breaking the synchronization again? The pkey syscalls may be a bad example, as AFAIU they can be implemented on some architectures, but not on some others. Still, I had skipped them when adding new syscalls to m68k. Perhaps we should get rid of the notion of "arch-specific syscalls", and reserve a slot everywhere anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel