From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA7AC433F5 for ; Mon, 18 Oct 2021 00:43:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B338D60231 for ; Mon, 18 Oct 2021 00:43:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B338D60231 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35DFE6E8E9; Mon, 18 Oct 2021 00:43:51 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id C879C6E8E5 for ; Mon, 18 Oct 2021 00:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634517829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jclwnqz62MhBIz4LKz8fxKk0+KHtSrNn2dMhNTtgRqU=; b=YFtOvLWq+pObKUHfSSJKSCqWAUh4zpLT6N8W8PkcCh+oZ7WlRcXaPYysrGGjYndyZg/B3G AhwQbyimGOrU0cvpoOilzSKngy53azTjL9594LUguvk6eNXxzBq680lbIhdJSjjAEo3zX9 dbHe5dTu4RRHO9pUosSvVrK5Nf939D8= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-Qbr4yMBpPzmHDHDPPmYKWg-1; Sun, 17 Oct 2021 20:43:47 -0400 X-MC-Unique: Qbr4yMBpPzmHDHDPPmYKWg-1 Received: by mail-oo1-f69.google.com with SMTP id k3-20020a4a3103000000b002b733cd21e6so6003153ooa.19 for ; Sun, 17 Oct 2021 17:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Jclwnqz62MhBIz4LKz8fxKk0+KHtSrNn2dMhNTtgRqU=; b=KPvjSgVwZRzgl+UwB5QYB6rdGcNEcYG/WIxgrvhKW3qhzvla9ReFwU/Yklrq2ArK9r WuCZwUVkZTs2260jghLAvFShkoruqXrjsj03hVRvNWwlSOsZaqL1OCQ73PYM/lQnwlHd OkTFOaHnWbHzxd3tkiHgjgFIcIkZ/1VnQdX428bNIUEaHA6fyPc0302Vt6LhnbrA1b7f kxIvYj01HoQWbOvFmjcfix1KmGZdUZbbqAFSA6YY/OPbHmQ7F4dc8biUGMhS5TYVQaTZ Eu1+wNrmaNFqmWcPzvt0exKjxI9rKp0p2JyZy0GWmTaOkwaYHWFUyvGp70sPYZegpfUL Hd0g== X-Gm-Message-State: AOAM530KXCPU3aynDqzRLETFykDqCKdCYNbXTPY85U1nITDwEgqSsLlS Z26kioGFpcfZbuj5v1tjzS2HeM4wwshytiE2aAhxFWxfBBKQtUhGdQerYQVa7t85f1xx+PESmjB UVyOYMod5aBEb8z+LfCSnQNRBqcKC8MCAhOOksINYLJ2X X-Received: by 2002:a9d:189:: with SMTP id e9mr19295512ote.243.1634517826907; Sun, 17 Oct 2021 17:43:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzI+klkPzyd7vVJqFPpV52EioPoPBZ16qRWpef/jIqzcgYNgEZ/OpjQ2qg2NPI4Oc22qYpn0pqKfX6yI6cVAW4= X-Received: by 2002:a9d:189:: with SMTP id e9mr19295501ote.243.1634517826770; Sun, 17 Oct 2021 17:43:46 -0700 (PDT) MIME-Version: 1.0 References: <20211015071625.593-1-ville.syrjala@linux.intel.com> <20211015071625.593-9-ville.syrjala@linux.intel.com> In-Reply-To: <20211015071625.593-9-ville.syrjala@linux.intel.com> From: David Airlie Date: Mon, 18 Oct 2021 10:43:35 +1000 Message-ID: To: Ville Syrjala Cc: "Development, Intel" , Jani Nikula Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=airlied@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 8/9] drm/i915: Move intel_ddi_fdi_post_disable() to fdi code X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala wrote: > > From: Ville Syrj=C3=A4l=C3=A4 > > Reanme intel_ddi_fdi_post_disable() to hsw_fdi_disable() and > relocate it next to all the other code dealing with FDI_RX. > intel_ddi.c has now been cleansed of FDI_RX. > > In order to avoid exposing intel_disable_ddi_buf() outside > intel_ddi.c we can just open code the DDI_BUF_CTL write. The > enable side already has all that stuff open coded so > this actually is more symmetric. But we do need to remeber > to bring the intel_wait_ddi_buf_idle() call over from > inside intel_disable_ddi_buf(). > > Cc: Dave Airlie > Cc: Jani Nikula > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Dave Airlie