From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0D4C433FE for ; Fri, 4 Dec 2020 14:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D841222B2A for ; Fri, 4 Dec 2020 14:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728314AbgLDOP2 (ORCPT ); Fri, 4 Dec 2020 09:15:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgLDOP1 (ORCPT ); Fri, 4 Dec 2020 09:15:27 -0500 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48B91C061A52 for ; Fri, 4 Dec 2020 06:14:47 -0800 (PST) Received: by mail-qt1-x843.google.com with SMTP id b9so3978597qtr.2 for ; Fri, 04 Dec 2020 06:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S84fLM5R0eFjhFKwNgg6t4YhV/zLIcH5ndZplGJKCzk=; b=FP5hEdFsRSIYWxa3GBQxUIGiNfZW+RsNpvHY7m/q1DyyPbkND79VQBJWckEaVPjjZX sjVd87SJ9MmGox3RADjhpP0A/HOIdjZx5PlqGuF/leZGa8Bw/hx86RIAxlUTGGNwb27a +D1UO8CRuCEHwqrUcs06O+mIP/Kl1f80FHBxnrnHZSHst9PPcCCW59+3D2WWaRDpvh7q dZcTkLPX5qwzBiYsuGZ/FQZBVeSfSHPNXckqXqUBtVGXF1hLAeYjzKbam9vXszZKt3Mi WFbamiWmqxuepukArl5+g2yCh1igyXRSe/T9bOtldmrgSxp+/gqwTn231YA/o7PBoBCl 5cPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S84fLM5R0eFjhFKwNgg6t4YhV/zLIcH5ndZplGJKCzk=; b=dmwbRM9Hgp+Pnnx/5W+VoQOLBb2g/7pM+5qLBLXHrnenL3k1LpNK1xTntmSiwnC7KM j66QI+NOkCnn6tVUUKhQG18ryg4/mMXewRtDm7eT2EuvI8i1hd4N5AxtiCumHZFgCkNu Xnb3Zzefsj3uHk/W9rVPm1Mv1q8h8N2zVSxy+PD1S7/pE54pznkzZ38k5grAWG8qGI3J 5DVuqhEOjyt1iJlyy3U/e6rbePZ05UCWtXgDkPOhWXCPlPAmlHOUWxDEOhzKKYF88aSR HNTAst6kujA3a732hOZOHCJjHtPLLbpyIv01oyFiKQ0jA0pWAMRgkiuABBZuKENEc6eD yRHQ== X-Gm-Message-State: AOAM5318oIcRFF10vf4NylEVOSIVmbEdx88CiIG7n1EM0ngRCUymWupi SfNfyV6Qbc+PkUdmAlUBHcTHVz6lP+D7sqiZSggRkQ== X-Google-Smtp-Source: ABdhPJwdyeC4GEux7iJupu+IbCVt8JIddUtBx9AF0hehts+m24vl3ICE698dbMxZN1MoyOrNL7phD3GbsGer4ueulyg= X-Received: by 2002:ac8:6b9a:: with SMTP id z26mr9626192qts.200.1607091286490; Fri, 04 Dec 2020 06:14:46 -0800 (PST) MIME-Version: 1.0 References: <20201119140850.12268-1-grzegorz.jaszczyk@linaro.org> <20201119140850.12268-7-grzegorz.jaszczyk@linaro.org> <20201203185332.GC1392978@xps15> In-Reply-To: <20201203185332.GC1392978@xps15> From: Grzegorz Jaszczyk Date: Fri, 4 Dec 2020 15:14:35 +0100 Message-ID: Subject: Re: [PATCH v2 6/6] remoteproc/pru: Add support for various PRU cores on K3 J721E SoCs To: Mathieu Poirier Cc: Ohad Ben Cohen , Bjorn Andersson , "Anna, Suman" , linux-remoteproc@vger.kernel.org, Rob Herring , Lee Jones , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Bajjuri, Praneeth" , Roger Quadros Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Mathieu, On Thu, 3 Dec 2020 at 19:53, Mathieu Poirier wrote: > > On Thu, Nov 19, 2020 at 03:08:50PM +0100, Grzegorz Jaszczyk wrote: > > From: Suman Anna > > > > The K3 J721E family of SoCs have a revised version of the AM65x ICSSG IP > > and contains two instances of this newer ICSSG IP. Each ICSSG processor > > subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called RTUs, > > and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs). > > > > Enhance the existing PRU remoteproc driver to support these new PRU > > and RTU cores by using specific compatibles. The cores have the same > > memory copying limitations as on AM65x, so reuses the custom memcpy > > function within the driver's ELF loader implementation. The initial > > names for the firmware images for each PRU core are retrieved from > > DT nodes, and can be adjusted through sysfs if required. > > > > Signed-off-by: Suman Anna > > Co-developed-by: Grzegorz Jaszczyk > > Signed-off-by: Grzegorz Jaszczyk > > Reviewed-by: Mathieu Poirier Thank you for all your review, Grzegorz > > > --- > > drivers/remoteproc/pru_rproc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > > index 48c1c51e0d42..96f689283a8b 100644 > > --- a/drivers/remoteproc/pru_rproc.c > > +++ b/drivers/remoteproc/pru_rproc.c > > @@ -852,6 +852,9 @@ static const struct of_device_id pru_rproc_match[] = { > > { .compatible = "ti,am654-pru", .data = &k3_pru_data }, > > { .compatible = "ti,am654-rtu", .data = &k3_rtu_data }, > > { .compatible = "ti,am654-tx-pru", .data = &k3_tx_pru_data }, > > + { .compatible = "ti,j721e-pru", .data = &k3_pru_data }, > > + { .compatible = "ti,j721e-rtu", .data = &k3_rtu_data }, > > + { .compatible = "ti,j721e-tx-pru", .data = &k3_tx_pru_data }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, pru_rproc_match); > > -- > > 2.29.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36FB4C433FE for ; Fri, 4 Dec 2020 14:16:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4D5322B2A for ; Fri, 4 Dec 2020 14:16:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4D5322B2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iedLrulfYTyc+xf02MLbzZbsHTHYeFdPWrHbeXpFZ04=; b=053HwJMhobw1aJCXBPuP76xxB /548buYA6+jEH3mN7C4ESchJbRxcp6l+8VYGW5aeFZUI6jWAD3TJ+BM+qlHziLYrHXwiVrc/c2YC+ k1WIvUoHCKyzQvm9W4X0fcJRTOirpiTBzRFYWUSNWzlPOksyMQ9pEVVWJFG4HMecNXlT2A8Qv6CWT et9X4KhxFEbUC4AKF0NpG2jVzPD38X9ZMONxbFsizrP1WbOyGrEoKPkMJKXcZjlfXGYQ/hHJjE+dV DDxx/cG1FaS3JKQF97Dr0eZRPN8OZsjr+uPICLXVhW3kaSoKfDtfO5M2oBn3DN3gjr12Gk9WFXLtd rZP0BC7Kg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klBrL-00031x-UL; Fri, 04 Dec 2020 14:14:56 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klBrE-0002zj-3w for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 14:14:48 +0000 Received: by mail-qt1-x843.google.com with SMTP id p12so3958319qtp.7 for ; Fri, 04 Dec 2020 06:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S84fLM5R0eFjhFKwNgg6t4YhV/zLIcH5ndZplGJKCzk=; b=FP5hEdFsRSIYWxa3GBQxUIGiNfZW+RsNpvHY7m/q1DyyPbkND79VQBJWckEaVPjjZX sjVd87SJ9MmGox3RADjhpP0A/HOIdjZx5PlqGuF/leZGa8Bw/hx86RIAxlUTGGNwb27a +D1UO8CRuCEHwqrUcs06O+mIP/Kl1f80FHBxnrnHZSHst9PPcCCW59+3D2WWaRDpvh7q dZcTkLPX5qwzBiYsuGZ/FQZBVeSfSHPNXckqXqUBtVGXF1hLAeYjzKbam9vXszZKt3Mi WFbamiWmqxuepukArl5+g2yCh1igyXRSe/T9bOtldmrgSxp+/gqwTn231YA/o7PBoBCl 5cPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S84fLM5R0eFjhFKwNgg6t4YhV/zLIcH5ndZplGJKCzk=; b=bISc/A/LtPrj3oNh1T7rHUFnhNqTE14Av5qWAVTkspvDshwKAJ1HTVZ7NKXRFfR0XF UyIvw33KaW9RLzVS05KImCRaUmQldUw7+Fz1IXz7KEiVRlK7u1y8YRnYQVXEoMMqJOvX PHc8IrPG9c//uwuE3SceHLtmgMSiPOl2evx7uVPnUJ55DUIpPpjNsIcKOn74gAuN/DLL y+l8PcV/Ltp0cla6PoOtRpsVF+Te8Oo/EIqZ9cRw/eqeAU5EpOz6tlE0TVPZM9OJm/KW JZBv5qgp5Kn28GhoJGOJy3y7PKFsuYUhrxHb2uv/L+c34oIFiYQ7xvr+AopTyK398m9I Z0Cw== X-Gm-Message-State: AOAM532c40MOQk960X4CGDnPj6jfJb3pPSgSw8xQhp5k6aq4D4Te7ega F+TwERLJe4RRlMGuU7SZ9NXLUuepsQSrspiF/p6afw== X-Google-Smtp-Source: ABdhPJwdyeC4GEux7iJupu+IbCVt8JIddUtBx9AF0hehts+m24vl3ICE698dbMxZN1MoyOrNL7phD3GbsGer4ueulyg= X-Received: by 2002:ac8:6b9a:: with SMTP id z26mr9626192qts.200.1607091286490; Fri, 04 Dec 2020 06:14:46 -0800 (PST) MIME-Version: 1.0 References: <20201119140850.12268-1-grzegorz.jaszczyk@linaro.org> <20201119140850.12268-7-grzegorz.jaszczyk@linaro.org> <20201203185332.GC1392978@xps15> In-Reply-To: <20201203185332.GC1392978@xps15> From: Grzegorz Jaszczyk Date: Fri, 4 Dec 2020 15:14:35 +0100 Message-ID: Subject: Re: [PATCH v2 6/6] remoteproc/pru: Add support for various PRU cores on K3 J721E SoCs To: Mathieu Poirier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_091448_193607_C66F80B7 X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben Cohen , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, "Bajjuri, Praneeth" , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Thu, 3 Dec 2020 at 19:53, Mathieu Poirier wrote: > > On Thu, Nov 19, 2020 at 03:08:50PM +0100, Grzegorz Jaszczyk wrote: > > From: Suman Anna > > > > The K3 J721E family of SoCs have a revised version of the AM65x ICSSG IP > > and contains two instances of this newer ICSSG IP. Each ICSSG processor > > subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called RTUs, > > and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs). > > > > Enhance the existing PRU remoteproc driver to support these new PRU > > and RTU cores by using specific compatibles. The cores have the same > > memory copying limitations as on AM65x, so reuses the custom memcpy > > function within the driver's ELF loader implementation. The initial > > names for the firmware images for each PRU core are retrieved from > > DT nodes, and can be adjusted through sysfs if required. > > > > Signed-off-by: Suman Anna > > Co-developed-by: Grzegorz Jaszczyk > > Signed-off-by: Grzegorz Jaszczyk > > Reviewed-by: Mathieu Poirier Thank you for all your review, Grzegorz > > > --- > > drivers/remoteproc/pru_rproc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > > index 48c1c51e0d42..96f689283a8b 100644 > > --- a/drivers/remoteproc/pru_rproc.c > > +++ b/drivers/remoteproc/pru_rproc.c > > @@ -852,6 +852,9 @@ static const struct of_device_id pru_rproc_match[] = { > > { .compatible = "ti,am654-pru", .data = &k3_pru_data }, > > { .compatible = "ti,am654-rtu", .data = &k3_rtu_data }, > > { .compatible = "ti,am654-tx-pru", .data = &k3_tx_pru_data }, > > + { .compatible = "ti,j721e-pru", .data = &k3_pru_data }, > > + { .compatible = "ti,j721e-rtu", .data = &k3_rtu_data }, > > + { .compatible = "ti,j721e-tx-pru", .data = &k3_tx_pru_data }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, pru_rproc_match); > > -- > > 2.29.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel