From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D51C63798 for ; Wed, 18 Nov 2020 15:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E63ED24754 for ; Wed, 18 Nov 2020 15:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h4TN/jcV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbgKRPXC (ORCPT ); Wed, 18 Nov 2020 10:23:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbgKRPXB (ORCPT ); Wed, 18 Nov 2020 10:23:01 -0500 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB919C061A48 for ; Wed, 18 Nov 2020 07:22:59 -0800 (PST) Received: by mail-qk1-x741.google.com with SMTP id v143so2130823qkb.2 for ; Wed, 18 Nov 2020 07:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GH9Xy8QAdPbukrPXbHMdGuCbNQSmg+d15O0OpK6oPDU=; b=h4TN/jcVvOVqit9i6UFM5UXHAzRVbr+06IwvK4j7baLs601eobWK3ybyjMbrdbYMQf AX+dAZ5qI7pfTTmC76wPgeNmBYoV0CpRZPjq6g6BDLCqtd5hmPnj9GmE/eC6cJsPtzQd boy6lKrCejDjUqOQZ7WP2Z8uUA39a6truy8ZAUhgs7UZ/0AKHFOlXW6wob7FLYNDMOUX zPo7e2O2xtt5vpuJpzyyyiAupzr/DoFUwnX2mLnmRelrTmPDbGddIgS1dZhEMoi0ZZCu FbKO7mTedcHBsOBYDH9tJnDdUkaCnmGWJb5ZQAyE6bUd835SdC2n+q0S+ZmGiZKpEsGx nbxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GH9Xy8QAdPbukrPXbHMdGuCbNQSmg+d15O0OpK6oPDU=; b=dcFNHvGDxOGGGuxw0SHqQWAZQxtU5lhqN+LaglXmHfLYWiGleO3MWm/1FygAj1MMWw HrVP+YB9x4wAPO3hSHylMcS2Z5Y7r15DgQ0Cj9SF0Z+tG6dAfPsO7k5HMJrMugWXuzB5 DAOvxoPZ1z4xvTcm6uIAzBgXwtFDviS98+3CTtE4L5DSlOXiHzZKrzIUxXoxiLYGWuwj 9E2beRdDgNM2eC5skTo8b2UhMVRqyhTThasnJIYa7RU+zW6Vh1O4q7aszXmSCQRVaebG FyUGm5BEI7yA1UgvSf3V985/Xl8wAyo8GguOsEfIo5wyzYj+EJ10ZeIUc2z1mBHWewN6 cX5w== X-Gm-Message-State: AOAM530h/2n4X9PAUAviKCC8btY95tmYDErTF4gCtM9BhTC6nyk3g6wV ZX9a25Dd+9lMT5DmIRgLPrEF2C+p94Rt4hZmx5wrpw== X-Google-Smtp-Source: ABdhPJwIC91BDC5Utr8V4WPjI/sBwnHGPwlWEDaBk3pFF3i5hnFhC9cwQPrgbPvO3III8iQXHYaNfWzNGZJQ4M2yTVc= X-Received: by 2002:a37:2782:: with SMTP id n124mr5438013qkn.498.1605712979009; Wed, 18 Nov 2020 07:22:59 -0800 (PST) MIME-Version: 1.0 References: <20201114084613.13503-1-grzegorz.jaszczyk@linaro.org> <20201114084613.13503-2-grzegorz.jaszczyk@linaro.org> <20201116152804.GA1679588@bogus> In-Reply-To: <20201116152804.GA1679588@bogus> From: Grzegorz Jaszczyk Date: Wed, 18 Nov 2020 16:22:47 +0100 Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: remoteproc: Add binding doc for PRU cores in the PRU-ICSS To: Rob Herring Cc: linux-omap@vger.kernel.org, Ohad Ben Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , "Bajjuri, Praneeth" , "Anna, Suman" , Bjorn Andersson , Mathieu Poirier , Rob Herring , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Rob On Mon, 16 Nov 2020 at 16:28, Rob Herring wrote: > > On Sat, 14 Nov 2020 09:46:08 +0100, Grzegorz Jaszczyk wrote: > > From: Suman Anna > > > > The Programmable Real-Time Unit and Industrial Communication Subsystem > > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > > > The K3 AM65x amd J721E SoCs have the next generation of the PRU-ICSS IP, > > commonly called ICSSG. The ICSSG IP on AM65x SoCs has two PRU cores, > > two auxiliary custom PRU cores called Real Time Units (RTUs). The K3 > > AM65x SR2.0 and J721E SoCs have a revised version of the ICSSG IP, and > > include two additional custom auxiliary PRU cores called Transmit PRUs > > (Tx_PRUs). > > > > This patch adds the bindings for these PRU cores. The binding covers the > > OMAP architecture SoCs - AM33xx, AM437x and AM57xx; Keystone 2 architecture > > based 66AK2G SoC; and the K3 architecture based SoCs - AM65x and J721E. The > > Davinci based OMAPL138 SoCs will be covered in a future patch. > > > > Co-developed-by: Roger Quadros > > Signed-off-by: Roger Quadros > > Signed-off-by: Suman Anna > > Signed-off-by: Grzegorz Jaszczyk > > --- > > .../bindings/remoteproc/ti,pru-rproc.yaml | 214 ++++++++++++++++++ > > 1 file changed, 214 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml:37:6: [warning] wrong indentation: expected 6 but found 5 (indentation) > ./Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml:92:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: > > > See https://patchwork.ozlabs.org/patch/1400241 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Sorry for that - I've run dt_binding_check which completes without any warnings/errors but I didn't had yamllint installed. I will fix mentioned warnings for v2. Best regards, Grzegorz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF84EC5519F for ; Wed, 18 Nov 2020 15:23:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2950F24746 for ; Wed, 18 Nov 2020 15:23:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fraoc/2u"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h4TN/jcV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2950F24746 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NVdo0VYAyiTypJcrjakIiYxhi1BpxHz1oQ1B3KZXTw8=; b=Fraoc/2uNhy8NKhkac6ZUbsTa rYikEzy6RFok60e9+NHe8TuirywxDgIHwnfq3SiaPk24kgcqib9cWl+geoo5VdkYcEk/PAr194dHH Gq+sDsy0zk0rcKhvYDip1CMS13URfwHh4hbZ853J7B0xJvMfD3VC6a7b0IakCQ6hzvRPElJvHoJK9 L9fNsbkya7jKDX1V5Zg6u41S3EUMBrq7cnFpvJGkPattoo8xUsGHtyoCNl7INvqDgtiEeh3o1+q59 B8TxJgZO8zEG5mNP6jTxR5m55sZy3FXSyivyJ5lGjOPkgi+US/+sYiQ8qdWtyNeuW0eTH5Ticeypf Bl9lMQ9fw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfPIW-0002sl-4b; Wed, 18 Nov 2020 15:23:04 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfPIU-0002sM-E2 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 15:23:03 +0000 Received: by mail-qk1-x742.google.com with SMTP id d28so2064600qka.11 for ; Wed, 18 Nov 2020 07:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GH9Xy8QAdPbukrPXbHMdGuCbNQSmg+d15O0OpK6oPDU=; b=h4TN/jcVvOVqit9i6UFM5UXHAzRVbr+06IwvK4j7baLs601eobWK3ybyjMbrdbYMQf AX+dAZ5qI7pfTTmC76wPgeNmBYoV0CpRZPjq6g6BDLCqtd5hmPnj9GmE/eC6cJsPtzQd boy6lKrCejDjUqOQZ7WP2Z8uUA39a6truy8ZAUhgs7UZ/0AKHFOlXW6wob7FLYNDMOUX zPo7e2O2xtt5vpuJpzyyyiAupzr/DoFUwnX2mLnmRelrTmPDbGddIgS1dZhEMoi0ZZCu FbKO7mTedcHBsOBYDH9tJnDdUkaCnmGWJb5ZQAyE6bUd835SdC2n+q0S+ZmGiZKpEsGx nbxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GH9Xy8QAdPbukrPXbHMdGuCbNQSmg+d15O0OpK6oPDU=; b=daglZtYj0qHTBuBqiVMK90nJpqTz8T4yk8yW2KuH5f1OHd4OAETTbiqQxWukFX2c5W Dz0ypBSZspGjbndSzcbJzX63ja4Nii7pLGmkqmnyXPw2RZgHeejnBp+Ul6QO6mR50sVo ZT8fceCyrlPQqAp7togZ5RuO9hFpgVKxmOV8kAKyLZk3CG6p5F6AF9Oc0A65QF2ym0x6 DzxvZ/RLhtD+HPo8CI9gtx1ftEeaHCv2kTJTNXevMJZFWsy3R/WIQq8O5hpXz3sBBnSO ZrqN1YOZND6xXcRGSQEbbyLznjnri8Mq+i4GA6vFRGQq3mRFPsBajD7LJLeZN9pvV/Z8 VzPQ== X-Gm-Message-State: AOAM532fv/auVFr8ZHke4kIPROJm3/QKMEGvm8kuOSaCmWXGFoGTQuyI tLGmLaBnkKUseOyfATfR7EAq60C2K7Yy5fc4uw3Opg== X-Google-Smtp-Source: ABdhPJwIC91BDC5Utr8V4WPjI/sBwnHGPwlWEDaBk3pFF3i5hnFhC9cwQPrgbPvO3III8iQXHYaNfWzNGZJQ4M2yTVc= X-Received: by 2002:a37:2782:: with SMTP id n124mr5438013qkn.498.1605712979009; Wed, 18 Nov 2020 07:22:59 -0800 (PST) MIME-Version: 1.0 References: <20201114084613.13503-1-grzegorz.jaszczyk@linaro.org> <20201114084613.13503-2-grzegorz.jaszczyk@linaro.org> <20201116152804.GA1679588@bogus> In-Reply-To: <20201116152804.GA1679588@bogus> From: Grzegorz Jaszczyk Date: Wed, 18 Nov 2020 16:22:47 +0100 Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: remoteproc: Add binding doc for PRU cores in the PRU-ICSS To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_102302_489779_6B26EF62 X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben Cohen , devicetree@vger.kernel.org, Mathieu Poirier , "Bajjuri, Praneeth" , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Rob Herring , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob On Mon, 16 Nov 2020 at 16:28, Rob Herring wrote: > > On Sat, 14 Nov 2020 09:46:08 +0100, Grzegorz Jaszczyk wrote: > > From: Suman Anna > > > > The Programmable Real-Time Unit and Industrial Communication Subsystem > > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > > > The K3 AM65x amd J721E SoCs have the next generation of the PRU-ICSS IP, > > commonly called ICSSG. The ICSSG IP on AM65x SoCs has two PRU cores, > > two auxiliary custom PRU cores called Real Time Units (RTUs). The K3 > > AM65x SR2.0 and J721E SoCs have a revised version of the ICSSG IP, and > > include two additional custom auxiliary PRU cores called Transmit PRUs > > (Tx_PRUs). > > > > This patch adds the bindings for these PRU cores. The binding covers the > > OMAP architecture SoCs - AM33xx, AM437x and AM57xx; Keystone 2 architecture > > based 66AK2G SoC; and the K3 architecture based SoCs - AM65x and J721E. The > > Davinci based OMAPL138 SoCs will be covered in a future patch. > > > > Co-developed-by: Roger Quadros > > Signed-off-by: Roger Quadros > > Signed-off-by: Suman Anna > > Signed-off-by: Grzegorz Jaszczyk > > --- > > .../bindings/remoteproc/ti,pru-rproc.yaml | 214 ++++++++++++++++++ > > 1 file changed, 214 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml:37:6: [warning] wrong indentation: expected 6 but found 5 (indentation) > ./Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml:92:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: > > > See https://patchwork.ozlabs.org/patch/1400241 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Sorry for that - I've run dt_binding_check which completes without any warnings/errors but I didn't had yamllint installed. I will fix mentioned warnings for v2. Best regards, Grzegorz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel