From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8653C4361A for ; Fri, 4 Dec 2020 15:12:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B0E222B3B for ; Fri, 4 Dec 2020 15:12:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730289AbgLDPMN (ORCPT ); Fri, 4 Dec 2020 10:12:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgLDPMN (ORCPT ); Fri, 4 Dec 2020 10:12:13 -0500 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAC8C061A4F for ; Fri, 4 Dec 2020 07:11:32 -0800 (PST) Received: by mail-qt1-x843.google.com with SMTP id o1so4109268qtp.5 for ; Fri, 04 Dec 2020 07:11:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTZE5KYHYdCtlR64X4cdwkLGSERgZtg1bRZFdAZq1Jo=; b=oo3ypHsXZFXMgirMzks9ExPqQMPDJAFZS9OrDgQfyEK6g02cm8ZZBSC6uXO9ABvjsF D7RmT6gvfSXp0rwl4EsPfLix2qnmrSDmgGPUM5oIu3ii7NgDH+G0vdvo6dhYWpAi6o/o AVf0wneYfo/YQZoxUKRrPCQZm+ub/pUh2Ns5GRMW26EgDPETzbOoOV0AR+9gaKBU2ZKP eeluI5XnEQ72v4drP+BWPooR7N2v0T1phoETXPVLXKl2uamKh1It2irIhZU+vRWoh6BI TvIHbKms6AJmoiIVvM0m6wMB0vMdDi0QsdNygHWxFrm5MDgIzmryNkccH+XJc5hHWj9w kY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTZE5KYHYdCtlR64X4cdwkLGSERgZtg1bRZFdAZq1Jo=; b=dzFdYINHSkcYkVuGVvFiKrM90iTdXrK3PuF1cQdHuNYgXsr80xBxA4Bh+XK6B3tnB8 U+UjeiqW5IstgUaMDOI1b/EVrgyuPI+7l/OcOCtobjiR+gTuftjZwOwlS1kq+IL/arRl RcjHX+KWIyvXcbEJiCMs99vfwLc1R2H6/PTuvm2xcKA4ua68LruG0o17h2jQIYw3Pbsr D29PNFWB4b4D3hw+2PN6Ftdrr7UJWwxdHMLcPgHf7NzPGSzWUsl39JfvNzMPHnMdfaK9 sJizWdMv3HpuWFfVKDzjF8UynHHxlrZFAC4ecDifwNOJCPKG61ocvtdcXsvSfTcJI2zc N2oQ== X-Gm-Message-State: AOAM532vjdo98dOcbAxybpeU9Oq5g9jcc1I1pIdq5uU9qhVt1aUS4T+t wHkGnpNB5BSF90fb6wH8KH1o63TIEzf68xiCrZkBh12VPtn2lQ== X-Google-Smtp-Source: ABdhPJym3Hu5283k/Rt6jj2+IHVjFg5AONLLc7sr3X25XFBImmQ13ymUKuacYVhjXLBcoiQQtWhr1VODUnAxILBkFps= X-Received: by 2002:aed:3c42:: with SMTP id u2mr9224643qte.159.1607094692010; Fri, 04 Dec 2020 07:11:32 -0800 (PST) MIME-Version: 1.0 References: <20201119140850.12268-1-grzegorz.jaszczyk@linaro.org> In-Reply-To: From: Grzegorz Jaszczyk Date: Fri, 4 Dec 2020 16:11:20 +0100 Message-ID: Subject: Re: [PATCH v2 0/6] Add a PRU remoteproc driver To: Suman Anna Cc: Ohad Ben Cohen , Bjorn Andersson , Mathieu Poirier , linux-remoteproc@vger.kernel.org, Rob Herring , Lee Jones , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Bajjuri, Praneeth" , Roger Quadros Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Suman, On Fri, 4 Dec 2020 at 16:05, Suman Anna wrote: > > Hi Greg, > > On 11/19/20 8:08 AM, Grzegorz Jaszczyk wrote: > > Hi All, > > > > The Programmable Real-Time Unit and Industrial Communication Subsystem > > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > > > The K3 AM65x amd J721E SoCs have the next generation of the PRU-ICSS IP, > > commonly called ICSSG. The ICSSG IP on AM65x SoCs has two PRU cores, > > two auxiliary custom PRU cores called Real Time Units (RTUs). The K3 > > AM65x SR2.0 and J721E SoCs have a revised version of the ICSSG IP, and > > include two additional custom auxiliary PRU cores called Transmit PRUs > > (Tx_PRUs). > > > > This series contains the PRUSS remoteproc driver together with relevant > > dt-binding. This is the 3rd foundation component for PRUSS subsystem, the > > previous two were already merged and can be found under: > > 1) drivers/soc/ti/pruss.c > > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > > 2) drivers/irqchip/irq-pruss-intc.c > > Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml > > > > The following is a v2 version of the series. Please see the individual patches > > for exact changes in each patch, following are the main changes from v1: > > - Patch #1: fix two yamllint warnings. > > - Patch #2: address Suman comments: minor style improvements and fix for > > optional resource table handling (moved from patch #3). > > - Patch #3: address Suman comment: minor style, comments and trace improvements > > (no functional changes). > > - Patch #4: No changes. > > - Patch #5: Update documentation of pru_rproc_memcpy() function and is_k3 flag. > > - Patch #6: No changes. > > > > Best regards, > > Grzegorz > > > > Grzegorz Jaszczyk (1): > > remoteproc/pru: Add support for PRU specific interrupt configuration > > > > Suman Anna (5): > > dt-bindings: remoteproc: Add binding doc for PRU cores in the PRU-ICSS > > remoteproc/pru: Add a PRU remoteproc driver > > remoteproc/pru: Add pru-specific debugfs support > > remoteproc/pru: Add support for various PRU cores on K3 AM65x SoCs > > remoteproc/pru: Add support for various PRU cores on K3 J721E SoCs > > One minor change for v3 when you repost to address Mathieu's comments, can you > please adjust the patch titles to use > "remoteproc: pru:" instead following the latest convention. Sure - I will do that. Thank you, Grzegorz > > Thanks, > Suman > > > > > .../bindings/remoteproc/ti,pru-rproc.yaml | 214 +++++ > > drivers/remoteproc/Kconfig | 12 + > > drivers/remoteproc/Makefile | 1 + > > drivers/remoteproc/pru_rproc.c | 877 ++++++++++++++++++ > > drivers/remoteproc/pru_rproc.h | 46 + > > 5 files changed, 1150 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > create mode 100644 drivers/remoteproc/pru_rproc.c > > create mode 100644 drivers/remoteproc/pru_rproc.h > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F47C433FE for ; Fri, 4 Dec 2020 15:13:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8089622B3B for ; Fri, 4 Dec 2020 15:13:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8089622B3B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TU86yd0XYe8A9NPMDyZkYGjRyiEqAapkHOkDmahIeow=; b=cxfkPDhZ/Kv4ZLWiowBSmGoZv dY7jSC7x2zvZ+2/55PeCZAasZb1AUd/n/LXpoueoB+VT+QMjkje+0HyyEvqDASyktDsKbte7ItEnn /VHNnEJHyA6Q/hlz59A4TO/W+IbnDtKGH2FSr3yRfrxiI7CpIHbpHQKNm18faxNjtj8YSq9kAREeo ZhCqR1AJ9yu3PzzdUl44CsNzAoMjVSdfbZRT86DYxvU24p/pvShc5VAqmxMfhaCCh+zfTi5ceP9UJ M05vuLnhodBl0tbXqDdIV7RZnfHOIWWbE+vpyt3PnT4rnnr4DuExdItb4HMmkM4USGbkcSFKupKjT lKKNPPpUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klCkD-0003Mq-5H; Fri, 04 Dec 2020 15:11:37 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klCk9-0003Lw-LO for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 15:11:34 +0000 Received: by mail-qt1-x841.google.com with SMTP id d5so4125963qtn.0 for ; Fri, 04 Dec 2020 07:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTZE5KYHYdCtlR64X4cdwkLGSERgZtg1bRZFdAZq1Jo=; b=oo3ypHsXZFXMgirMzks9ExPqQMPDJAFZS9OrDgQfyEK6g02cm8ZZBSC6uXO9ABvjsF D7RmT6gvfSXp0rwl4EsPfLix2qnmrSDmgGPUM5oIu3ii7NgDH+G0vdvo6dhYWpAi6o/o AVf0wneYfo/YQZoxUKRrPCQZm+ub/pUh2Ns5GRMW26EgDPETzbOoOV0AR+9gaKBU2ZKP eeluI5XnEQ72v4drP+BWPooR7N2v0T1phoETXPVLXKl2uamKh1It2irIhZU+vRWoh6BI TvIHbKms6AJmoiIVvM0m6wMB0vMdDi0QsdNygHWxFrm5MDgIzmryNkccH+XJc5hHWj9w kY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTZE5KYHYdCtlR64X4cdwkLGSERgZtg1bRZFdAZq1Jo=; b=BpBZJ4Jx8Xs8G6lQ25MZEQJbWHxcjFOnOC7+dTph1DX8sEBU0Vcfnb0TyTa8v0fvbP wujR2/da1lDf/L7aqDJaVLpMBOQdMAUTP+oZcDi4yEYPTewILH3SwhzV49i1a1nOZAn8 xMPqZ4QzPkbUyHneOhKznz8xfu+WdT0o1Rnty3PLWuIPVUcXXdUPg3LI4na/gAsjmytk eH6Z4ufIlJCfG/SbGIKGpWJ3i4Q3PYWt0NxFsrkb6Eks34Fqu3oveYkoDgoYuSOiRD9R v0MFSEga8+W/2I3yl0W97GHTQViVucxKv4DCrtS/L5YgUJZKvoYL2KQ0vXuIgaPwlCqR S4iw== X-Gm-Message-State: AOAM530bExQcBpitWtiwcC3VcMb8kcv25z8Jdk9Youc0oxpq3nSljR12 aN3PhMD0XU9j3Mh5T4jMc59Ii+MHe+Pw7UzNI+5Upw== X-Google-Smtp-Source: ABdhPJym3Hu5283k/Rt6jj2+IHVjFg5AONLLc7sr3X25XFBImmQ13ymUKuacYVhjXLBcoiQQtWhr1VODUnAxILBkFps= X-Received: by 2002:aed:3c42:: with SMTP id u2mr9224643qte.159.1607094692010; Fri, 04 Dec 2020 07:11:32 -0800 (PST) MIME-Version: 1.0 References: <20201119140850.12268-1-grzegorz.jaszczyk@linaro.org> In-Reply-To: From: Grzegorz Jaszczyk Date: Fri, 4 Dec 2020 16:11:20 +0100 Message-ID: Subject: Re: [PATCH v2 0/6] Add a PRU remoteproc driver To: Suman Anna X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_101134_007297_DEFB63CF X-CRM114-Status: GOOD ( 25.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben Cohen , devicetree@vger.kernel.org, Mathieu Poirier , "Bajjuri, Praneeth" , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Rob Herring , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suman, On Fri, 4 Dec 2020 at 16:05, Suman Anna wrote: > > Hi Greg, > > On 11/19/20 8:08 AM, Grzegorz Jaszczyk wrote: > > Hi All, > > > > The Programmable Real-Time Unit and Industrial Communication Subsystem > > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > > > The K3 AM65x amd J721E SoCs have the next generation of the PRU-ICSS IP, > > commonly called ICSSG. The ICSSG IP on AM65x SoCs has two PRU cores, > > two auxiliary custom PRU cores called Real Time Units (RTUs). The K3 > > AM65x SR2.0 and J721E SoCs have a revised version of the ICSSG IP, and > > include two additional custom auxiliary PRU cores called Transmit PRUs > > (Tx_PRUs). > > > > This series contains the PRUSS remoteproc driver together with relevant > > dt-binding. This is the 3rd foundation component for PRUSS subsystem, the > > previous two were already merged and can be found under: > > 1) drivers/soc/ti/pruss.c > > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > > 2) drivers/irqchip/irq-pruss-intc.c > > Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml > > > > The following is a v2 version of the series. Please see the individual patches > > for exact changes in each patch, following are the main changes from v1: > > - Patch #1: fix two yamllint warnings. > > - Patch #2: address Suman comments: minor style improvements and fix for > > optional resource table handling (moved from patch #3). > > - Patch #3: address Suman comment: minor style, comments and trace improvements > > (no functional changes). > > - Patch #4: No changes. > > - Patch #5: Update documentation of pru_rproc_memcpy() function and is_k3 flag. > > - Patch #6: No changes. > > > > Best regards, > > Grzegorz > > > > Grzegorz Jaszczyk (1): > > remoteproc/pru: Add support for PRU specific interrupt configuration > > > > Suman Anna (5): > > dt-bindings: remoteproc: Add binding doc for PRU cores in the PRU-ICSS > > remoteproc/pru: Add a PRU remoteproc driver > > remoteproc/pru: Add pru-specific debugfs support > > remoteproc/pru: Add support for various PRU cores on K3 AM65x SoCs > > remoteproc/pru: Add support for various PRU cores on K3 J721E SoCs > > One minor change for v3 when you repost to address Mathieu's comments, can you > please adjust the patch titles to use > "remoteproc: pru:" instead following the latest convention. Sure - I will do that. Thank you, Grzegorz > > Thanks, > Suman > > > > > .../bindings/remoteproc/ti,pru-rproc.yaml | 214 +++++ > > drivers/remoteproc/Kconfig | 12 + > > drivers/remoteproc/Makefile | 1 + > > drivers/remoteproc/pru_rproc.c | 877 ++++++++++++++++++ > > drivers/remoteproc/pru_rproc.h | 46 + > > 5 files changed, 1150 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > create mode 100644 drivers/remoteproc/pru_rproc.c > > create mode 100644 drivers/remoteproc/pru_rproc.h > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel