From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758189AbaKUL3Z (ORCPT ); Fri, 21 Nov 2014 06:29:25 -0500 Received: from mail-ie0-f175.google.com ([209.85.223.175]:42769 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbaKUL3Y (ORCPT ); Fri, 21 Nov 2014 06:29:24 -0500 MIME-Version: 1.0 In-Reply-To: <546F16A5.8030405@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F16A5.8030405@users.sourceforge.net> From: Andreas Noever Date: Fri, 21 Nov 2014 12:29:03 +0100 Message-ID: Subject: Re: [PATCH 1/1] thunderbolt: Deletion of unnecessary checks before the function call "ring_free" To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus, ring_free does not check for null: http://lxr.free-electrons.com/source/drivers/thunderbolt/nhi.c#L398 Maybe your software confuses the method with: http://lxr.free-electrons.com/source/drivers/char/tpm/xen-tpmfront.c#L268 Andreas On Fri, Nov 21, 2014 at 11:40 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 21 Nov 2014 11:30:18 +0100 > > The ring_free() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/thunderbolt/ctl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c > index 799634b..55b9bdf 100644 > --- a/drivers/thunderbolt/ctl.c > +++ b/drivers/thunderbolt/ctl.c > @@ -520,10 +520,8 @@ err: > void tb_ctl_free(struct tb_ctl *ctl) > { > int i; > - if (ctl->rx) > - ring_free(ctl->rx); > - if (ctl->tx) > - ring_free(ctl->tx); > + ring_free(ctl->rx); > + ring_free(ctl->tx); > > /* free RX packets */ > for (i = 0; i < TB_CTL_RX_PKG_COUNT; i++) > -- > 2.1.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Noever Date: Fri, 21 Nov 2014 11:29:03 +0000 Subject: Re: [PATCH 1/1] thunderbolt: Deletion of unnecessary checks before the function call "ring_free" Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F16A5.8030405@users.sourceforge.net> In-Reply-To: <546F16A5.8030405@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Hi Markus, ring_free does not check for null: http://lxr.free-electrons.com/source/drivers/thunderbolt/nhi.c#L398 Maybe your software confuses the method with: http://lxr.free-electrons.com/source/drivers/char/tpm/xen-tpmfront.c#L268 Andreas On Fri, Nov 21, 2014 at 11:40 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 21 Nov 2014 11:30:18 +0100 > > The ring_free() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/thunderbolt/ctl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c > index 799634b..55b9bdf 100644 > --- a/drivers/thunderbolt/ctl.c > +++ b/drivers/thunderbolt/ctl.c > @@ -520,10 +520,8 @@ err: > void tb_ctl_free(struct tb_ctl *ctl) > { > int i; > - if (ctl->rx) > - ring_free(ctl->rx); > - if (ctl->tx) > - ring_free(ctl->tx); > + ring_free(ctl->rx); > + ring_free(ctl->tx); > > /* free RX packets */ > for (i = 0; i < TB_CTL_RX_PKG_COUNT; i++) > -- > 2.1.3 >