Re: [PATCH v1 4/9] msmouse: add appropriate unregister handler - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Maxim Davydov <maxim.davydov@openvz.org>
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
	v.sementsov-og@mail.ru, "P. Berrange,
	Daniel" <berrange@redhat.com>,
	"Xiao Guangrong" <xiaoguangrong.eric@gmail.com>,
	"Michael Tsirkin" <mst@redhat.com>,
	"Armbruster, Markus" <armbru@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	lizhijian@fujitsu.com, "Mathieu-Daudé,
	Philippe" <f4bug@amsat.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Zhang Chen" <chen.zhang@intel.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Bonzini, Paolo" <pbonzini@redhat.com>,
	"Ani Sinha" <ani@anisinha.ca>,
	den@openvz.org, "Blake, Eric" <eblake@redhat.com>
Subject: Re: [PATCH v1 4/9] msmouse: add appropriate unregister handler
Date: Tue, 29 Mar 2022 12:13:37 +0400	[thread overview]
Message-ID: <CAMxuvawN7QF6D_5mRphgv6=h0Yjmux3E5iQsT7ZTBj-OpH+WVg@mail.gmail.com> (raw)
In-Reply-To: <20220328211539.90170-5-maxim.davydov@openvz.org>

On Tue, Mar 29, 2022 at 1:15 AM Maxim Davydov <maxim.davydov@openvz.org> wrote:
>
> Attempt to finalize msmouse after initalization brings to segmentation
> fault in QTAILQ_REMOVE.
>
> Signed-off-by: Maxim Davydov <maxim.davydov@openvz.org>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  chardev/msmouse.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/chardev/msmouse.c b/chardev/msmouse.c
> index eb9231dcdb..2cc1b16561 100644
> --- a/chardev/msmouse.c
> +++ b/chardev/msmouse.c
> @@ -146,7 +146,9 @@ static void char_msmouse_finalize(Object *obj)
>  {
>      MouseChardev *mouse = MOUSE_CHARDEV(obj);
>
> -    qemu_input_handler_unregister(mouse->hs);
> +    if (mouse->hs) {
> +        qemu_input_handler_unregister(mouse->hs);
> +    }
>  }
>
>  static QemuInputHandler msmouse_handler = {
> --
> 2.31.1
>