From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70EA1C432BE for ; Tue, 31 Aug 2021 13:47:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E89EA61027 for ; Tue, 31 Aug 2021 13:47:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E89EA61027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL476-0006pJ-UI for qemu-devel@archiver.kernel.org; Tue, 31 Aug 2021 09:47:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL41q-0007d6-6B for qemu-devel@nongnu.org; Tue, 31 Aug 2021 09:42:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL41j-0007KH-OT for qemu-devel@nongnu.org; Tue, 31 Aug 2021 09:42:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630417330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XECjskz2AmwJMDt9pC94qtUn9cGrTtYzJZT8ntVlaJI=; b=HFBEHkDKs/rxxPQ19T5zXpuXEwf0KYnVlYAoT/MIetZt5mKHdU2VJG/Ar1BgnKDdHUVbhe SCAEMkjn2uaGZ2IC0V8RqEHYYN1pputmnsKaSqUheC1IIK6lpHInJYMYsOZ7+Nmi0Ab+fu 1MEQgK1umt1oDSjB+VbPwfOKJ+ZlPQs= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-tgTSfRGmP_C_SF2FUOitZw-1; Tue, 31 Aug 2021 09:42:09 -0400 X-MC-Unique: tgTSfRGmP_C_SF2FUOitZw-1 Received: by mail-pf1-f199.google.com with SMTP id b10-20020a056a0002ca00b003e1bfef6c57so5931pft.13 for ; Tue, 31 Aug 2021 06:42:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XECjskz2AmwJMDt9pC94qtUn9cGrTtYzJZT8ntVlaJI=; b=qFN7jVfyzBbjWO/YAGE/bDeDFuUv+pBc1jKbzKPyzHUx3RmXek1tBp07S87+ltFjwv Gn9Ox0B1fzK4J/U0KgQy0CAH6L6/8lJ4WHhmwbeBcBtVHf5u5RN2XSVMypCVmfegkgpd gneVs2dzlqFdMIJujEcERUJQc7Bdp2Nmlcm//VYe4H16tNgelrOfzT6wMKxnMHIWF9uQ IhIleHyDJu74zhY2P+KF/Nvp4m4TOOK9gXb5wGzwcVjk7oTpuKSHU6HFPwVcj8x1QpgJ iLpKczmuw6xHw2Nk0ci7mCWVYFeIL6OyLOL7jsdeRF3uOFTFFSxA+nRADbI3jE1Gf5yP gk+A== X-Gm-Message-State: AOAM533cqOhsxsQ8zlJNTVy4bFQoIoCx9aKwphwyECStE8fNnfIBkIMN 1JgprwvpI/g4FIVraTTNN0Gd2hJoZzpn3M7PSKgW4TgADxGnTYJc76iwYIPnqjT4kdMjqfa3xg2 gXUrx5BI6I42dkj3QAjUcB02x0CpBR7Q= X-Received: by 2002:a63:d017:: with SMTP id z23mr11306711pgf.108.1630417327907; Tue, 31 Aug 2021 06:42:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy22v/RZ9ZEx9qd4TnQI4yXIvpUyOoBayGK9u4kIWfAiK9pa7hH1okEQZiedeNmQ+6T0GsMdbkbspeny1Fwqrc= X-Received: by 2002:a63:d017:: with SMTP id z23mr11306681pgf.108.1630417327537; Tue, 31 Aug 2021 06:42:07 -0700 (PDT) MIME-Version: 1.0 References: <20210831123809.1107782-1-armbru@redhat.com> In-Reply-To: <20210831123809.1107782-1-armbru@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 31 Aug 2021 17:41:56 +0400 Message-ID: Subject: Re: [PATCH 00/12] qapi: Fixes and cleanups for recent work (mostly) To: Markus Armbruster Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000a4d94205cadb1df5" Received-SPF: pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , John Snow , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000a4d94205cadb1df5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2021 at 4:38 PM Markus Armbruster wrote= : > Markus Armbruster (12): > qapi: Simplify QAPISchemaIfCond's interface for generating C > qapi: Simplify how QAPISchemaIfCond represents "no condition" > tests/qapi-schema: Correct two 'if' conditionals > tests/qapi-schema: Demonstrate broken C code for 'if' > qapi: Fix C code generation for 'if' > qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond() > qapi: Avoid redundant parens in code generated for conditionals > qapi: Use "not COND" instead of "!COND" for generated documentation > qapi: Use re.fullmatch() where appropriate > tests/qapi-schema: Hide OrderedDict in test output > qapi: Tweak error messages for missing / conflicting meta-type > qapi: Tweak error messages for unknown / conflicting 'if' keys > > scripts/qapi/common.py | 51 ++++++++++++++----------- > scripts/qapi/expr.py | 32 +++++++--------- > scripts/qapi/gen.py | 6 +-- > scripts/qapi/introspect.py | 6 +-- > scripts/qapi/schema.py | 12 +++++- > scripts/qapi/types.py | 22 +++++------ > scripts/qapi/visit.py | 14 +++---- > tests/qapi-schema/bad-if-key.err | 2 +- > tests/qapi-schema/bad-if-keys.err | 2 +- > tests/qapi-schema/doc-good.json | 2 +- > tests/qapi-schema/doc-good.out | 6 +-- > tests/qapi-schema/doc-good.txt | 8 ++-- > tests/qapi-schema/double-type.err | 4 +- > tests/qapi-schema/enum-if-invalid.err | 2 +- > tests/qapi-schema/missing-type.err | 2 +- > tests/qapi-schema/qapi-schema-test.json | 9 +++-- > tests/qapi-schema/qapi-schema-test.out | 31 ++++++++------- > tests/qapi-schema/test-qapi.py | 11 +++++- > 18 files changed, 118 insertions(+), 104 deletions(-) > > The first patch, you should apply isort (we should have a check for that and linters I suppose). Series: Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 > 2.31.1 > > --000000000000a4d94205cadb1df5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Aug 31, 2021 at 4:38 PM Marku= s Armbruster <armbru@redhat.com= > wrote:
Mark= us Armbruster (12):
=C2=A0 qapi: Simplify QAPISchemaIfCond's interface for generating C
=C2=A0 qapi: Simplify how QAPISchemaIfCond represents "no condition&qu= ot;
=C2=A0 tests/qapi-schema: Correct two 'if' conditionals
=C2=A0 tests/qapi-schema: Demonstrate broken C code for 'if'
=C2=A0 qapi: Fix C code generation for 'if'
=C2=A0 qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond()<= br> =C2=A0 qapi: Avoid redundant parens in code generated for conditionals
=C2=A0 qapi: Use "not COND" instead of "!COND" for gene= rated documentation
=C2=A0 qapi: Use re.fullmatch() where appropriate
=C2=A0 tests/qapi-schema: Hide OrderedDict in test output
=C2=A0 qapi: Tweak error messages for missing / conflicting meta-type
=C2=A0 qapi: Tweak error messages for unknown / conflicting 'if' ke= ys

=C2=A0scripts/qapi/common.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 51 ++++++++++++++-----------
=C2=A0scripts/qapi/expr.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 | 32 +++++++---------
=C2=A0scripts/qapi/gen.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +--
=C2=A0scripts/qapi/introspect.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 6 +--
=C2=A0scripts/qapi/schema.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 12 +++++-
=C2=A0scripts/qapi/types.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0| 22 +++++------
=C2=A0scripts/qapi/visit.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0| 14 +++----
=C2=A0tests/qapi-schema/bad-if-key.err=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2= +-
=C2=A0tests/qapi-schema/bad-if-keys.err=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2= +-
=C2=A0tests/qapi-schema/doc-good.json=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 2 +-
=C2=A0tests/qapi-schema/doc-good.out=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 6 +--
=C2=A0tests/qapi-schema/doc-good.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 8 ++--
=C2=A0tests/qapi-schema/double-type.err=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 4= +-
=C2=A0tests/qapi-schema/enum-if-invalid.err=C2=A0 =C2=A0|=C2=A0 2 +-
=C2=A0tests/qapi-schema/missing-type.err=C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +- =C2=A0tests/qapi-schema/qapi-schema-test.json |=C2=A0 9 +++--
=C2=A0tests/qapi-schema/qapi-schema-test.out=C2=A0 | 31 ++++++++-------
=C2=A0tests/qapi-schema/test-qapi.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 11= +++++-
=C2=A018 files changed, 118 insertions(+), 104 deletions(-)


The first patch, you should apply isor= t (we should have a check for that and linters I suppose).

Series:
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>=

--
2.31.1

--000000000000a4d94205cadb1df5--