From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F5CC4338F for ; Wed, 4 Aug 2021 08:26:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5869960EBB for ; Wed, 4 Aug 2021 08:26:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5869960EBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBCEs-0004n5-HL for qemu-devel@archiver.kernel.org; Wed, 04 Aug 2021 04:26:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBCE0-0002mD-8V for qemu-devel@nongnu.org; Wed, 04 Aug 2021 04:26:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBCDv-0005Bx-Mv for qemu-devel@nongnu.org; Wed, 04 Aug 2021 04:26:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628065559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JogUtPEbTMHxydsUOGXsb60qLApMw7vMdzi0Spc0IP4=; b=YG44VrIkmVwLhCl070Vv7xqwzkSPy5np5g40fLnFwIwI1GD5rDaP3ezgjep4x7iUrQQiP+ RYyo9WYcrbXQPUC8WVD1skIV8/qXu/uKoRsGShLKil1UEJsCfxKYRbpIecmoMX93SDiJok fgZjeqyVgm5lUGARKatbGXCKBwsFkKg= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-mI051vqVMQ2_XM67SBgwHw-1; Wed, 04 Aug 2021 04:25:57 -0400 X-MC-Unique: mI051vqVMQ2_XM67SBgwHw-1 Received: by mail-pj1-f70.google.com with SMTP id h21-20020a17090adb95b029017797967ffbso1831011pjv.5 for ; Wed, 04 Aug 2021 01:25:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JogUtPEbTMHxydsUOGXsb60qLApMw7vMdzi0Spc0IP4=; b=WZvtFcusmOqa6BmTRzhXBxgpVqgsdtr24Ctd43PlUEFmvjYDYiKylTHmI4mN2qmdum xHXCum15mibq1u7j7ZJcNaqOapM65FvIZmVxJKsggSkebWpp8FjEyniR0jszUh6ZYZj+ buPAuTbsx/eQ4A9fJ281NNCk0/FofcoGK4wOHEacWsD2pTtN0JmrTkWKw4vHtfAbGx9q dle1lU3J7Yr59tQAno8EWOJh6uTU+jRNwhgzJfE5QJhliu36ZyOWdmapKZoH4ytMeRbo gsa7O7jKEDLohvkT1Vf0+dkZI/rUqd2WCvberP5xrLcr6Zxex/54I0Biy3lglvlo3vhD xXFA== X-Gm-Message-State: AOAM533qKmQbeq1KumaMgHoROkqVZHg7kDI28P2257MCS5QYGpgojxMn 5F0sDb/NetOAkikq4kNpjmA8HpewGimnacJYtURZYxrqWwksdAtwre8Uu2wxG3FGHryupw9T5IU SSPNnr52hsTLLWnpFugO74iy0PkT7pZE= X-Received: by 2002:a63:4c0e:: with SMTP id z14mr63376pga.427.1628065556672; Wed, 04 Aug 2021 01:25:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy971UH6gQ7WiBFse3dCvwMZNSswokBv6/YnsXJuqtGQQt6W3qFaZaRDKxcOvXDJNDe/2UhbKxNJyxjlOJ4dBA= X-Received: by 2002:a63:4c0e:: with SMTP id z14mr63367pga.427.1628065556526; Wed, 04 Aug 2021 01:25:56 -0700 (PDT) MIME-Version: 1.0 References: <20210618102507.3761128-1-marcandre.lureau@redhat.com> <877dh2r6cf.fsf@dusky.pond.sub.org> In-Reply-To: <877dh2r6cf.fsf@dusky.pond.sub.org> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 4 Aug 2021 12:25:45 +0400 Message-ID: Subject: Re: [PATCH v6 00/11] qapi: untie 'if' conditions from C preprocessor To: Markus Armbruster Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002b136a05c8b78d9e" Received-SPF: pass client-ip=216.205.24.124; envelope-from=mlureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Blake , John Snow , qemu-devel , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000002b136a05c8b78d9e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Aug 3, 2021 at 5:44 PM Markus Armbruster wrote: > marcandre.lureau@redhat.com writes: > > > From: Marc-Andr=C3=A9 Lureau > > > > Hi, > > > > This series makes the 'if' conditions less liberal, by formalizing a > simple > > expression tree based on bare boolean logic of configure option > identifiers. > > > > (this allows to express conditions in Rust in my QAPI-Rust PoC series) > > > > thanks > > I like this overall. > > The commit messages are rather terse in places. I have a few questions, > I asked for a few minor tweaks, and I also noted a few possible > improvements that can be done on top. I wonder whether we can drop > PATCH 04. > > Let's discuss my findings, then decide whether we want a respin. > Thanks, I am sending v7 with the requested changes. --0000000000002b136a05c8b78d9e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, Aug 3, 2021 at 5:44 PM Mark= us Armbruster <armbru@redhat.com> wrote:
marcandre.lur= eau@redhat.com writes:

> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> This series makes the 'if' conditions less liberal, by formali= zing a simple
> expression tree based on bare boolean logic of configure option identi= fiers.
>
> (this allows to express conditions in Rust in my QAPI-Rust PoC series)=
>
> thanks

I like this overall.

The commit messages are rather terse in places.=C2=A0 I have a few question= s,
I asked for a few minor tweaks, and I also noted a few possible
improvements that can be done on top.=C2=A0 I wonder whether we can drop PATCH 04.

Let's discuss my findings, then decide whether we want a respin.

Thanks, I am sending v7 with the requested ch= anges.

--0000000000002b136a05c8b78d9e--