From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] ui: dbus-display requires CONFIG_GBM
Date: Thu, 28 Jul 2022 13:46:36 +0400 [thread overview]
Message-ID: <CAMxuvaxf0oZ5aarkL12zVbyvPxthrUq8T3Y_c56tp9R9-+zRsw@mail.gmail.com> (raw)
In-Reply-To: <20220728064143.209559-1-pbonzini@redhat.com>
On Thu, Jul 28, 2022 at 10:41 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Without CONFIG_GBM, compiling dbus-display fails with
>
> ../ui/dbus.c: In function ‘dbus_create_context’:
> ../ui/dbus.c:47:20: error: ‘qemu_egl_rn_ctx’ undeclared (first use in this function); did you mean ‘qemu_egl_init_ctx’?
> 47 | qemu_egl_rn_ctx);
> | ^~~~~~~~~~~~~~~
> | qemu_egl_init_ctx
> ../ui/dbus.c:47:20: note: each undeclared identifier is reported only once for each function it appears in
>
> and many other similar errors, because include/ui/egl-helpers.h only has
> these declaration if gbm is found on the system.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
As Daniel said, wfm:
+ you can mention https://gitlab.com/qemu-project/qemu/-/issues/1108
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 4 ++--
> ui/meson.build | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 9b67db0d67..38403d2892 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1697,8 +1697,8 @@ dbus_display = get_option('dbus_display') \
> error_message: '-display dbus requires glib>=2.64') \
> .require(gdbus_codegen.found(),
> error_message: '-display dbus requires gdbus-codegen') \
> - .require(opengl.found(),
> - error_message: '-display dbus requires epoxy/egl') \
> + .require(opengl.found() and gbm.found(),
> + error_message: '-display dbus requires epoxy/egl and gbm') \
> .allowed()
>
> have_virtfs = get_option('virtfs') \
> diff --git a/ui/meson.build b/ui/meson.build
> index e9f48c5315..ec13949776 100644
> --- a/ui/meson.build
> +++ b/ui/meson.build
> @@ -81,7 +81,7 @@ if dbus_display
> '--interface-prefix', 'org.qemu.',
> '--c-namespace', 'QemuDBus',
> '--generate-c-code', '@BASENAME@'])
> - dbus_ss.add(when: [gio, pixman, opengl],
> + dbus_ss.add(when: [gio, pixman, opengl, gbm],
> if_true: [files(
> 'dbus-chardev.c',
> 'dbus-clipboard.c',
> --
> 2.36.1
>
prev parent reply other threads:[~2022-07-28 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 6:41 [PATCH] ui: dbus-display requires CONFIG_GBM Paolo Bonzini
2022-07-28 8:46 ` Daniel P. Berrangé
2022-07-28 9:46 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMxuvaxf0oZ5aarkL12zVbyvPxthrUq8T3Y_c56tp9R9-+zRsw@mail.gmail.com \
--to=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.