All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: John Snow <jsnow@redhat.com>, "Blake, Eric" <eblake@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 01/22] qapi: Tidy up unusual line breaks
Date: Mon, 13 Sep 2021 17:59:12 +0400	[thread overview]
Message-ID: <CAMxuvay2yNs4LxoVu8OCKV0AnkdqDvuR9rySAEX=PYkX4pk3KA@mail.gmail.com> (raw)
In-Reply-To: <87mtogk2c2.fsf@dusky.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

Hi

On Mon, Sep 13, 2021 at 5:55 PM Markus Armbruster <armbru@redhat.com> wrote:

> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>
> > Hi
> >
> > On Mon, Sep 13, 2021 at 4:39 PM Markus Armbruster <armbru@redhat.com>
> wrote:
> >
> >> Break lines between members instead of within members.
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >>
> >
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > I wish we would just automated tools to format files. With that git 2.23
> > feature, no more excuses :):
> >
> https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
>
> Interesting.
>

Yeah, unfortunately you would have to add the commit rev after it's merged.


> > Sadly, our mixed json/py format doesn't get parsed after "blake"
> reformats
> > it (strings or trailing commas).
>
> Naming QAPI schema files .json even though their contents isn't was a
> mistake.
>
> We discussed possible improvements in the thread below
>
>     Message-ID: <87ime52wxd.fsf@dusky.pond.sub.org>
>     https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08325.html
>
> Too much to read, but there's a summary:
>
>     Message-ID: <877dt5ofoi.fsf@dusky.pond.sub.org>
>     https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg02553.html
>
> The least invasive way to achieve formatting automation could be
> switching from bastardized JSON to proper subset of Python.
>

ok


> What's "blake"?
>

Sorry, don't know why I always remember "blake" when it is simply  "black" (
https://github.com/psf/black)

[-- Attachment #2: Type: text/html, Size: 3290 bytes --]

  reply	other threads:[~2021-09-13 14:38 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 12:39 [PATCH 00/22] qapi: Remove simple unions from the schema language Markus Armbruster
2021-09-13 12:39 ` [PATCH 01/22] qapi: Tidy up unusual line breaks Markus Armbruster
2021-09-13 13:29   ` Marc-André Lureau
2021-09-13 13:54     ` Markus Armbruster
2021-09-13 13:59       ` Marc-André Lureau [this message]
2021-09-13 12:39 ` [PATCH 02/22] qapi: Stop enforcing "type name should not end in 'Kind' Markus Armbruster
2021-09-13 14:40   ` Eric Blake
2021-09-13 12:39 ` [PATCH 03/22] qapi: Convert simple union KeyValue to flat one Markus Armbruster
2021-09-13 14:45   ` Eric Blake
2021-09-14  4:54     ` Markus Armbruster
2021-09-14  7:15   ` Gerd Hoffmann
2021-09-13 12:39 ` [PATCH 04/22] qapi: Convert simple union InputEvent " Markus Armbruster
2021-09-13 14:46   ` Eric Blake
2021-09-14  4:55     ` Markus Armbruster
2021-09-14  7:15   ` Gerd Hoffmann
2021-09-13 12:39 ` [PATCH 05/22] qapi: Convert simple union TpmTypeOptions " Markus Armbruster
2021-09-13 16:32   ` Stefan Berger
2021-09-13 12:39 ` [PATCH 06/22] qapi: Convert simple union MemoryDeviceInfo " Markus Armbruster
2021-09-13 12:39 ` [PATCH 07/22] qapi: Convert simple union ChardevBackend " Markus Armbruster
2021-09-13 12:39 ` [PATCH 08/22] qapi: Convert simple union SocketAddressLegacy " Markus Armbruster
2021-09-13 12:39 ` [PATCH 09/22] qapi: Convert simple union ImageInfoSpecific " Markus Armbruster
2021-09-16 15:01   ` Hanna Reitz
2021-09-13 12:39 ` [PATCH 10/22] qapi: Convert simple union TransactionAction " Markus Armbruster
2021-09-13 14:53   ` Eric Blake
2021-09-14  5:25     ` Markus Armbruster
2021-09-16 15:01   ` Hanna Reitz
2021-09-13 12:39 ` [PATCH 11/22] tests/qapi-schema: Prepare for simple union UserDefListUnion removal Markus Armbruster
2021-09-13 15:01   ` Eric Blake
2021-09-13 12:39 ` [PATCH 12/22] test-qobject-input-visitor: Wean off UserDefListUnion Markus Armbruster
2021-09-13 15:06   ` Eric Blake
2021-09-14  5:50     ` Markus Armbruster
2021-09-13 12:39 ` [PATCH 13/22] test-qobject-output-visitor: " Markus Armbruster
2021-09-13 15:09   ` Eric Blake
2021-09-13 12:39 ` [PATCH 14/22] test-clone-visitor: " Markus Armbruster
2021-09-13 15:10   ` Eric Blake
2021-09-13 12:39 ` [PATCH 15/22] tests/qapi-schema: " Markus Armbruster
2021-09-13 15:26   ` Eric Blake
2021-09-13 12:39 ` [PATCH 16/22] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop Markus Armbruster
2021-09-13 15:27   ` Eric Blake
2021-09-13 12:39 ` [PATCH 17/22] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat Markus Armbruster
2021-09-13 15:28   ` Eric Blake
2021-09-13 12:39 ` [PATCH 18/22] test-clone-visitor: Wean off __org.qemu_x-Union1 Markus Armbruster
2021-09-13 15:32   ` Eric Blake
2021-09-13 12:39 ` [PATCH 19/22] tests/qapi-schema: Drop simple union __org.qemu_x-Union1 Markus Armbruster
2021-09-13 15:35   ` Eric Blake
2021-09-14  5:55     ` Markus Armbruster
2021-09-13 12:39 ` [PATCH 20/22] tests/qapi-schema: Purge simple unions from tests Markus Armbruster
2021-09-13 15:37   ` Eric Blake
2021-09-13 12:39 ` [PATCH 21/22] qapi: Drop simple unions Markus Armbruster
2021-09-13 18:38   ` Eric Blake
2021-09-14  5:57     ` Markus Armbruster
2021-09-13 12:39 ` [PATCH 22/22] test-clone-visitor: Correct an accidental rename Markus Armbruster
2021-09-13 18:40   ` Eric Blake
2021-09-13 12:49 ` [PATCH 00/22] qapi: Remove simple unions from the schema language Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMxuvay2yNs4LxoVu8OCKV0AnkdqDvuR9rySAEX=PYkX4pk3KA@mail.gmail.com' \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.