From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763FEC433E0 for ; Mon, 21 Dec 2020 08:17:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F284222C9C for ; Mon, 21 Dec 2020 08:17:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F284222C9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krGNI-0002bV-Go for qemu-devel@archiver.kernel.org; Mon, 21 Dec 2020 03:17:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krGMG-00029Z-KR for qemu-devel@nongnu.org; Mon, 21 Dec 2020 03:15:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krGMC-0001MM-Od for qemu-devel@nongnu.org; Mon, 21 Dec 2020 03:15:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608538549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gQGRhEKO0pq1UbIGEaxcfimezClPFPgR3dud8wXVUAY=; b=MFktFdtHljx/4Q9/s9Lsqp8UNiGF8I1IuqCdBJSkJBDr6yzli5Jj08K+oagu0UVSkXw+l1 xiO33uFrZVPh1whB0iz0WuUI2YcbZrPVH79tNYDFkjxIFFOTa3E4LvcKHPoxPbY1H63djl uh6yDYHY3brJ7qdRC36GwggWRXDNCc4= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-lKXG08B4OQa5rkN7WJ20Rg-1; Mon, 21 Dec 2020 03:15:46 -0500 X-MC-Unique: lKXG08B4OQa5rkN7WJ20Rg-1 Received: by mail-il1-f198.google.com with SMTP id c13so8651715ilg.22 for ; Mon, 21 Dec 2020 00:15:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gQGRhEKO0pq1UbIGEaxcfimezClPFPgR3dud8wXVUAY=; b=c0ZIXefMSKhdR+vtw7pWHnxNBBwhX38RB1TCLMY48/jrinAlUkPL1tPfwQnfCayFem CHV5oHrE3RSv/a9fZVJCVu3nm4Bbif8JNJLXuKjaH59HA4djdRsC0Uuv14+FbmaF58Qc ENvcojEGoDKj/LSgl2JB7MHAwETu0YzCZozKb+H33qPTJx0WLIEqpTBFy+30nC9uRq8f /Bb7PHhNOzHsrNxderIn/hTJajQrTYe5nuGExPmiO8zhWE39AgiQl9xgnq98erBGFTjI y5DmH7l646eHCKPwiqzqdkyH/hGevdts0Ng0BlpEjqLQVlgcEBbQklsMjin/yRzObUd1 tr4w== X-Gm-Message-State: AOAM532waaHfT22FX2xOvrokOXc5aLKpCAKIdrKWQ0ZKKc2sHpVvWzkZ IBLwQMWi40QG9U1eD7wTiP7Xru9NYPXVeoAbi4IAl6ZarCw+cr2tLfYPcsRik48jr1ShT7UY04Y dgjiHzrQceq52kG3lej6mWATMvE2HPMA= X-Received: by 2002:a92:4101:: with SMTP id o1mr15647081ila.82.1608538545379; Mon, 21 Dec 2020 00:15:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzY4GvFYqMZxlPHpfi65OKXEJmgtnyfk3gSurparfAUm8AjiJhyCqIZ/qdQ0helzamwfGYpDxtUwltj/A/sPkA= X-Received: by 2002:a92:4101:: with SMTP id o1mr15647067ila.82.1608538545215; Mon, 21 Dec 2020 00:15:45 -0800 (PST) MIME-Version: 1.0 References: <20201219090637.1700900-1-pbonzini@redhat.com> <20201219090637.1700900-2-pbonzini@redhat.com> In-Reply-To: <20201219090637.1700900-2-pbonzini@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Mon, 21 Dec 2020 12:15:34 +0400 Message-ID: Subject: Re: [PATCH 1/2] whpx: rename whp-dispatch to whpx-internal.h To: Paolo Bonzini Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000009870e005b6f51083" Received-SPF: pass client-ip=63.128.21.124; envelope-from=mlureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000009870e005b6f51083 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 19, 2020 at 1:06 PM Paolo Bonzini wrote: > Rename the file in preparation for moving more implementation-internal > definitions to it. The build is still broken though. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-Andr=C3=A9 Lureau --- > target/i386/whpx/whpx-all.c | 5 +---- > target/i386/whpx/whpx-apic.c | 2 +- > target/i386/whpx/whpx-cpus.c | 4 +--- > target/i386/whpx/{whp-dispatch.h =3D> whpx-internal.h} | 6 +++--- > 4 files changed, 6 insertions(+), 11 deletions(-) > rename target/i386/whpx/{whp-dispatch.h =3D> whpx-internal.h} (98%) > > diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c > index 3b824fc9d7..12f79e2cd6 100644 > --- a/target/i386/whpx/whpx-all.c > +++ b/target/i386/whpx/whpx-all.c > @@ -26,13 +26,10 @@ > #include "qapi/qapi-types-common.h" > #include "qapi/qapi-visit-common.h" > #include "migration/blocker.h" > -#include "whp-dispatch.h" > #include > > #include "whpx-cpus.h" > - > -#include > -#include > +#include "whpx-internal.h" > > #define HYPERV_APIC_BUS_FREQUENCY (200000000ULL) > > diff --git a/target/i386/whpx/whpx-apic.c b/target/i386/whpx/whpx-apic.c > index b127a3cb8a..1d330bf749 100644 > --- a/target/i386/whpx/whpx-apic.c > +++ b/target/i386/whpx/whpx-apic.c > @@ -18,7 +18,7 @@ > #include "hw/pci/msi.h" > #include "sysemu/hw_accel.h" > #include "sysemu/whpx.h" > -#include "whp-dispatch.h" > +#include "whpx-internal.h" > > static void whpx_put_apic_state(APICCommonState *s, > struct whpx_lapic_state *kapic) > diff --git a/target/i386/whpx/whpx-cpus.c b/target/i386/whpx/whpx-cpus.c > index d9bd5a2d36..f7e69881a3 100644 > --- a/target/i386/whpx/whpx-cpus.c > +++ b/target/i386/whpx/whpx-cpus.c > @@ -15,11 +15,9 @@ > #include "qemu/guest-random.h" > > #include "sysemu/whpx.h" > +#include "whpx-internal.h" > #include "whpx-cpus.h" > > -#include > -#include > - > static void *whpx_cpu_thread_fn(void *arg) > { > CPUState *cpu =3D arg; > diff --git a/target/i386/whpx/whp-dispatch.h > b/target/i386/whpx/whpx-internal.h > similarity index 98% > rename from target/i386/whpx/whp-dispatch.h > rename to target/i386/whpx/whpx-internal.h > index cef5d848bd..e0a9ea1dce 100644 > --- a/target/i386/whpx/whp-dispatch.h > +++ b/target/i386/whpx/whpx-internal.h > @@ -1,5 +1,5 @@ > -#ifndef WHP_DISPATCH_H > -#define WHP_DISPATCH_H > +#ifndef WHP_INTERNAL_H > +#define WHP_INTERNAL_H > > #include > #include > @@ -72,4 +72,4 @@ typedef enum WHPFunctionList { > WINHV_PLATFORM_FNS_SUPPLEMENTAL > } WHPFunctionList; > > -#endif /* WHP_DISPATCH_H */ > +#endif /* WHP_INTERNAL_H */ > -- > 2.26.2 > > > --0000000000009870e005b6f51083 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Dec 19, 2020 at 1:06 PM Paolo= Bonzini <pbonzini@redhat.com= > wrote:
Rena= me the file in preparation for moving more implementation-internal
definitions to it.=C2=A0 The build is still broken though.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

<= div>Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>=C2=A0
---
=C2=A0target/i386/whpx/whpx-all.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 5 +----
=C2=A0target/i386/whpx/whpx-apic.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
=C2=A0target/i386/whpx/whpx-cpus.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 4 +---
=C2=A0target/i386/whpx/{whp-dispatch.h =3D> whpx-internal.h} | 6 +++---<= br> =C2=A04 files changed, 6 insertions(+), 11 deletions(-)
=C2=A0rename target/i386/whpx/{whp-dispatch.h =3D> whpx-internal.h} (98%= )

diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c
index 3b824fc9d7..12f79e2cd6 100644
--- a/target/i386/whpx/whpx-all.c
+++ b/target/i386/whpx/whpx-all.c
@@ -26,13 +26,10 @@
=C2=A0#include "qapi/qapi-types-common.h"
=C2=A0#include "qapi/qapi-visit-common.h"
=C2=A0#include "migration/blocker.h"
-#include "whp-dispatch.h"
=C2=A0#include <winerror.h>

=C2=A0#include "whpx-cpus.h"
-
-#include <WinHvPlatform.h>
-#include <WinHvEmulation.h>
+#include "whpx-internal.h"

=C2=A0#define HYPERV_APIC_BUS_FREQUENCY=C2=A0 =C2=A0 =C2=A0 (200000000ULL)<= br>
diff --git a/target/i386/whpx/whpx-apic.c b/target/i386/whpx/whpx-apic.c index b127a3cb8a..1d330bf749 100644
--- a/target/i386/whpx/whpx-apic.c
+++ b/target/i386/whpx/whpx-apic.c
@@ -18,7 +18,7 @@
=C2=A0#include "hw/pci/msi.h"
=C2=A0#include "sysemu/hw_accel.h"
=C2=A0#include "sysemu/whpx.h"
-#include "whp-dispatch.h"
+#include "whpx-internal.h"

=C2=A0static void whpx_put_apic_state(APICCommonState *s,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct whpx_lapic_state *kapic= )
diff --git a/target/i386/whpx/whpx-cpus.c b/target/i386/whpx/whpx-cpus.c index d9bd5a2d36..f7e69881a3 100644
--- a/target/i386/whpx/whpx-cpus.c
+++ b/target/i386/whpx/whpx-cpus.c
@@ -15,11 +15,9 @@
=C2=A0#include "qemu/guest-random.h"

=C2=A0#include "sysemu/whpx.h"
+#include "whpx-internal.h"
=C2=A0#include "whpx-cpus.h"

-#include <WinHvPlatform.h>
-#include <WinHvEmulation.h>
-
=C2=A0static void *whpx_cpu_thread_fn(void *arg)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0CPUState *cpu =3D arg;
diff --git a/target/i386/whpx/whp-dispatch.h b/target/i386/whpx/whpx-intern= al.h
similarity index 98%
rename from target/i386/whpx/whp-dispatch.h
rename to target/i386/whpx/whpx-internal.h
index cef5d848bd..e0a9ea1dce 100644
--- a/target/i386/whpx/whp-dispatch.h
+++ b/target/i386/whpx/whpx-internal.h
@@ -1,5 +1,5 @@
-#ifndef WHP_DISPATCH_H
-#define WHP_DISPATCH_H
+#ifndef WHP_INTERNAL_H
+#define WHP_INTERNAL_H

=C2=A0#include <windows.h>
=C2=A0#include <WinHvPlatform.h>
@@ -72,4 +72,4 @@ typedef enum WHPFunctionList {
=C2=A0 =C2=A0 =C2=A0WINHV_PLATFORM_FNS_SUPPLEMENTAL
=C2=A0} WHPFunctionList;

-#endif /* WHP_DISPATCH_H */
+#endif /* WHP_INTERNAL_H */
--
2.26.2


--0000000000009870e005b6f51083--