From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861AbcHRIy6 (ORCPT ); Thu, 18 Aug 2016 04:54:58 -0400 Received: from mail-yw0-f181.google.com ([209.85.161.181]:33957 "EHLO mail-yw0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753632AbcHRIy4 (ORCPT ); Thu, 18 Aug 2016 04:54:56 -0400 MIME-Version: 1.0 In-Reply-To: <87inuy5yvr.fsf@linux.intel.com> References: <87inuy5yvr.fsf@linux.intel.com> From: Baolin Wang Date: Thu, 18 Aug 2016 16:54:55 +0800 Message-ID: Subject: Re: [PATCH 2/4] usb: host: xhci: Introduce one new 'usb3_slow_suspend' member for xhci private data To: Felipe Balbi Cc: Greg KH , mathias.nyman@intel.com, USB , LKML , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, On 18 August 2016 at 15:18, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Now some usb controllers (such as dwc3 controller) need 'XHCI_SLOW_SUSPEND' >> quirk when suspending the xhci, thus we need to add 'usb3_slow_suspend' member >> in xhci platform data to support this. >> >> Signed-off-by: Baolin Wang >> --- >> drivers/usb/host/xhci-plat.c | 3 +++ >> include/linux/usb/xhci_pdriver.h | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >> index e2e2487..162f17c 100644 >> --- a/drivers/usb/host/xhci-plat.c >> +++ b/drivers/usb/host/xhci-plat.c >> @@ -250,6 +250,9 @@ static int xhci_plat_probe(struct platform_device *pdev) >> (pdata && pdata->usb3_lpm_capable)) >> xhci->quirks |= XHCI_LPM_SUPPORT; >> >> + if (pdata && pdata->usb3_slow_suspend) >> + xhci->quirks |= XHCI_SLOW_SUSPEND; > > I remember having a discussion about this with Paul Z and it turned out > that we really didn't need SLOW_SUSPEND. Can you describe further in > what situation you need this quirk? On my dwc3 platform, xhci suspend will be failed if we have not enabled XHCI_SLOW_SUSPEND quirk. -- Baolin.wang Best Regards