From: Baolin Wang <baolin.wang@linaro.org>
To: Milan Broz <gmazyland@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Alasdair G Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, neilb@suse.com, dan.j.williams@intel.com,
martin.petersen@oracle.com, sagig@mellanox.com,
Kent Overstreet <kent.overstreet@gmail.com>,
keith.busch@intel.com, tj@kernel.org,
Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency
Date: Wed, 16 Dec 2015 16:31:11 +0800 [thread overview]
Message-ID: <CAMz4kuJ3W-oA9AsOQOT1BWS-cY8UUEgm1UzDKmsFY5QdNG0-oA@mail.gmail.com> (raw)
In-Reply-To: <56711C0F.8030105@gmail.com>
On 16 December 2015 at 16:08, Milan Broz <gmazyland@gmail.com> wrote:
> On 12/16/2015 04:18 AM, Baolin Wang wrote:
>> From the dm-crypt performance report, we found it shows low efficiency
>> with crypto engine for some mode (like ecb or xts mode). Because in dm
>> crypt, it will map the IO data buffer with scatterlist, and send the
>> scatterlist of one bio to the encryption engine, if send more scatterlists
>> with bigger size at one time, that helps the engine palys best performance,
>> which means a high encryption speed.
>>
>> But now the dm-crypt only map one segment (always one sector) of one bio
>> with one scatterlist to the crypto engine at one time. which is more
>> time-consuming and ineffective for the crypto engine. Especially for some
>> modes which don't need different IV for each sector, we can map the whole
>> bio with multiple scatterlists to improve the engine performance.
>>
>> But this optimization is not support some ciphers and IV modes which should
>> do sector by sector and need different IV for each sector.
>>
>> Change since v1:
>> - Introduce one different IV mode.
>> - Change the conditions for bulk mode.
>
> I tried the patchset on 32bit Intel VM and kernel immediately OOPsed (just tried aes-ecb)...
>
I'm sorry for that. I'll check why it will crash though it can work
well on my beaglebone black board. Thanks.
> Crash log below.
--
Baolin.wang
Best Regards
next prev parent reply other threads:[~2015-12-16 8:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 3:18 [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency Baolin Wang
2015-12-16 3:18 ` Baolin Wang
2015-12-16 3:18 ` [PATCH v2 1/2] block: Export the __blk_bios_map_sg() to map one bio Baolin Wang
2015-12-16 3:18 ` [PATCH v2 2/2] md: dm-crypt: Introduce the bulk IV mode for bulk crypto Baolin Wang
2015-12-16 8:08 ` [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency Milan Broz
2015-12-16 8:31 ` Baolin Wang [this message]
2015-12-17 7:37 ` Baolin Wang
2016-01-02 22:46 ` Milan Broz
2016-01-04 6:58 ` Baolin Wang
2016-01-04 20:13 ` Mark Brown
2016-01-06 6:49 ` Baolin Wang
2016-01-12 23:31 ` [dm-devel] " Mikulas Patocka
2016-01-12 23:38 ` Arnd Bergmann
2016-01-13 2:18 ` Mikulas Patocka
2016-01-13 10:17 ` Arnd Bergmann
2016-01-13 15:00 ` Mikulas Patocka
2016-01-13 7:01 ` Milan Broz
2016-01-12 23:40 ` Mark Brown
2016-01-13 2:13 ` Mikulas Patocka
2016-01-14 11:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuJ3W-oA9AsOQOT1BWS-cY8UUEgm1UzDKmsFY5QdNG0-oA@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=keith.busch@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.com \
--cc=sagig@mellanox.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.