From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/5] dmaengine: sprd: Define the DMA transfer step type From: Baolin Wang Message-Id: Date: Wed, 11 Apr 2018 18:49:59 +0800 To: Vinod Koul Cc: Dan Williams , Eric Long , Mark Brown , dmaengine@vger.kernel.org, LKML List-ID: SGkgVmlub2QsCgpPbiAxMSBBcHJpbCAyMDE4IGF0IDE3OjI0LCBWaW5vZCBLb3VsIDx2aW5vZC5r b3VsQGludGVsLmNvbT4gd3JvdGU6Cj4gT24gVHVlLCBBcHIgMTAsIDIwMTggYXQgMDM6NDY6MDNQ TSArMDgwMCwgQmFvbGluIFdhbmcgd3JvdGU6Cj4+IEZyb206IEVyaWMgTG9uZyA8ZXJpYy5sb25n QHNwcmVhZHRydW0uY29tPgo+Pgo+PiBEZWZpbmUgdGhlIERNQSB0cmFuc2ZlciBzdGVwIHR5cGUg dG8gbWFrZSBjb2RlIG1vcmUgcmVhZGFibGUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEVyaWMgTG9u ZyA8ZXJpYy5sb25nQHNwcmVhZHRydW0uY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBCYW9saW4gV2Fu ZyA8YmFvbGluLndhbmdAbGluYXJvLm9yZz4KPj4gLS0tCj4+ICBkcml2ZXJzL2RtYS9zcHJkLWRt YS5jIHwgICAyOCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdl ZCwgMjIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZG1hL3NwcmQtZG1hLmMgYi9kcml2ZXJzL2RtYS9zcHJkLWRtYS5jCj4+IGluZGV4IGIx MDZlOGEuLmFmOWMxNTYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZG1hL3NwcmQtZG1hLmMKPj4g KysrIGIvZHJpdmVycy9kbWEvc3ByZC1kbWEuYwo+PiBAQCAtMTY5LDYgKzE2OSwyMiBAQCBlbnVt IHNwcmRfZG1hX2ludF90eXBlIHsKPj4gICAgICAgU1BSRF9ETUFfQ0ZHRVJSX0lOVCwKPj4gIH07 Cj4+Cj4+ICsvKgo+PiArICogZW51bSBzcHJkX2RtYV9zdGVwOiBkZWZpbmUgdGhlIERNQSB0cmFu c2ZlciBzdGVwIHR5cGUKPj4gKyAqIEBTUFJEX0RNQV9OT05FX1NURVA6IHRyYW5zZmVyIGRvIG5v dCBuZWVkIHN0ZXAKPj4gKyAqIEBTUFJEX0RNQV9CWVRFX1NURVA6IHRyYW5zZmVyIHN0ZXAgaXMg b25lIGJ5dGUKPj4gKyAqIEBTUFJEX0RNQV9TSE9SVF9TVEVQOiB0cmFuc2ZlciBzdGVwIGlzIHR3 byBieXRlcwo+PiArICogQFNQUkRfRE1BX1dPUkRfU1RFUDogdHJhbnNmZXIgc3RlcCBpcyBvbmUg d29yZAo+PiArICogQFNQUkRfRE1BX0RXT1JEX1NURVA6IHRyYW5zZmVyIHN0ZXAgaXMgZG91Ymxl IHdvcmQKPj4gKyAqLwo+PiArZW51bSBzcHJkX2RtYV9zdGVwIHsKPgo+IGxvb2tpbmcgYXQgYml0 IGRlZmluZXMsIGRvZXMgaXQgbmVlZCB0byBiZSBlbnVtPyBhICNkZWZpbmUgd291bGQganVzdCBi ZSBmaW5lLgoKUmlnaHQuIEl0IHNlZW1zIG1vcmUgY2xlYXIgaWYgd2UgY29tYmluZWQgdGhlbSBp bnRvIG9uZSBlbnVtCnN0cnVjdHVyZSwgYnV0IEkgY2FuIGNvbnZlcnQgdG8gI2RlZmluZSBpZiB5 b3UgaGF2ZSBzdHJvbmcgcHJlZmVyZW5jZS4KVGhhbmtzLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbeDKKuC (ORCPT ); Wed, 11 Apr 2018 06:50:02 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:45535 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752297AbeDKKuA (ORCPT ); Wed, 11 Apr 2018 06:50:00 -0400 X-Google-Smtp-Source: AIpwx4/k2RidDrD5Sg4KKa6Yao7iX8lmcRhtFkeR6jisGt1hidJB3OMJDlJfjOxeI2DiMLSPIAtW1OtzRENuVjXz6Tk= MIME-Version: 1.0 In-Reply-To: <20180411092402.GB6014@localhost> References: <20180411092402.GB6014@localhost> From: Baolin Wang Date: Wed, 11 Apr 2018 18:49:59 +0800 Message-ID: Subject: Re: [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type To: Vinod Koul Cc: Dan Williams , Eric Long , Mark Brown , dmaengine@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, On 11 April 2018 at 17:24, Vinod Koul wrote: > On Tue, Apr 10, 2018 at 03:46:03PM +0800, Baolin Wang wrote: >> From: Eric Long >> >> Define the DMA transfer step type to make code more readable. >> >> Signed-off-by: Eric Long >> Signed-off-by: Baolin Wang >> --- >> drivers/dma/sprd-dma.c | 28 ++++++++++++++++++++++------ >> 1 file changed, 22 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c >> index b106e8a..af9c156 100644 >> --- a/drivers/dma/sprd-dma.c >> +++ b/drivers/dma/sprd-dma.c >> @@ -169,6 +169,22 @@ enum sprd_dma_int_type { >> SPRD_DMA_CFGERR_INT, >> }; >> >> +/* >> + * enum sprd_dma_step: define the DMA transfer step type >> + * @SPRD_DMA_NONE_STEP: transfer do not need step >> + * @SPRD_DMA_BYTE_STEP: transfer step is one byte >> + * @SPRD_DMA_SHORT_STEP: transfer step is two bytes >> + * @SPRD_DMA_WORD_STEP: transfer step is one word >> + * @SPRD_DMA_DWORD_STEP: transfer step is double word >> + */ >> +enum sprd_dma_step { > > looking at bit defines, does it need to be enum? a #define would just be fine. Right. It seems more clear if we combined them into one enum structure, but I can convert to #define if you have strong preference. Thanks. -- Baolin.wang Best Regards