From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493AbdIHB5V (ORCPT ); Thu, 7 Sep 2017 21:57:21 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:34231 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbdIHB5S (ORCPT ); Thu, 7 Sep 2017 21:57:18 -0400 X-Google-Smtp-Source: AOwi7QA1AplhYRITqLfv94sSnIPIpfC+5jLkLEHNBO2EGg40z07DYS8H+vbHGbEnGK3NPHHYtSrLbRwe3AIr+LZCOAY= MIME-Version: 1.0 In-Reply-To: <20170907114401.kz2rfss2bkslybtq@sirena.co.uk> References: <20170906145900.yesyfyruv5wd3wxj@sirena.co.uk> <20170907095435.5yhybxz6oootp37h@sirena.co.uk> <20170907114401.kz2rfss2bkslybtq@sirena.co.uk> From: Baolin Wang Date: Fri, 8 Sep 2017 09:57:17 +0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation To: Mark Brown Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7 September 2017 at 19:44, Mark Brown wrote: > On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: >> On 7 September 2017 at 17:54, Mark Brown wrote: >> > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote: > >> >> The hwspinlock name should be "adi", and I will make it clear in next version. > >> > So there's other drivers that might also be accessing this IP block? > >> Yes. Other drivers (like regulator, RTC or charger ... ) can access >> analog chip (like PMIC) by ADI controller. But the hardware spinlock >> is used to synchronize between the multiple subsystems, since we only >> have one ADI controller. > > If it were other drivers then the kernel should already be doing that > but... Not only kernel drivers, but also other systems' drivers will access ADI too. So here we need one hardware spinlock to protect, I will add more documentation. > >> > So does this driver control all the channels or are there other drivers >> > (or hardware components) that control some of the other channels? > >> The ADI driver only controls 2 software channels (read/write), and >> other hardware channels can be controlled by hardware components if we >> set the hardware config. > > ...if it can be configured to allow other things to use it independently > then this is fine, just needs a bit more documentation so someone can > understand how the bindings and hardware match up. OK. Thanks for your comments. -- Baolin.wang Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baolin Wang Subject: Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation Date: Fri, 8 Sep 2017 09:57:17 +0800 Message-ID: References: <20170906145900.yesyfyruv5wd3wxj@sirena.co.uk> <20170907095435.5yhybxz6oootp37h@sirena.co.uk> <20170907114401.kz2rfss2bkslybtq@sirena.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170907114401.kz2rfss2bkslybtq-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML List-Id: devicetree@vger.kernel.org On 7 September 2017 at 19:44, Mark Brown wrote: > On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: >> On 7 September 2017 at 17:54, Mark Brown wrote: >> > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote: > >> >> The hwspinlock name should be "adi", and I will make it clear in next version. > >> > So there's other drivers that might also be accessing this IP block? > >> Yes. Other drivers (like regulator, RTC or charger ... ) can access >> analog chip (like PMIC) by ADI controller. But the hardware spinlock >> is used to synchronize between the multiple subsystems, since we only >> have one ADI controller. > > If it were other drivers then the kernel should already be doing that > but... Not only kernel drivers, but also other systems' drivers will access ADI too. So here we need one hardware spinlock to protect, I will add more documentation. > >> > So does this driver control all the channels or are there other drivers >> > (or hardware components) that control some of the other channels? > >> The ADI driver only controls 2 software channels (read/write), and >> other hardware channels can be controlled by hardware components if we >> set the hardware config. > > ...if it can be configured to allow other things to use it independently > then this is fine, just needs a bit more documentation so someone can > understand how the bindings and hardware match up. OK. Thanks for your comments. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html