From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99EFBC282CE for ; Tue, 4 Jun 2019 02:33:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73D7D263AF for ; Tue, 4 Jun 2019 02:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t0Tg5fNT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbfFDCdW (ORCPT ); Mon, 3 Jun 2019 22:33:22 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:41013 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfFDCdU (ORCPT ); Mon, 3 Jun 2019 22:33:20 -0400 Received: by mail-oi1-f193.google.com with SMTP id b21so10491562oic.8 for ; Mon, 03 Jun 2019 19:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/efz5fBqwkKql5eaLioEbxPG0lpeX3IuNQzBKE0KZPY=; b=t0Tg5fNTxniTRmz/iZalyXNNLBLd+1rhT2xgBa8LZbek9rqjAlwbOGh00WHUB1ncrx Yo/H4u0aKaaEw1LY3oxY/qG/vRwpEj/gpqna5xGRMKtyhf3tetBrPBVEq5/wW5OunbmT 6P+dBmhIXg4OTMvR81tWx1OWHYVdqp3+mTeW/erFR9g1OpVb3yvcUQDsNFS7/xBbe2Ix 099d7LnpWWUcDprl9p4V7TN5UkrBzPDwAaJK9fx2m9ZdntdbcTThl4RrqZGvB8aLAESR 7H5CqQB/OZL7Y8tzXpk5gqxdRBj4CkDWX7h78XUi9vUABQ5ElROPygSMfDoZJKEFAcyt 5New== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/efz5fBqwkKql5eaLioEbxPG0lpeX3IuNQzBKE0KZPY=; b=V/SQJHjAJioH+W/dXtPeHFN0+XfCygyuce+9NRDifW5alXNGZCyCY6r/hO0AIJIZxj +5lQx8jDrmIF5pCmFhivhUr/MseiszT67uN5UEY8UXDYV9zmMaMcM1lpNS3G9M/OP4NN bjJz3Tom1URS6IqZNKv1TrSIueCVZ+tBYhlrQ5VQAjEx2SdmjwnNG3oq5KESLZMbO2fD tjTVaekzSrAytDwMGIn0v1+Gs7JnjX9DeAkVqbgjseULyZ6nWUgjzSoxVOD9997Zo7Z+ 72OhW6K68JmUA/fE0ellQEuEZhdeREuSezO24otEeq5/8lA4jsoxYG0jcaWXIuLRPPfZ K4Uw== X-Gm-Message-State: APjAAAXZCccv0bshWiyekPWISFJ7E5290AwyV4F/d0F48J1Y7IO/f0MQ 8i58FX4zrfiQmzJYltjpRf4YJFSrmw0afrzyN/11zA== X-Google-Smtp-Source: APXvYqxb/i7+n5YIjVsNZWPZfvdm7xM+4h6bvKEOeA1ig/CQVGfW4rtKxXeB0d4+sPhSP0CMWDZvMBprzf2J8CSGkSs= X-Received: by 2002:aca:dd08:: with SMTP id u8mr74850oig.27.1559615599920; Mon, 03 Jun 2019 19:33:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Baolin Wang Date: Tue, 4 Jun 2019 10:33:08 +0800 Message-ID: Subject: Re: [PATCH 2/9] dt-bindings: mmc: sprd: Add another optional clock documentation To: Ulf Hansson Cc: Adrian Hunter , Chunyan Zhang , Orson Zhai , Rob Herring , Mark Rutland , Arnd Bergmann , Olof Johansson , Vincent Guittot , arm-soc , Linux ARM , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , DTML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf, On Mon, 3 Jun 2019 at 21:34, Ulf Hansson wrote: > > On Mon, 20 May 2019 at 12:12, Baolin Wang wrote: > > > > For some Spreadtrum platforms like SC9860 platform, we should enable another > > gate clock '2x_enable' to make the SD host controller work well. Thus add > > documentation for this optional clock. > > > > Signed-off-by: Baolin Wang > > --- > > .../devicetree/bindings/mmc/sdhci-sprd.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > index 45c9978..a285c77 100644 > > --- a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > +++ b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > @@ -14,6 +14,7 @@ Required properties: > > - clock-names: Should contain the following: > > "sdio" - SDIO source clock (required) > > "enable" - gate clock which used for enabling/disabling the device (required) > > + "2x_enable" - gate clock controlling the device for some special platforms (optional) > > This is a bit vague, could you please elaborate (and fold in that > information to the doc) on what kind of clock this is? Sorry for confusing. For some Spreadtrum platfroms like SC9860 platform, we should enable 2 gate clocks to enable SD host controller, that means we have 2 serialized clock gates. I know that's a little weird, but that's our clock's design. -- Baolin Wang Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5FE5C04AB5 for ; Tue, 4 Jun 2019 02:33:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BC1E263AD for ; Tue, 4 Jun 2019 02:33:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sMv0dQyN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t0Tg5fNT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BC1E263AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jgm1aRhBcFfbfNxe6z6K+zJ9A6n6Cf5EQvCNO+PFw2Q=; b=sMv0dQyNaoS+kK U16r/B3thVeWr/E0HvycFkkyucLAnF9EZ+Ig74PLSeNOnkaCdpKukmzS8/hqVMS2+o92cRTkfUZQm si+fzPqQIoOl/WJRlaNmu5FudBiJE7xfkTysFZ42Yw0G7tXA1SNNjREZnSBcCwIFpDs1XZtt0bMhr GrrJvnSHMFJsm/isK+xxKI3yWP0nUD9HLPkF8qkiKo2l85E3tSbIpOfW5pvMxePWMDEU+1OnefnDu zHFD+Xkqj4W+xr35apUXoVoY5JFP1sNPyEeUIick21VSQYcN6A14QFPWnnveo7Z6sKyBuc0vWaC32 hL9719OYIql4M26BHjZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXzGX-0002DD-Kb; Tue, 04 Jun 2019 02:33:33 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXzGK-000205-JN for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 02:33:23 +0000 Received: by mail-oi1-x241.google.com with SMTP id q186so14468816oia.0 for ; Mon, 03 Jun 2019 19:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/efz5fBqwkKql5eaLioEbxPG0lpeX3IuNQzBKE0KZPY=; b=t0Tg5fNTxniTRmz/iZalyXNNLBLd+1rhT2xgBa8LZbek9rqjAlwbOGh00WHUB1ncrx Yo/H4u0aKaaEw1LY3oxY/qG/vRwpEj/gpqna5xGRMKtyhf3tetBrPBVEq5/wW5OunbmT 6P+dBmhIXg4OTMvR81tWx1OWHYVdqp3+mTeW/erFR9g1OpVb3yvcUQDsNFS7/xBbe2Ix 099d7LnpWWUcDprl9p4V7TN5UkrBzPDwAaJK9fx2m9ZdntdbcTThl4RrqZGvB8aLAESR 7H5CqQB/OZL7Y8tzXpk5gqxdRBj4CkDWX7h78XUi9vUABQ5ElROPygSMfDoZJKEFAcyt 5New== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/efz5fBqwkKql5eaLioEbxPG0lpeX3IuNQzBKE0KZPY=; b=iDLv31E1mnJVFEHLAGmD+aYsUM6vVKj7nvQT43Fv6pZrvgnnKtHGJFtGoIpuTqS8Ik LCQ/+M2UCj93LgHYIvhLIlzwpXNRkwq7URhzVFDO1fmdP67I3Z/dpv100WLDIdo4Xd30 wG7MtKaF6jdHtuomgyI/IzyP4r1Ood2t0tIOUJWwyD2V+33MA8JgDd8eh0uGGX7zn17A p/kO3TjB+ImFU4N5QCBqlVEY6l6BBjD7QJtWKwkD/6HskI2Usm94aPP+yqTW6rETnEYl jAPhBlAwsqUdNqUmlxhMEaHTaQumXpEP/HLDj8kiAhBLSsgxyjvTEQ/x2Av5AtuIYDtX H1Ug== X-Gm-Message-State: APjAAAVGKfoMAnO39rAwN8rBypfZARbQnM0dZp+JQ1I81gnAcngMkJGY bOGHZfkoHl3LoCsgzQ3GkBmGN0+kYeSbvZm6Y7FIaA== X-Google-Smtp-Source: APXvYqxb/i7+n5YIjVsNZWPZfvdm7xM+4h6bvKEOeA1ig/CQVGfW4rtKxXeB0d4+sPhSP0CMWDZvMBprzf2J8CSGkSs= X-Received: by 2002:aca:dd08:: with SMTP id u8mr74850oig.27.1559615599920; Mon, 03 Jun 2019 19:33:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Baolin Wang Date: Tue, 4 Jun 2019 10:33:08 +0800 Message-ID: Subject: Re: [PATCH 2/9] dt-bindings: mmc: sprd: Add another optional clock documentation To: Ulf Hansson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_193320_729440_D5DA6735 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , arm-soc , Arnd Bergmann , Chunyan Zhang , "linux-mmc@vger.kernel.org" , Adrian Hunter , Linux Kernel Mailing List , Rob Herring , Olof Johansson , Orson Zhai , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, On Mon, 3 Jun 2019 at 21:34, Ulf Hansson wrote: > > On Mon, 20 May 2019 at 12:12, Baolin Wang wrote: > > > > For some Spreadtrum platforms like SC9860 platform, we should enable another > > gate clock '2x_enable' to make the SD host controller work well. Thus add > > documentation for this optional clock. > > > > Signed-off-by: Baolin Wang > > --- > > .../devicetree/bindings/mmc/sdhci-sprd.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > index 45c9978..a285c77 100644 > > --- a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > +++ b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > @@ -14,6 +14,7 @@ Required properties: > > - clock-names: Should contain the following: > > "sdio" - SDIO source clock (required) > > "enable" - gate clock which used for enabling/disabling the device (required) > > + "2x_enable" - gate clock controlling the device for some special platforms (optional) > > This is a bit vague, could you please elaborate (and fold in that > information to the doc) on what kind of clock this is? Sorry for confusing. For some Spreadtrum platfroms like SC9860 platform, we should enable 2 gate clocks to enable SD host controller, that means we have 2 serialized clock gates. I know that's a little weird, but that's our clock's design. -- Baolin Wang Best Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel