From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751478AbdJWCBO (ORCPT <rfc822;w@1wt.eu>);
        Sun, 22 Oct 2017 22:01:14 -0400
Received: from mail-oi0-f66.google.com ([209.85.218.66]:55360 "EHLO
        mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751019AbdJWCBM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 22 Oct 2017 22:01:12 -0400
X-Google-Smtp-Source: ABhQp+SQ8jK5DTZA8kdGoMt3B7wgK84Fysc2FTDWS8/AQWY0AsD2XBajTd+fSXz+7SN07WETsKTBOuYV2Bgoc2dXjBw=
MIME-Version: 1.0
In-Reply-To: <6c3036ce14d776452bd8526c0ea9541880a43541.1507612144.git.baolin.wang@spreadtrum.com>
References: <84d9f80ce9853ae8441ef91e8701ba516db8f697.1507612144.git.baolin.wang@spreadtrum.com>
 <6c3036ce14d776452bd8526c0ea9541880a43541.1507612144.git.baolin.wang@spreadtrum.com>
From: Baolin Wang <baolin.wang@linaro.org>
Date: Mon, 23 Oct 2017 10:01:11 +0800
Message-ID: <CAMz4kuKTWz86rv1WsGNxcssfK_7uHxw0=XwcqFZEFM=vo0nuQg@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] dma: sprd: Add Spreadtrum DMA driver
To: Baolin Wang <baolin.wang@spreadtrum.com>
Cc: Vinod Koul <vinod.koul@intel.com>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vinod,

On 10 October 2017 at 13:23, Baolin Wang <baolin.wang@spreadtrum.com> wrote:
> This patch adds the DMA controller driver for Spreadtrum SC9860 platform.
>
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
> Changes since v3:
>  - Remove redundant local 'mask' and 'val' variables.
>  - Simplify sprd_dma_get_req_type() function.
>  - Change pm_runtime_put_sync() to pm_runtime_put() in probe function.
>  - Simplify sizeof function.
>  - Other coding style fixes.
>
> Changes since v2:
>  - Add COMPILE_TEST as dependency.
>  - Renamed DMA macro definition properly.
>  - Add sprd_dma_chn_update() helpers to save lots of code.
>  - Change pm_runtime_put_sync() to pm_runtime_put() when free resources.
>  - Re-implement the sprd_dma_tx_status() function.
>  - Free irq and kill tasklet when remove driver.
>  - Add some documentaion.
>  - Change to module_init() level and add MODULE_ALIAS().
>  - Other coding style fixes.
>
> Changes since v1:
>  - Use virt-dma to manage dma descriptors.
>  - Remove link-list and channel-start-channel Spreadtrum special features.
>  - Remove device_config implementation.
>  - Other optimization.
>
> Note: This patch just implemented the basic DMA_MEMCPY function, and in
> future we will send new patches to introduce some Speadtrum special features,
> that will be talk about how to handle these features easily instead of in one
> big patch which is hard to review.
> ---

Do you have any comments for this version patchset? If not, could you
apply this patchset into your branch? Thanks.

-- 
Baolin.wang
Best Regards