From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F01C04AB5 for ; Tue, 4 Jun 2019 02:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99A5126368 for ; Tue, 4 Jun 2019 02:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ji0kqvdj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbfFDCSv (ORCPT ); Mon, 3 Jun 2019 22:18:51 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:41345 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbfFDCSv (ORCPT ); Mon, 3 Jun 2019 22:18:51 -0400 Received: by mail-ot1-f68.google.com with SMTP id 107so12268619otj.8 for ; Mon, 03 Jun 2019 19:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1l+D3rSEai4qzn+TyHSQz7IIWfxK6zl3YHxlBM75Sxk=; b=ji0kqvdjzqwIUAMrKo44/NCdPxG7kCOt7Hn0ZEmNeX4IylO3gLu2LJSi/pElY7IIbM HN5nagHzCYI8L27LLselXWAYkf6bFKXGIxq2Vctezw/AB8zsC8WOydU92z/XH/2aoK2A yh2lvRhAVbV8FPmdWiyypeA6uHZAXIx5pvFi+Ct0Kh7I0FAf64XN2E/BwPIBb0bcHdSX 0Gta6gcFmqEcmnp9kCfe3nLwyWf+SbQ1Nw+DlL57VPLsJeN/JiL8rhTgp1JmmBtAQZsF I1fiAFO0iWTIN38nBkT3M8I9T/Fupjok5DxcRbIXHTx7RIXemRNu1Cdirlm7sqCCiuyq CTFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1l+D3rSEai4qzn+TyHSQz7IIWfxK6zl3YHxlBM75Sxk=; b=F+zbp4SWcdJjg7HpOeJn1Kz39wqmeOg1ppZhFoWasLvioOF9YENuMHB0qTaf3jWfrB Vr+TGN+rT65qqmT+ZrW4U3piv5ifVjJMO8zcZgXmn8RiZyDR+JlvGTUXqUjnXUNOoC7t mQqBOffBDMGaLr4MeVdjp/jSRyBHk4gf3NpesRfAFSjXK8FK50Gbxdd6YfrLi56U4YTz PNgki6CS2+eOB07TMq+VECJsmapIhRcRwD68SMPLUJhxxMWvnvl7dsr7+BlUUXNEh26Y 2oZbgeSjaujj1IgJDr+41VQ6p0JV04cej0B8gxTTsBP+5BJz3elyWmGRS7OkIPkhR4WE hwwQ== X-Gm-Message-State: APjAAAV44hsHlBZninsaQFwq8wAVr/iyUa8NfmHaC0MEsalby43mLnzV YAXqgficsg/FpuKjL7AwPcFcLqVPrQVfZKu4fFq4iw== X-Google-Smtp-Source: APXvYqyRqFO8DnlUxTuulaeN51Ccoi/wNUL1xOjgvaLRhN641y5Hw/UsspKPB9nl9NukmCmvcMaNWtuiBw6YLY/JcLo= X-Received: by 2002:a9d:10c:: with SMTP id 12mr3560362otu.123.1559614730649; Mon, 03 Jun 2019 19:18:50 -0700 (PDT) MIME-Version: 1.0 References: <6b539c8b-c2fd-6c37-d645-ef714c0e29c9@intel.com> In-Reply-To: <6b539c8b-c2fd-6c37-d645-ef714c0e29c9@intel.com> From: Baolin Wang Date: Tue, 4 Jun 2019 10:18:39 +0800 Message-ID: Subject: Re: [PATCH 8/9] mmc: sdhci-sprd: Add PHY DLL delay configuration To: Adrian Hunter Cc: Ulf Hansson , Chunyan Zhang , Orson Zhai , Rob Herring , Mark Rutland , Arnd Bergmann , Olof Johansson , Vincent Guittot , arm-soc , Linux ARM , linux-mmc , LKML , DTML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adrian, On Mon, 3 Jun 2019 at 21:03, Adrian Hunter wrote: > > On 20/05/19 1:12 PM, Baolin Wang wrote: > > Set the PHY DLL delay for each timing mode, which is used to sample the clock > > accurately and make the clock more stable. > > > > Signed-off-by: Baolin Wang > > One comment, nevertheless: > > Acked-by: Adrian Hunter > > > --- > > drivers/mmc/host/sdhci-sprd.c | 51 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c > > index e6eda13..911a09b 100644 > > --- a/drivers/mmc/host/sdhci-sprd.c > > +++ b/drivers/mmc/host/sdhci-sprd.c > > @@ -29,6 +29,8 @@ > > #define SDHCI_SPRD_DLL_INIT_COUNT 0xc00 > > #define SDHCI_SPRD_DLL_PHASE_INTERNAL 0x3 > > > > +#define SDHCI_SPRD_REG_32_DLL_DLY 0x204 > > + > > #define SDHCI_SPRD_REG_32_DLL_DLY_OFFSET 0x208 > > #define SDHCIBSPRD_IT_WR_DLY_INV BIT(5) > > #define SDHCI_SPRD_BIT_CMD_DLY_INV BIT(13) > > @@ -72,6 +74,24 @@ struct sdhci_sprd_host { > > struct clk *clk_2x_enable; > > u32 base_rate; > > int flags; /* backup of host attribute */ > > + u32 phy_delay[MMC_TIMING_MMC_HS400 + 2]; > > +}; > > + > > +struct sdhci_sprd_phy_cfg { > > + const char *property; > > + u8 timing; > > +}; > > + > > +static const struct sdhci_sprd_phy_cfg sdhci_sprd_phy_cfgs[] = { > > + { "sprd,phy-delay-legacy", MMC_TIMING_LEGACY, }, > > + { "sprd,phy-delay-sd-highspeed", MMC_TIMING_MMC_HS, }, > > Did you mean MMC_TIMING_SD_HS Ah, yes, my copy mistake and will fix it in next version. Thanks for your reviewing and comments. -- Baolin Wang Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CB1C04AB5 for ; Tue, 4 Jun 2019 02:19:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5885F26368 for ; Tue, 4 Jun 2019 02:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gzFxCMR7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ji0kqvdj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5885F26368 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5aF0jVKuQjnAym4IcZvf+FQotXOR9VMxN744dAeoQuI=; b=gzFxCMR7RxSMrG vwP5PJqEzv0mXvmItrUNM8kQboyr9YBoTIrp+EmqLEanoWSHn4YcFcsuHlCYC8vjPvl50ZH2BELzE piQuJOYpFplBlos4U4fzKavVspL9JsIj0sMTzQ/c24hgD80bQzRIxmUf8EUSlZNfa9vka1jizdk4W qxAmkor0gMOZ4jcOX46q0+5gJFSO6pX2ClEgETG5ANhdSl3zOKEXspRINdwVqjNp42y119x97SiRF Z3SlPMDl0H+i3HdYMhPCCuVCH8/OBn1K9i/saMINxIABC56a3AcSfmAmPmIV8q0Ut+Pl/ehyFxyYJ XDi1EXu5soP1DMHld/xQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXz2O-0004oT-Jd; Tue, 04 Jun 2019 02:18:56 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXz2K-0004ng-Si for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 02:18:54 +0000 Received: by mail-ot1-x343.google.com with SMTP id i8so18050212oth.10 for ; Mon, 03 Jun 2019 19:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1l+D3rSEai4qzn+TyHSQz7IIWfxK6zl3YHxlBM75Sxk=; b=ji0kqvdjzqwIUAMrKo44/NCdPxG7kCOt7Hn0ZEmNeX4IylO3gLu2LJSi/pElY7IIbM HN5nagHzCYI8L27LLselXWAYkf6bFKXGIxq2Vctezw/AB8zsC8WOydU92z/XH/2aoK2A yh2lvRhAVbV8FPmdWiyypeA6uHZAXIx5pvFi+Ct0Kh7I0FAf64XN2E/BwPIBb0bcHdSX 0Gta6gcFmqEcmnp9kCfe3nLwyWf+SbQ1Nw+DlL57VPLsJeN/JiL8rhTgp1JmmBtAQZsF I1fiAFO0iWTIN38nBkT3M8I9T/Fupjok5DxcRbIXHTx7RIXemRNu1Cdirlm7sqCCiuyq CTFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1l+D3rSEai4qzn+TyHSQz7IIWfxK6zl3YHxlBM75Sxk=; b=jNc7JB0j2RwVEESv1G6mJhLHQgvSDznFvUuk5hDqrI6mMhcRBah6iVrs27+x/0LISN PWRcophrvr4BMHQkzb6UUrMOxUuxq5cf+ktREOFKatBmJOfdo9qibzAGCz6mmmGZf2cS 8c37Y+3ozmWRCEcj4dcBz89a1ZhMauNxN3vgFQ3Ntnnucuhl7+6NNA6XJqYAhJzELKmV YE/0GBTN7CwZMrSpLyJcwn6gPXGfEDOF80uQCAtt0/asxUFCaM1LdLa5GIBqVfSg1PJz vFDjsRRlitE1yEFlOexzGi+Bcycx7lSdnny50eZJVfXBemCWGCPqAWEplfuWx8dFk6mX okmQ== X-Gm-Message-State: APjAAAVX1KanpkJcBDZD8DLtbLdfOrKpWtCBpWonJGfn+m1cm4cAIPJI VhyOFupQC/6S0YxBW1iP+UWm4YR2j5PNSqN2ZvPhpw== X-Google-Smtp-Source: APXvYqyRqFO8DnlUxTuulaeN51Ccoi/wNUL1xOjgvaLRhN641y5Hw/UsspKPB9nl9NukmCmvcMaNWtuiBw6YLY/JcLo= X-Received: by 2002:a9d:10c:: with SMTP id 12mr3560362otu.123.1559614730649; Mon, 03 Jun 2019 19:18:50 -0700 (PDT) MIME-Version: 1.0 References: <6b539c8b-c2fd-6c37-d645-ef714c0e29c9@intel.com> In-Reply-To: <6b539c8b-c2fd-6c37-d645-ef714c0e29c9@intel.com> From: Baolin Wang Date: Tue, 4 Jun 2019 10:18:39 +0800 Message-ID: Subject: Re: [PATCH 8/9] mmc: sdhci-sprd: Add PHY DLL delay configuration To: Adrian Hunter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_191852_940301_63FEFF6A X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Ulf Hansson , arm-soc , Arnd Bergmann , Chunyan Zhang , linux-mmc , LKML , Rob Herring , Olof Johansson , Orson Zhai , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrian, On Mon, 3 Jun 2019 at 21:03, Adrian Hunter wrote: > > On 20/05/19 1:12 PM, Baolin Wang wrote: > > Set the PHY DLL delay for each timing mode, which is used to sample the clock > > accurately and make the clock more stable. > > > > Signed-off-by: Baolin Wang > > One comment, nevertheless: > > Acked-by: Adrian Hunter > > > --- > > drivers/mmc/host/sdhci-sprd.c | 51 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c > > index e6eda13..911a09b 100644 > > --- a/drivers/mmc/host/sdhci-sprd.c > > +++ b/drivers/mmc/host/sdhci-sprd.c > > @@ -29,6 +29,8 @@ > > #define SDHCI_SPRD_DLL_INIT_COUNT 0xc00 > > #define SDHCI_SPRD_DLL_PHASE_INTERNAL 0x3 > > > > +#define SDHCI_SPRD_REG_32_DLL_DLY 0x204 > > + > > #define SDHCI_SPRD_REG_32_DLL_DLY_OFFSET 0x208 > > #define SDHCIBSPRD_IT_WR_DLY_INV BIT(5) > > #define SDHCI_SPRD_BIT_CMD_DLY_INV BIT(13) > > @@ -72,6 +74,24 @@ struct sdhci_sprd_host { > > struct clk *clk_2x_enable; > > u32 base_rate; > > int flags; /* backup of host attribute */ > > + u32 phy_delay[MMC_TIMING_MMC_HS400 + 2]; > > +}; > > + > > +struct sdhci_sprd_phy_cfg { > > + const char *property; > > + u8 timing; > > +}; > > + > > +static const struct sdhci_sprd_phy_cfg sdhci_sprd_phy_cfgs[] = { > > + { "sprd,phy-delay-legacy", MMC_TIMING_LEGACY, }, > > + { "sprd,phy-delay-sd-highspeed", MMC_TIMING_MMC_HS, }, > > Did you mean MMC_TIMING_SD_HS Ah, yes, my copy mistake and will fix it in next version. Thanks for your reviewing and comments. -- Baolin Wang Best Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel