From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752931AbcKUJCV (ORCPT ); Mon, 21 Nov 2016 04:02:21 -0500 Received: from mail-yw0-f178.google.com ([209.85.161.178]:35206 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbcKUJCT (ORCPT ); Mon, 21 Nov 2016 04:02:19 -0500 MIME-Version: 1.0 In-Reply-To: References: <1479531014-25264-1-git-send-email-john.stultz@linaro.org> <1479531014-25264-2-git-send-email-john.stultz@linaro.org> <20161121081301.GA14231@gmail.com> From: Baolin Wang Date: Mon, 21 Nov 2016 17:02:18 +0800 Message-ID: Subject: Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer To: Thomas Gleixner Cc: Ingo Molnar , John Stultz , lkml , Richard Cochran , Steven Rostedt Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 November 2016 at 16:56, Thomas Gleixner wrote: > On Mon, 21 Nov 2016, Baolin Wang wrote: >> On 21 November 2016 at 16:13, Ingo Molnar wrote: >> > Hm, there's a weirdness here: if freezer_delta != 0 when alarmtimer_suspend() is >> > called then type might be '0', although it's not alarm_bases[0] this value is >> > picked up from. >> > >> > Wouldn't it be better to initialize 'type' to -1 instead? (And rename it to >> > min_type or so.) >> >> Make sense. I will send out new patch to fix this. Thanks for your comments. > > Can you please fix the subject line while at it? 'trcepoints' does not look right Sorry for mistake, I will fix that. Thanks. -- Baolin.wang Best Regards