From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbeDZIlX (ORCPT ); Thu, 26 Apr 2018 04:41:23 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:44826 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754663AbeDZIlP (ORCPT ); Thu, 26 Apr 2018 04:41:15 -0400 X-Google-Smtp-Source: AB8JxZrI/r5mM7z4RIQm1u46n/mI8vZZFGhjvhlI0gyE21bCBixIuR3qSdJcLkGvUSESzv0Qu4LtzEcpxdZsydearZA= MIME-Version: 1.0 In-Reply-To: References: <7373ade7cb5a8d6a5fca07e78cf992ba7372bd7f.1524570852.git.baolin.wang@linaro.org> <201804261345.1lsWsCDl%fengguang.wu@intel.com> From: Baolin Wang Date: Thu, 26 Apr 2018 16:41:14 +0800 Message-ID: Subject: Re: [PATCH 1/8] ALSA: Replace timespec with timespec64 To: Arnd Bergmann Cc: kbuild test robot , kbuild-all@01.org, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Takashi Sakamoto , Ingo Molnar , SF Markus Elfring , Dan Carpenter , jeeja.kp@intel.com, Vinod Koul , Guneshwor Singh , subhransu.s.prusty@intel.com, Bhumika Goyal , gudishax.kranthikumar@intel.com, Naveen M , hardik.t.shah@intel.com, Arvind Yadav , Fabian Frederick , alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26 April 2018 at 16:30, Arnd Bergmann wrote: > On Thu, Apr 26, 2018 at 10:15 AM, kbuild test robot wrote: >> Hi Baolin, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on v4.17-rc2] >> [also build test ERROR on next-20180424] >> [cannot apply to sound/for-next asoc/for-next arm-soc/for-next] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Fix-year-2038-issue-for-sound-subsystem/20180426-010145 >> config: sh-ecovec24_defconfig (attached as .config) >> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 >> reproduce: >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> make.cross ARCH=sh >> >> Note: the linux-review/Baolin-Wang/Fix-year-2038-issue-for-sound-subsystem/20180426-010145 HEAD 53cdcc389f07bdd923be240cdb746a97de063301 builds fine. >> It only hurts bisectibility. >> >> All errors (new ones prefixed by >>): >> >> sound/core/pcm_lib.c: In function 'update_audio_tstamp': >>>> sound/core/pcm_lib.c:256:54: error: passing argument 2 of 'timespec_equal' from incompatible pointer type [-Werror=incompatible-pointer-types] >> if (!timespec_equal(&runtime->status->audio_tstamp, audio_tstamp)) { >> ^~~~~~~~~~~~ > > > Probably a mistake during rebasing: patch 8/8 fixes this, but it should be done > right here by moving the open-coded comparison into the first patch: > > - if (!timespec_equal(&runtime->status->audio_tstamp, audio_tstamp)) { > + if (runtime->status->audio_tstamp.tv_sec != audio_tstamp->tv_sec || > + runtime->status->audio_tstamp.tv_nsec != audio_tstamp->tv_nsec) { > Sorry, it's my mistake. Yes, I can fix this issue like what you showed. -- Baolin.wang Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baolin Wang Subject: Re: [PATCH 1/8] ALSA: Replace timespec with timespec64 Date: Thu, 26 Apr 2018 16:41:14 +0800 Message-ID: References: <7373ade7cb5a8d6a5fca07e78cf992ba7372bd7f.1524570852.git.baolin.wang@linaro.org> <201804261345.1lsWsCDl%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by alsa0.perex.cz (Postfix) with ESMTP id 0EA1326722C for ; Thu, 26 Apr 2018 10:41:15 +0200 (CEST) Received: by mail-oi0-f66.google.com with SMTP id f63-v6so23402153oic.4 for ; Thu, 26 Apr 2018 01:41:15 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Arnd Bergmann Cc: alsa-devel@alsa-project.org, Liam Girdwood , jeeja.kp@intel.com, SF Markus Elfring , kbuild test robot , Vinod Koul , Takashi Iwai , Guneshwor Singh , Ingo Molnar , gudishax.kranthikumar@intel.com, Arvind Yadav , subhransu.s.prusty@intel.com, Dan Carpenter , hardik.t.shah@intel.com, Fabian Frederick , Mark Brown , Naveen M , Linux Kernel Mailing List , Takashi Sakamoto , kbuild-all@01.org, Bhumika Goyal List-Id: alsa-devel@alsa-project.org On 26 April 2018 at 16:30, Arnd Bergmann wrote: > On Thu, Apr 26, 2018 at 10:15 AM, kbuild test robot wrote: >> Hi Baolin, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on v4.17-rc2] >> [also build test ERROR on next-20180424] >> [cannot apply to sound/for-next asoc/for-next arm-soc/for-next] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Fix-year-2038-issue-for-sound-subsystem/20180426-010145 >> config: sh-ecovec24_defconfig (attached as .config) >> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 >> reproduce: >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> make.cross ARCH=sh >> >> Note: the linux-review/Baolin-Wang/Fix-year-2038-issue-for-sound-subsystem/20180426-010145 HEAD 53cdcc389f07bdd923be240cdb746a97de063301 builds fine. >> It only hurts bisectibility. >> >> All errors (new ones prefixed by >>): >> >> sound/core/pcm_lib.c: In function 'update_audio_tstamp': >>>> sound/core/pcm_lib.c:256:54: error: passing argument 2 of 'timespec_equal' from incompatible pointer type [-Werror=incompatible-pointer-types] >> if (!timespec_equal(&runtime->status->audio_tstamp, audio_tstamp)) { >> ^~~~~~~~~~~~ > > > Probably a mistake during rebasing: patch 8/8 fixes this, but it should be done > right here by moving the open-coded comparison into the first patch: > > - if (!timespec_equal(&runtime->status->audio_tstamp, audio_tstamp)) { > + if (runtime->status->audio_tstamp.tv_sec != audio_tstamp->tv_sec || > + runtime->status->audio_tstamp.tv_nsec != audio_tstamp->tv_nsec) { > Sorry, it's my mistake. Yes, I can fix this issue like what you showed. -- Baolin.wang Best Regards