From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbdIGDND (ORCPT ); Wed, 6 Sep 2017 23:13:03 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:36263 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbdIGDNB (ORCPT ); Wed, 6 Sep 2017 23:13:01 -0400 X-Google-Smtp-Source: ADKCNb6xJagY+HsLu4G2XHYZcTSEPsl6PU/x1XrudGPwNawKDXmUBd/DxdaryvXlGnmFsMfpXIdXzp47SCFhVP552f0= MIME-Version: 1.0 In-Reply-To: <20170906150446.v7qqc24wxeykcwwk@sirena.co.uk> References: <20170906150446.v7qqc24wxeykcwwk@sirena.co.uk> From: Baolin Wang Date: Thu, 7 Sep 2017 11:13:00 +0800 Message-ID: Subject: Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform To: Mark Brown Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 6 September 2017 at 23:04, Mark Brown wrote: > On Wed, Sep 06, 2017 at 02:10:44PM +0800, Baolin Wang wrote: > > This looks like a nice, clean driver. A few fairly small issues though: > >> +config SPI_SPRD_ADI >> + tristate "Spreadtrum ADI controller" >> + depends on ARCH_SPRD >> + help >> + ADI driver based on SPI for Spreadtrum SoCs. >> + > > I can't see any hard dependencies on the architecture - can you add an > || COMPILE_TEST for more coverage? Yes. > >> + ret = devm_spi_register_controller(&pdev->dev, ctlr); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to register SPI controller\n"); >> + goto free_hwlock; >> + } > >> + spi_controller_put(ctlr); > > You used devm_ to register the controller, no need to free it > explicitly. Indeed. > >> +static int __init sprd_adi_init(void) >> +{ >> + return platform_driver_register(&sprd_adi_driver); >> +} >> +subsys_initcall(sprd_adi_init); > > Why is this subsys_initcall() and not module_platform_driver()? Since ADI is one very fundamental driver for our SoC, many drivers such as regulator need depend on ADI, and regulator need to regulate core voltage as earlier as possible. Very appreciated for your comments. -- Baolin.wang Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baolin Wang Subject: Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Date: Thu, 7 Sep 2017 11:13:00 +0800 Message-ID: References: <20170906150446.v7qqc24wxeykcwwk@sirena.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170906150446.v7qqc24wxeykcwwk-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML List-Id: devicetree@vger.kernel.org Hi Mark, On 6 September 2017 at 23:04, Mark Brown wrote: > On Wed, Sep 06, 2017 at 02:10:44PM +0800, Baolin Wang wrote: > > This looks like a nice, clean driver. A few fairly small issues though: > >> +config SPI_SPRD_ADI >> + tristate "Spreadtrum ADI controller" >> + depends on ARCH_SPRD >> + help >> + ADI driver based on SPI for Spreadtrum SoCs. >> + > > I can't see any hard dependencies on the architecture - can you add an > || COMPILE_TEST for more coverage? Yes. > >> + ret = devm_spi_register_controller(&pdev->dev, ctlr); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to register SPI controller\n"); >> + goto free_hwlock; >> + } > >> + spi_controller_put(ctlr); > > You used devm_ to register the controller, no need to free it > explicitly. Indeed. > >> +static int __init sprd_adi_init(void) >> +{ >> + return platform_driver_register(&sprd_adi_driver); >> +} >> +subsys_initcall(sprd_adi_init); > > Why is this subsys_initcall() and not module_platform_driver()? Since ADI is one very fundamental driver for our SoC, many drivers such as regulator need depend on ADI, and regulator need to regulate core voltage as earlier as possible. Very appreciated for your comments. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html