From: Brian Gerst <brgerst@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@redhat.com>, Peter Anvin <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>
Subject: Re: Q: does force_iret() make any sense today?
Date: Wed, 18 Dec 2019 10:45:07 -0500 [thread overview]
Message-ID: <CAMzpN2gOA=ysOCidCUmxZ6cev5HuKXPdBA_mni5SR01=ii-+KQ@mail.gmail.com> (raw)
In-Reply-To: <20191218153107.GA3489@redhat.com>
On Wed, Dec 18, 2019 at 10:31 AM Oleg Nesterov <oleg@redhat.com> wrote:
>
> I do not pretend I understand the arch/x86/entry/ code, but it seems that
> asm does all the necessary checks and the "extra" TIF_NOTIFY_RESUME simply
> has no effect except tracehook_notify_resume() will be called for no reason?
It's a relic of a time before the more robust checks for
SYSRET/SYSEXIT were added. The idea was to divert the syscall return
flow off the fast path. Even if no exit work was done, the slow path
always returned with IRET. But with all the entry rework that has
been done it is no longer needed and can be removed.
--
Brian Gerst
next prev parent reply other threads:[~2019-12-18 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 15:31 Q: does force_iret() make any sense today? Oleg Nesterov
2019-12-18 15:45 ` Brian Gerst [this message]
2019-12-18 16:06 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMzpN2gOA=ysOCidCUmxZ6cev5HuKXPdBA_mni5SR01=ii-+KQ@mail.gmail.com' \
--to=brgerst@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.