From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753376AbbDBPBi (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Apr 2015 11:01:38 -0400
Received: from mail-wg0-f46.google.com ([74.125.82.46]:35594 "EHLO
	mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752666AbbDBPBf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Apr 2015 11:01:35 -0400
MIME-Version: 1.0
In-Reply-To: <1427985378-4287-3-git-send-email-dvlasenk@redhat.com>
References: <1427985378-4287-1-git-send-email-dvlasenk@redhat.com>
	<1427985378-4287-3-git-send-email-dvlasenk@redhat.com>
Date: Thu, 2 Apr 2015 11:01:34 -0400
Message-ID: <CAMzpN2jEj7FHPSXm=WrxdPU+Eqa3ygq6c5t-=oMK9jTb=fQOyw@mail.gmail.com>
Subject: Re: [PATCH 3/9] x86/asm/entry/64: do not SAVE_EXTRA_REGS in stub_sigreturn
From: Brian Gerst <brgerst@gmail.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 2, 2015 at 10:36 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> stub_sigreturn ignores old values of pt_regs->REG for all general-purpose
> registers, it sets them to values saved on userspace
> signal stack.
>
> Which is hardly surprising - it would be a bug if it would use pt_regs->REG.
> sigreturn must restore all registers.
>
> Therefore, SAVE_EXTRA_REGS in it ought to be redundant.
>
> It is a leftover from the time SAVE_EXTRA_REGS wasn't only saving registers,
> but it also was extending stack to "full" pt_regs.
>
> Delete this SAVE_EXTRA_REGS.
>
> Run-tested.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Linus Torvalds <torvalds@linux-foundation.org>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Ingo Molnar <mingo@kernel.org>
> CC: Borislav Petkov <bp@alien8.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: Andy Lutomirski <luto@amacapital.net>
> CC: Oleg Nesterov <oleg@redhat.com>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Alexei Starovoitov <ast@plumgrid.com>
> CC: Will Drewry <wad@chromium.org>
> CC: Kees Cook <keescook@chromium.org>
> CC: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
>  arch/x86/kernel/entry_64.S | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index ec51598..1cf245d 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -447,7 +447,12 @@ ENTRY(stub_rt_sigreturn)
>         CFI_STARTPROC
>         addq $8, %rsp
>         DEFAULT_FRAME 0
> -       SAVE_EXTRA_REGS
> +       /*
> +        * Despite RESTORE_EXTRA_REGS in return_from_stub,
> +        * no need to SAVE_EXTRA_REGS here:
> +        * sys_rt_sigreturn overwrites all general purpose pt_regs->REGs
> +        * on stack, for RESTORE_{EXTRA,C}_REGS to pick them up.
> +        */
>         call sys_rt_sigreturn
>         jmp  return_from_stub
>         CFI_ENDPROC
> @@ -458,7 +463,7 @@ ENTRY(stub_x32_rt_sigreturn)
>         CFI_STARTPROC
>         addq $8, %rsp
>         DEFAULT_FRAME 0
> -       SAVE_EXTRA_REGS
> +       /* No need to SAVE_EXTRA_REGS */
>         call sys32_x32_rt_sigreturn
>         jmp  return_from_stub
>         CFI_ENDPROC

I had the same idea, but determined sigreturn can fault and return an
error code without modifying all the registers.  This would leak junk
from the stack.

Also, the VDSO doesn't handle this (unlikely under normal
circumstances) case.  It assumes the syscall will not return there and
will go off into the weeds.

--
Brian Gerst