All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olga Kornievskaia <aglo@umich.edu>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: NeilBrown <neilb@suse.com>, linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: NFSv4.1 session reset needs to update ->rsize and ->wsize - how???
Date: Wed, 5 Sep 2018 11:46:27 -0400	[thread overview]
Message-ID: <CAN-5tyEa0cYYiSkwncw=662393N65z=Fy6SyzkiEeo4jkpUnhw@mail.gmail.com> (raw)
In-Reply-To: <f700a6d48218533ed2a3ca3a23c06c9cd40cf3c8.camel@hammerspace.com>

On Wed, Sep 5, 2018 at 11:12 AM Trond Myklebust <trondmy@hammerspace.com> wrote:
>
> On Wed, 2018-09-05 at 09:44 -0400, Olga Kornievskaia wrote:
> > commit 033853325fe3bdc70819a8b97915bd3bca41d3af
> > Author: Olga Kornievskaia <kolga@netapp.com>
> > Date:   Wed Mar 8 14:39:15 2017 -0500
> >
> >     NFSv4.1 respect server's max size in CREATE_SESSION
> >
> >     Currently client doesn't respect max sizes server returns in
> > CREATE_SESSION.
> >     nfs4_session_set_rwsize() gets called and server->rsize, server-
> > >wsize are 0
> >     so they never get set to the sizes returned by the server.
> >
> >     Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> >     Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> >
>
> Olga, I'm confused by that patch. It appears to assume that we should
> be using the CREATE_SESSION, request/response limits as default values
> instead of as limits?
>
> AFAICS, the real problem there is that nfs4_server_common_setup() is
> calling nfs4_session_set_rwsize() before we actually set the r/wsize in
> the call to nfs_probe_fsinfo(). No?

I didn't know that nfs_probe_fsinfo() set the server->r/wsize. I
thought it was only set in nfs4_session_set_rwsize() to the values
from the session attributes.

  reply	other threads:[~2018-09-05 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 22:47 NFSv4.1 session reset needs to update ->rsize and ->wsize - how??? NeilBrown
2018-09-04 23:11 ` Trond Myklebust
2018-09-05  0:02   ` NeilBrown
2018-09-05 13:44     ` Olga Kornievskaia
2018-09-05 15:12       ` Trond Myklebust
2018-09-05 15:46         ` Olga Kornievskaia [this message]
2018-09-05 21:12       ` NeilBrown
2018-09-05 21:56         ` Trond Myklebust
2018-09-05 22:10           ` NeilBrown
2018-09-06 17:03         ` Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN-5tyEa0cYYiSkwncw=662393N65z=Fy6SyzkiEeo4jkpUnhw@mail.gmail.com' \
    --to=aglo@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.