From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7829C04A68 for ; Wed, 27 Jul 2022 18:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231322AbiG0Sy1 (ORCPT ); Wed, 27 Jul 2022 14:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234225AbiG0Sxs (ORCPT ); Wed, 27 Jul 2022 14:53:48 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB096554B for ; Wed, 27 Jul 2022 10:52:13 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id w5so10012129edd.13 for ; Wed, 27 Jul 2022 10:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zOIfVudXpNc79R7vncsX/JaZIbjMR0OtP8NIBeKVUQM=; b=qX3peanr9CUaqTyCyphv7nZHqfoYxyzN89ziEAy1LkVYB15wvmmWOIeo4BOZhILKbB 9TqEMiL4FgeIhZ/jAzkCt2sH6TQiHUKWgjvvrtKiWXr9kMMt9SlrLNeCfl1scgpypRaZ RLC8ApefAFkZgWaGaaLlPVxRMNa7j1ujHqg49OQHonYa1lQJCqBzUUFby5wwy7lU4rfn wCxu74aNn/XUo+3jsatYsfNH3OuwlndZwAlzmFQyucfwhw+gtu459fmCsc0r3wd3fd8e iV9YfyyNUvi/L+r5iGDvKsAzCC04mQ6suHOM6PFVkz2zkC807fAAwtEy/7PO1ELShspq vGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zOIfVudXpNc79R7vncsX/JaZIbjMR0OtP8NIBeKVUQM=; b=MbiEd5Th9GSfqYGD93Dpjf5R/9xTMMAu8jzodizaL2IQ1uk2kglM+iQAqI1RETItzN ErrQBtF0WhNeSmel6HPrgC1SCgWcpEdg0Otei45d4DHsKgdGxx8ha6BiHTO580RPJzMm c3EqxXMJmzFsjS+Z5qZ5ezz02J/LfC8T9C/3k+6oRBA5lyYHih0AQBOo9EFtxbjdn8e9 it0e4EWajvWAlBn9dSVWyBWFE7QXFdVl1yn4IKSA19Nc2dwRx066rma3ngl7H+abtL14 JR7mrFtsETwuruFxRK1TbZs3NWrXDjaFgQbFzOi/8Xcx0cpZFUH+Ds78+4dHQC1SLQ3g yDMw== X-Gm-Message-State: AJIora/nF+EMzdWCuGpQ0t6jKNiur2EdjCxAmPpFqZ02U1s3+Evrhj89 HjD5uHk4WfscUjXGpZuPF4SlbxBFIeSB6q7hdbSRimJqRf0= X-Google-Smtp-Source: AGRyM1sWoE6hku526anMFoIxgoLLVFDAJVI5Stjg9K2AkgfVzNp0QukwZ3HfcKrfP/p6Be7QSJRYFdKWtN5cQpKd21M= X-Received: by 2002:a05:6402:1d8f:b0:43c:97c0:b8cc with SMTP id dk15-20020a0564021d8f00b0043c97c0b8ccmr5379474edb.163.1658944331851; Wed, 27 Jul 2022 10:52:11 -0700 (PDT) MIME-Version: 1.0 References: <165852076926.11403.44005570813790008.stgit@manet.1015granger.net> <4F2D66E7-2D88-4A29-9115-B6F6D292F195@oracle.com> In-Reply-To: <4F2D66E7-2D88-4A29-9115-B6F6D292F195@oracle.com> From: Olga Kornievskaia Date: Wed, 27 Jul 2022 13:52:00 -0400 Message-ID: Subject: Re: [PATCH v1 00/11] Put struct nfsd4_copy on a diet To: Chuck Lever III Cc: Linux NFS Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org After applying Dai's patch I got further... I hit the next panic (below)... before that it ran into a failure for "inter01" failed with ECOMM. On hte trace, after the COPY is places the server returns ESTALE in CB_OFFLOAD, then close is failed with BAD_SESSION (just basically something really wrong happened on the server)... After failing a new more tests in the similar fashion.. On cleanup the oops happens. [ 842.455939] list_del corruption. prev->next should be ffff9aaa8b5f0c78, but was ffff9aaab2713508. (prev=3Dffff9aaab2713510) [ 842.460118] ------------[ cut here ]------------ [ 842.461599] kernel BUG at lib/list_debug.c:53! [ 842.462962] invalid opcode: 0000 [#1] PREEMPT SMP PTI [ 842.464587] CPU: 1 PID: 500 Comm: kworker/u256:28 Not tainted 5.18.0 #70 [ 842.466656] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 11/12/2020 [ 842.470309] Workqueue: nfsd4 laundromat_main [nfsd] [ 842.471898] RIP: 0010:__list_del_entry_valid.cold.3+0x37/0x4a [ 842.473792] Code: e8 02 d8 fe ff 0f 0b 48 c7 c7 c0 bb b6 b0 e8 f4 d7 fe ff 0f 0b 48 89 d1 48 89 f2 48 89 fe 48 c7 c7 70 bb b6 b0 e8 dd d7 fe ff <0f> 0b 48 89 fe 48 c7 c7 38 bb b6 b0 e8 cc d7 fe ff 0f 0b 48 89 ee [ 842.479607] RSP: 0018:ffffa996c0ca7de8 EFLAGS: 00010246 [ 842.481828] RAX: 000000000000006d RBX: ffff9aaa8b5f0c60 RCX: 00000000000= 00002 [ 842.484769] RDX: 0000000000000000 RSI: ffffffffb0b64d55 RDI: 00000000fff= fffff [ 842.487252] RBP: ffff9aaab9b62000 R08: 0000000000000000 R09: c0000000fff= f7fff [ 842.489939] R10: 0000000000000001 R11: ffffa996c0ca7c00 R12: ffffa996c0c= a7e50 [ 842.492215] R13: ffff9aaab9b621b0 R14: fffffffffffffd12 R15: ffff9aaab9b= 62198 [ 842.494406] FS: 0000000000000000(0000) GS:ffff9aaafbe40000(0000) knlGS:0000000000000000 [ 842.496939] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 842.498759] CR2: 000055a8b4e96010 CR3: 0000000003a18001 CR4: 00000000001= 706e0 [ 842.500957] Call Trace: [ 842.501740] [ 842.502479] _free_cpntf_state_locked+0x36/0x90 [nfsd] [ 842.504157] laundromat_main+0x59e/0x8b0 [nfsd] [ 842.505594] ? finish_task_switch+0xbd/0x2a0 [ 842.507247] process_one_work+0x1c8/0x390 [ 842.508538] worker_thread+0x30/0x360 [ 842.509670] ? process_one_work+0x390/0x390 [ 842.510957] kthread+0xe8/0x110 [ 842.511938] ? kthread_complete_and_exit+0x20/0x20 [ 842.513422] ret_from_fork+0x22/0x30 [ 842.514533] [ 842.515219] Modules linked in: rdma_ucm ib_uverbs rpcrdma rdma_cm iw_cm ib_cm ib_core nfsd nfs_acl lockd grace ext4 mbcache jbd2 fuse xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ipt_REJECT nf_reject_ipv4 nft_compat nf_tables nfnetlink tun bridge stp llc bnep vmw_vsock_vmci_transport vsock intel_rapl_msr snd_seq_midi snd_seq_midi_event intel_rapl_common crct10dif_pclmul crc32_pclmul vmw_balloon ghash_clmulni_intel pcspkr joydev btusb uvcvideo btrtl btbcm btintel videobuf2_vmalloc videobuf2_memops snd_ens1371 videobuf2_v4l2 snd_ac97_codec ac97_bus videobuf2_common snd_seq videodev snd_pcm bluetooth rfkill mc snd_timer snd_rawmidi ecdh_generic snd_seq_device ecc snd soundcore vmw_vmci i2c_piix4 auth_rpcgss sunrpc ip_tables xfs libcrc32c sr_mod cdrom sg ata_generic nvme nvme_core t10_pi crc32c_intel crc64_rocksoft serio_raw crc64 vmwgfx vmxnet3 drm_ttm_helper ata_piix ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ahci libahci drm libata [ 842.541753] ---[ end trace 0000000000000000 ]--- [ 842.543403] RIP: 0010:__list_del_entry_valid.cold.3+0x37/0x4a [ 842.545170] Code: e8 02 d8 fe ff 0f 0b 48 c7 c7 c0 bb b6 b0 e8 f4 d7 fe ff 0f 0b 48 89 d1 48 89 f2 48 89 fe 48 c7 c7 70 bb b6 b0 e8 dd d7 fe ff <0f> 0b 48 89 fe 48 c7 c7 38 bb b6 b0 e8 cc d7 fe ff 0f 0b 48 89 ee [ 842.551346] RSP: 0018:ffffa996c0ca7de8 EFLAGS: 00010246 [ 842.552999] RAX: 000000000000006d RBX: ffff9aaa8b5f0c60 RCX: 00000000000= 00002 [ 842.555151] RDX: 0000000000000000 RSI: ffffffffb0b64d55 RDI: 00000000fff= fffff [ 842.557503] RBP: ffff9aaab9b62000 R08: 0000000000000000 R09: c0000000fff= f7fff [ 842.559694] R10: 0000000000000001 R11: ffffa996c0ca7c00 R12: ffffa996c0c= a7e50 [ 842.561956] R13: ffff9aaab9b621b0 R14: fffffffffffffd12 R15: ffff9aaab9b= 62198 [ 842.564300] FS: 0000000000000000(0000) GS:ffff9aaafbe40000(0000) knlGS:0000000000000000 [ 842.567357] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 842.569273] CR2: 000055a8b4e96010 CR3: 0000000003a18001 CR4: 00000000001= 706e0 [ 842.571598] Kernel panic - not syncing: Fatal exception [ 842.573674] Kernel Offset: 0x2e800000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) [ 1101.134589] ---[ end Kernel panic - not syncing: Fatal exception ]--- On Wed, Jul 27, 2022 at 1:15 PM Chuck Lever III wr= ote: > > > > > On Jul 27, 2022, at 12:18 PM, Olga Kornievskaia wrote: > > > > Hi Chuck, > > Sorry for the delay, I was traveling. > > > To make it compile I did: > > diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c > > index 7196bcafdd86..f6deffc921d0 100644 > > --- a/fs/nfsd/nfs4proc.c > > +++ b/fs/nfsd/nfs4proc.c > > @@ -1536,7 +1536,7 @@ nfsd4_setup_inter_ssc(struct svc_rqst *rqstp, > > if (status) > > goto out; > > > > - status =3D nfsd4_interssc_connect(©->cp_src, rqstp, mount); > > + status =3D nfsd4_interssc_connect(copy->cp_src, rqstp, mount); > > if (status) > > goto out; > > Yes, same bug was reported by the day-0 kbot. v1 was kind of an RFC, > as I hadn't fully tested it. Sorry for mislabeling it. > > I will post a v2 of this series with this fixed and with Dai's > fix for nfsd4_decode_copy(). Stand by. > > > > But when I tried to run the nfstest_ssc. The first test (intra01) made > > the server oops: > > > > [ 9569.551100] CPU: 0 PID: 2861 Comm: nfsd Not tainted 5.19.0-rc6+ #73 > > [ 9569.552385] Hardware name: VMware, Inc. VMware Virtual > > Platform/440BX Desktop Reference Platform, BIOS 6.00 11/12/2020 > > [ 9569.555043] RIP: 0010:nfsd4_copy+0x28b/0x4e0 [nfsd] > > [ 9569.556662] Code: 24 38 49 89 94 24 10 01 00 00 49 8b 56 08 48 8d > > 79 08 49 89 94 24 18 01 00 00 49 8b 56 10 48 83 e7 f8 49 89 94 24 20 > > 01 00 00 <48> 8b 06 48 89 01 48 8b 86 04 04 00 00 48 89 81 04 04 00 00 > > 48 29 > > [ 9569.561792] RSP: 0018:ffffb092c0c97dd0 EFLAGS: 00010282 > > [ 9569.563112] RAX: ffff99b5465c2460 RBX: ffff99b5a68828e0 RCX: ffff99b= 5853b6000 > > [ 9569.565196] RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff99b= 5853b6008 > > [ 9569.567140] RBP: ffffb092c0c97e10 R08: ffffffffc0bf3c24 R09: 0000000= 000000228 > > [ 9569.568929] R10: ffff99b54b0e9268 R11: ffff99b564326998 R12: ffff99b= 5543dfc00 > > [ 9569.570477] R13: ffff99b5a6882950 R14: ffff99b5a68829f0 R15: ffff99b= 546edc000 > > [ 9569.572052] FS: 0000000000000000(0000) GS:ffff99b5bbe00000(0000) > > knlGS:0000000000000000 > > [ 9569.573926] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ 9569.575281] CR2: 0000000000000000 CR3: 0000000076c36002 CR4: 0000000= 0001706f0 > > [ 9569.577586] Call Trace: > > [ 9569.578220] > > [ 9569.578770] ? nfsd4_proc_compound+0x3d2/0x730 [nfsd] > > [ 9569.579945] nfsd4_proc_compound+0x3d2/0x730 [nfsd] > > [ 9569.581055] nfsd_dispatch+0x146/0x270 [nfsd] > > [ 9569.581987] svc_process_common+0x365/0x5c0 [sunrpc] > > [ 9569.583122] ? nfsd_svc+0x350/0x350 [nfsd] > > [ 9569.583986] ? nfsd_shutdown_threads+0x90/0x90 [nfsd] > > [ 9569.585129] svc_process+0xb7/0xf0 [sunrpc] > > [ 9569.586169] nfsd+0xd5/0x190 [nfsd] > > [ 9569.587170] kthread+0xe8/0x110 > > [ 9569.587898] ? kthread_complete_and_exit+0x20/0x20 > > [ 9569.588934] ret_from_fork+0x22/0x30 > > [ 9569.589759] > > [ 9569.590224] Modules linked in: rdma_ucm ib_uverbs rpcrdma rdma_cm > > iw_cm ib_cm ib_core nfsd nfs_acl lockd grace ext4 mbcache jbd2 fuse > > xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ipt_REJECT > > nf_reject_ipv4 nft_compat nf_tables nfnetlink tun bridge stp llc bnep > > vmw_vsock_vmci_transport vsock snd_seq_midi snd_seq_midi_event > > intel_rapl_msr intel_rapl_common crct10dif_pclmul crc32_pclmul > > vmw_balloon ghash_clmulni_intel joydev pcspkr btusb btrtl btbcm > > btintel snd_ens1371 uvcvideo snd_ac97_codec videobuf2_vmalloc ac97_bus > > videobuf2_memops videobuf2_v4l2 videobuf2_common snd_seq snd_pcm > > videodev bluetooth mc rfkill ecdh_generic ecc snd_timer snd_rawmidi > > snd_seq_device snd vmw_vmci soundcore i2c_piix4 auth_rpcgss sunrpc > > ip_tables xfs libcrc32c sr_mod cdrom sg ata_generic crc32c_intel > > ata_piix nvme ahci libahci nvme_core t10_pi crc64_rocksoft serio_raw > > crc64 vmwgfx drm_ttm_helper ttm drm_kms_helper syscopyarea sysfillrect > > sysimgblt fb_sys_fops vmxnet3 drm libata > > [ 9569.610612] CR2: 0000000000000000 > > [ 9569.611375] ---[ end trace 0000000000000000 ]--- > > [ 9569.612424] RIP: 0010:nfsd4_copy+0x28b/0x4e0 [nfsd] > > [ 9569.613472] Code: 24 38 49 89 94 24 10 01 00 00 49 8b 56 08 48 8d > > 79 08 49 89 94 24 18 01 00 00 49 8b 56 10 48 83 e7 f8 49 89 94 24 20 > > 01 00 00 <48> 8b 06 48 89 01 48 8b 86 04 04 00 00 48 89 81 04 04 00 00 > > 48 29 > > [ 9569.617410] RSP: 0018:ffffb092c0c97dd0 EFLAGS: 00010282 > > [ 9569.618487] RAX: ffff99b5465c2460 RBX: ffff99b5a68828e0 RCX: ffff99b= 5853b6000 > > [ 9569.620097] RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff99b= 5853b6008 > > [ 9569.621710] RBP: ffffb092c0c97e10 R08: ffffffffc0bf3c24 R09: 0000000= 000000228 > > [ 9569.623398] R10: ffff99b54b0e9268 R11: ffff99b564326998 R12: ffff99b= 5543dfc00 > > [ 9569.625019] R13: ffff99b5a6882950 R14: ffff99b5a68829f0 R15: ffff99b= 546edc000 > > [ 9569.627456] FS: 0000000000000000(0000) GS:ffff99b5bbe00000(0000) > > knlGS:0000000000000000 > > [ 9569.629249] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ 9569.630433] CR2: 0000000000000000 CR3: 0000000076c36002 CR4: 0000000= 0001706f0 > > [ 9569.632043] Kernel panic - not syncing: Fatal exception > > > > > > > > On Tue, Jul 26, 2022 at 3:45 PM Olga Kornievskaia wrot= e: > >> > >> Chuck, > >> > >> Are there pre-reqs for this series? I had tried to apply the patches > >> on top of 5-19-rc6 but I get the following compile error: > >> > >> fs/nfsd/nfs4proc.c: In function =E2=80=98nfsd4_setup_inter_ssc=E2=80= =99: > >> fs/nfsd/nfs4proc.c:1539:34: error: passing argument 1 of > >> =E2=80=98nfsd4_interssc_connect=E2=80=99 from incompatible pointer typ= e > >> [-Werror=3Dincompatible-pointer-types] > >> status =3D nfsd4_interssc_connect(©->cp_src, rqstp, mount); > >> ^~~~~~~~~~~~~ > >> fs/nfsd/nfs4proc.c:1414:43: note: expected =E2=80=98struct nl4_server = *=E2=80=99 but > >> argument is of type =E2=80=98struct nl4_server **=E2=80=99 > >> nfsd4_interssc_connect(struct nl4_server *nss, struct svc_rqst *rqstp, > >> ~~~~~~~~~~~~~~~~~~~^~~ > >> cc1: some warnings being treated as errors > >> make[2]: *** [scripts/Makefile.build:249: fs/nfsd/nfs4proc.o] Error 1 > >> make[1]: *** [scripts/Makefile.build:466: fs/nfsd] Error 2 > >> make: *** [Makefile:1843: fs] Error 2 > >> > >> On Fri, Jul 22, 2022 at 4:36 PM Chuck Lever w= rote: > >>> > >>> While testing NFSD for-next, I noticed svc_generic_init_request() > >>> was an unexpected hot spot on NFSv4 workloads. Drilling into the > >>> perf report, it shows that the hot path in there is: > >>> > >>> 1208 memset(rqstp->rq_argp, 0, procp->pc_argsize); > >>> 1209 memset(rqstp->rq_resp, 0, procp->pc_ressize); > >>> > >>> For an NFSv4 COMPOUND, > >>> > >>> procp->pc_argsize =3D sizeof(nfsd4_compoundargs), > >>> > >>> struct nfsd4_compoundargs on my system is more than 17KB! This is > >>> due to the size of the iops field: > >>> > >>> struct nfsd4_op iops[8]; > >>> > >>> Each struct nfsd4_op contains a union of the arguments for each > >>> NFSv4 operation. Each argument is typically less than 128 bytes > >>> except that struct nfsd4_copy and struct nfsd4_copy_notify are both > >>> larger than 2KB each. > >>> > >>> I'm not yet totally convinced this series never orphans memory, but > >>> it does reduce the size of nfsd4_compoundargs to just over 4KB. This > >>> is still due to struct nfsd4_copy being almost 500 bytes. I don't > >>> see more low-hanging fruit there, though. > >>> > >>> --- > >>> > >>> Chuck Lever (11): > >>> NFSD: Shrink size of struct nfsd4_copy_notify > >>> NFSD: Shrink size of struct nfsd4_copy > >>> NFSD: Reorder the fields in struct nfsd4_op > >>> NFSD: Make nfs4_put_copy() static > >>> NFSD: Make boolean fields in struct nfsd4_copy into atomic bit f= lags > >>> NFSD: Refactor nfsd4_cleanup_inter_ssc() (1/2) > >>> NFSD: Refactor nfsd4_cleanup_inter_ssc() (2/2) > >>> NFSD: Refactor nfsd4_do_copy() > >>> NFSD: Remove kmalloc from nfsd4_do_async_copy() > >>> NFSD: Add nfsd4_send_cb_offload() > >>> NFSD: Move copy offload callback arguments into a separate struc= ture > >>> > >>> > >>> fs/nfsd/nfs4callback.c | 37 +++++---- > >>> fs/nfsd/nfs4proc.c | 165 +++++++++++++++++++++-------------------= - > >>> fs/nfsd/nfs4xdr.c | 30 +++++--- > >>> fs/nfsd/state.h | 1 - > >>> fs/nfsd/xdr4.h | 54 ++++++++++---- > >>> 5 files changed, 163 insertions(+), 124 deletions(-) > >>> > >>> -- > >>> Chuck Lever > >>> > > -- > Chuck Lever > > >