All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fletcher Woodruff <fletcherw@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ben Zhang <benzh@chromium.org>,
	Bard Liao <bardliao@realtek.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Takashi Iwai <tiwai@suse.com>,
	Curtis Malainey <cujomalainey@chromium.org>,
	alsa-devel@alsa-project.org, Ross Zwisler <zwisler@google.com>
Subject: Re: [PATCH 1/2] ASoC: rt5677: allow multiple interrupt sources
Date: Wed, 3 Apr 2019 15:32:04 -0600	[thread overview]
Message-ID: <CAN-6NYaO0bah_vFgTGrnU5_pUM95B+voDxsUR6K6o5wj5ZRD6w@mail.gmail.com> (raw)
In-Reply-To: <20190402050236.GV2059@sirena.org.uk>

On Mon, Apr 1, 2019 at 11:02 PM Mark Brown <broonie@kernel.org> wrote:
> regmap-irq should support active high/low, and if it doesn't it can't be
> a unique thing that only this device wants to implement so the common
> code should be improved.

The rt5677 driver needs its own irq regardless for hotword detection.
If we implemented this in regmap-irq, we wouldn't be able to use it.

> This looks unrelated to the polarity of the interupt?

Yes this is separate. If a plug/unplug happens after regmap_read and
before regmap_write, it will not be registered, so we loop to make
sure that it's caught in a later iteration. I can clarify this in the
patch notes.

  reply	other threads:[~2019-04-03 21:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 20:55 [PATCH 1/2] ASoC: rt5677: allow multiple interrupt sources Fletcher Woodruff
2019-04-01 20:55 ` [PATCH 2/2] ASoC: rt5677: make ACPI property names match _DSD Fletcher Woodruff
2019-04-02  5:06   ` Mark Brown
2019-04-02 15:52     ` Fletcher Woodruff
2019-04-03  3:33       ` Mark Brown
2019-04-05 20:42   ` [PATCH v2 0/3] Fix jack detection for Chromebook Pixel Fletcher Woodruff
2019-04-05 20:42     ` [PATCH v2 1/3] ASoC: rt5677: allow multiple interrupt sources Fletcher Woodruff
2019-04-08  6:10       ` Mark Brown
2019-04-09 19:53         ` Fletcher Woodruff
2019-04-05 20:42     ` [PATCH v2 2/3] ASoC: rt5677: handle concurrent interrupts Fletcher Woodruff
2019-04-05 20:42     ` [PATCH v2 3/3] ASoC: rt5677: fall back to DT prop names on error Fletcher Woodruff
2019-04-15 19:45       ` [PATCH v3 0/3] Fix jack detection for Chromebook Pixel Fletcher Woodruff
2019-04-15 19:45         ` [PATCH v3 1/3] ASoC: rt5677: allow multiple interrupt sources Fletcher Woodruff
2019-04-25 15:31           ` [PATCH v3 2/3] ASoC: rt5677: handle concurrent interrupts Fletcher Woodruff
2019-04-25 15:31             ` [PATCH v3 3/3] ASoC: rt5677: fall back to DT prop names on error Fletcher Woodruff
2019-04-18  9:07         ` [PATCH v3 0/3] Fix jack detection for Chromebook Pixel Mark Brown
2019-04-18  9:07           ` Mark Brown
2019-04-25 15:28           ` Fletcher Woodruff
2019-04-02  5:02 ` [PATCH 1/2] ASoC: rt5677: allow multiple interrupt sources Mark Brown
2019-04-03 21:32   ` Fletcher Woodruff [this message]
2019-04-04  5:32     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN-6NYaO0bah_vFgTGrnU5_pUM95B+voDxsUR6K6o5wj5ZRD6w@mail.gmail.com \
    --to=fletcherw@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=benzh@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cujomalainey@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zwisler@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.