From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42126)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ronniesahlberg@gmail.com>) id 1R3yII-0007C2-Lf
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 18:51:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ronniesahlberg@gmail.com>) id 1R3yIH-0006fn-HP
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 18:51:02 -0400
Received: from mail-vw0-f51.google.com ([209.85.212.51]:60681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ronniesahlberg@gmail.com>) id 1R3yIH-0006ff-Ey
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 18:51:01 -0400
Received: by vws20 with SMTP id 20so3548556vws.10
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2011 15:51:01 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110914143608.GB12218@lst.de>
References: <1315628610-28222-1-git-send-email-ronniesahlberg@gmail.com>
	<1315628610-28222-2-git-send-email-ronniesahlberg@gmail.com>
	<20110912091408.GA3465@stefanha-thinkpad.localdomain>
	<20110914143608.GB12218@lst.de>
Date: Thu, 15 Sep 2011 08:51:00 +1000
Message-ID: <CAN05THQDtk-ZhO1LVjesM0mgcHBj7rG_Qz6GoNqc_5GW8KLy3g@mail.gmail.com>
From: ronnie sahlberg <ronniesahlberg@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: kwolf@redhat.com, fujita.tomonori@lab.ntt.co.jp, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Thu, Sep 15, 2011 at 12:36 AM, Christoph Hellwig <hch@lst.de> wrote:
...
>> > +/*
>> > + * We support iscsi url's on the form
>> > + * iscsi://[<username>%<password>@]<host>[:<port>]/<targetname>/<lun>
>> > + */
>
> Is having username + password on the command line really a that good idea?
> Also what about the more complicated iSCSI authentification schemes?

In general it is a very bad idea. For local use on a private box it is
convenient to be able to use "<username>%<password>@" syntax.
For use on a shared box, libiscsi supports an alternative method too
by setting the username and/or password via environment variables :
LIBISCSI_CHAP_USERNAME=...  LIBISCSI_CHAP_PASSWORD=...

I will document this better in the next patch.


Libiscsi only support CHAP at this stage. Which other authentication
schemes do you have in mind? Perhaps I can add them.


regards
ronnie sahlberg