From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: "Aurélien Aptel" <aaptel@suse.com>
Cc: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: don't leak -EAGAIN for stat() during reconnect
Date: Wed, 19 Feb 2020 05:58:23 +1000 [thread overview]
Message-ID: <CAN05THQq3GW81ugfiXXEsobwyv0zW5Jk0gQx75-8m_n0EW5sFQ@mail.gmail.com> (raw)
In-Reply-To: <878sl0azhv.fsf@suse.com>
On Tue, Feb 18, 2020 at 9:47 PM Aurélien Aptel <aaptel@suse.com> wrote:
>
> Hi Ronnie,
>
> Ronnie Sahlberg <lsahlber@redhat.com> writes:
> > Fix this by re-trying the operation from within cifs_revalidate_dentry_attr()
> > if cifs_get_inode_info*() returns -EAGAIN.
>
> Would it make sense to use is_retryable_error() instead of checking for
> just EAGAIN? It also checks for interruption errors.
Makes sense. Thanks.
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-02-18 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 4:48 [PATCH] cifs: don't leak -EAGAIN for stat() during reconnect Ronnie Sahlberg
2020-02-18 11:47 ` Aurélien Aptel
2020-02-18 19:58 ` ronnie sahlberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-18 20:01 Ronnie Sahlberg
2020-02-18 23:26 ` Steve French
2020-02-24 19:36 ` Pavel Shilovsky
2020-02-24 20:22 ` Steve French
2020-02-18 4:18 [PATCH 0/1] dont leak -EAGAIN Ronnie Sahlberg
2020-02-18 4:18 ` [PATCH] cifs: don't leak -EAGAIN for stat() during reconnect Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN05THQq3GW81ugfiXXEsobwyv0zW5Jk0gQx75-8m_n0EW5sFQ@mail.gmail.com \
--to=ronniesahlberg@gmail.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.