All of lore.kernel.org
 help / color / mirror / Atom feed
From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Paulo Alcantara <pc@cjr.nz>
Cc: linux-cifs <linux-cifs@vger.kernel.org>,
	Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 2/4] cifs: change noisy error message to FYI
Date: Tue, 9 Mar 2021 10:40:03 +1000	[thread overview]
Message-ID: <CAN05THS0e8-c_2WNpy5UZUbbCjPwSQ+N6jM0O9834TGv_5c4Qg@mail.gmail.com> (raw)
In-Reply-To: <20210308150050.19902-2-pc@cjr.nz>

reviewed-by me

On Tue, Mar 9, 2021 at 1:02 AM Paulo Alcantara <pc@cjr.nz> wrote:
>
> A customer has reported that their dmesg were being flooded by
>
>   CIFS: VFS: \\server Cancelling wait for mid xxx cmd: a
>   CIFS: VFS: \\server Cancelling wait for mid yyy cmd: b
>   CIFS: VFS: \\server Cancelling wait for mid zzz cmd: c
>
> because some processes that were performing statfs(2) on the share had
> been interrupted due to their automount setup when certain users
> logged in and out.
>
> Change it to FYI as they should be mostly informative rather than
> error messages.
>
> Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
> ---
>  fs/cifs/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
> index 7bb1584b3724..f62f512e2cb1 100644
> --- a/fs/cifs/transport.c
> +++ b/fs/cifs/transport.c
> @@ -1248,7 +1248,7 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses,
>         }
>         if (rc != 0) {
>                 for (; i < num_rqst; i++) {
> -                       cifs_server_dbg(VFS, "Cancelling wait for mid %llu cmd: %d\n",
> +                       cifs_server_dbg(FYI, "Cancelling wait for mid %llu cmd: %d\n",
>                                  midQ[i]->mid, le16_to_cpu(midQ[i]->command));
>                         send_cancel(server, &rqst[i], midQ[i]);
>                         spin_lock(&GlobalMid_Lock);
> --
> 2.30.1
>

  parent reply	other threads:[~2021-03-09  0:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 15:00 [PATCH 1/4] cifs: print MIDs in decimal notation Paulo Alcantara
2021-03-08 15:00 ` [PATCH 2/4] cifs: change noisy error message to FYI Paulo Alcantara
2021-03-08 15:12   ` Aurélien Aptel
2021-03-09  0:40   ` ronnie sahlberg [this message]
2021-03-08 15:00 ` [PATCH 3/4] cifs: return proper error code in statfs(2) Paulo Alcantara
2021-03-08 15:13   ` Aurélien Aptel
2021-03-08 21:08   ` Steve French
2021-03-08 22:21     ` Paulo Alcantara
2021-03-09  0:40   ` ronnie sahlberg
2021-03-08 15:00 ` [PATCH 4/4] cifs: do not send close in compound create+close requests Paulo Alcantara
2021-03-08 15:29   ` Aurélien Aptel
2021-03-08 21:06   ` Steve French
2021-03-08 22:22     ` Paulo Alcantara
2021-03-09  0:43   ` ronnie sahlberg
2021-03-08 15:10 ` [PATCH 1/4] cifs: print MIDs in decimal notation Aurélien Aptel
2021-03-09  0:39 ` ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN05THS0e8-c_2WNpy5UZUbbCjPwSQ+N6jM0O9834TGv_5c4Qg@mail.gmail.com \
    --to=ronniesahlberg@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@cjr.nz \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.