From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqM28-0001hc-F7 for qemu-devel@nongnu.org; Thu, 26 Jan 2012 04:54:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqM20-0002ra-KQ for qemu-devel@nongnu.org; Thu, 26 Jan 2012 04:54:20 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:41764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqM20-0002rQ-Fg for qemu-devel@nongnu.org; Thu, 26 Jan 2012 04:54:12 -0500 Received: by obbup16 with SMTP id up16so390109obb.4 for ; Thu, 26 Jan 2012 01:54:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F211C9F.4030209@redhat.com> References: <1327140203-3165-1-git-send-email-ronniesahlberg@gmail.com> <1327140203-3165-2-git-send-email-ronniesahlberg@gmail.com> <4F1DA1D5.1010600@redhat.com> <4F20266F.20409@redhat.com> <4F211813.7060404@redhat.com> <4F211C9F.4030209@redhat.com> Date: Thu, 26 Jan 2012 20:54:11 +1100 Message-ID: From: ronnie sahlberg Content-Type: multipart/mixed; boundary=f46d04479529b401df04b76b5c31 Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Eric Blake , qemu-devel@nongnu.org --f46d04479529b401df04b76b5c31 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Ok so what about this You use a filename starting with "/proc/self/fd/" and you dont have a proc filesystem mounted? you are on your own! regards ronnie sahlberg On Thu, Jan 26, 2012 at 8:27 PM, Kevin Wolf wrote: > Am 26.01.2012 10:18, schrieb ronnie sahlberg: >> Kevin, >> >> Collissions are bad, but what about >> >> IF ! STRNCMP (filename, "/proc/self/fd/", 14) =A0THEN >> =A0 =A0 =A0 =A0 =A0fopen(filename, "r") >> ELSE >> =A0 =A0 =A0 =A0 fdopen(atoi(filename+14), "r") >> FI >> >> modulo better validation for the atio() arguments. >> >> >> Probability of anyone using "/proc/self/fd/" as a prefix for normal >> files is very small. >> Small enough it will be justifiable to say "do that and you are on your = own". ? > > Interesting idea. Maybe that could work. > > Kevin --f46d04479529b401df04b76b5c31 Content-Type: application/x-gzip; name="0001-READCONFIG-make-proc-self-fd-a-magic-prefix-to-refer.patch.gz" Content-Disposition: attachment; filename="0001-READCONFIG-make-proc-self-fd-a-magic-prefix-to-refer.patch.gz" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gxvls8np0 H4sIAMchIU8AA5VUa3PaRhT9vr/ilg8xVA+EkBDGjgcmhoSMY6fG7nSm6TCLdBc2gZWyEok7cf57 70rElpyk02oA7Z4997mHO9PpDgYh58HxIImi1bB/LHpxMIyCUMRhGITYx0EU+SLygxjepAoWmEEv As8blR/wPa/HZuRmBNepUhJhwTfbFeo1nOoSyA/78XrH5daN090ZO+cFjuBms7fBH8BrrshPz6ef URCNAg+sXs/z2GK/eo9xMYI/305uXrz6C66nk/MXV5ez+csR7PgHhG6m07ib41Z0RdIFTuhaxpBp FPIOihRogdosOOQZxlLImIGQW0ww1zIrUg1SbVDLAhMQphvFBiHjGlXhMraQa4WJkwrhrP7+XxU6 jsPgI+72TpwqIdduDAD39O0NwGo8D8Q0K2SqcndzVxKhT0Q688t8c4g3XK0xsY0HqXLUJbttdWxi JrjFau90GEukEOA4a1kA7zaTWDX3TKoE72Dl9T3fC133GCPvOAmA2j8IAlPFUw+MUv7Oy3gMThR5 9hAs8/I9ICTdFyMGjJItygKXGnmyrGyWpqY2rfPCFKbhVwMovsMOgy/MMfXP5hdTwuE5iDRD1f7G sKGlW52TimScayxOmFUzOewOZzaI5IBUobJCk9PL24sLgg9UAe280CreZfU4TX21qPdBp0P5lTbm +Xl2JeUr4DbHugFqrVIy8k5qThICKHqRbh/cgEWxbHhGuVJUr1Ojm1wrN7+QH7i/h7Kg59CwNXhZ KZGO3nlHjbTNQ53ZawXOdH75++Si5v/rk/KSqr6kWZm52W/ZCBPd9NME+S5AmevJD0RZE/zqKXIQ Zp97Eceh62IYcBEOfyDMmk1NmjXUiNMPo8iOwCrfQ6PO8+ms3TKKrARJd/tqslhOrl/a8Nv0ze3y 6u3N/Opy+ciwGSxupn/MGYxpWuzAeTyC8Seuv5j2U1vGokq9ds6ca1rTn/STjBEqbK+5ybAaOo/2 LrP+OxduSVxHTZGeqrMj4PmDGJhVjkF+GG80avFO5oVUa/tx9NnNmegymFalll36bDj/3qYaxa4U 0HJqGJwa/2fvVItuDljPjdy+22PsH0tbKkmABgAA --f46d04479529b401df04b76b5c31 Content-Type: text/x-diff; charset=US-ASCII; name="0001-READCONFIG-make-proc-self-fd-a-magic-prefix-to-refer.patch" Content-Disposition: attachment; filename="0001-READCONFIG-make-proc-self-fd-a-magic-prefix-to-refer.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gxvlsaya1 RnJvbSA2NWFhNDk2ZDc3YjgzOWYxYzQ4NzQ1ZmM1NTQ1ZTNlNjc3MmY3MjRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb25uaWUgU2FobGJlcmcgPHJvbm5pZXNhaGxiZXJnQGdtYWls LmNvbT4KRGF0ZTogVGh1LCAyNiBKYW4gMjAxMiAyMDo0Nzo0MCArMTEwMApTdWJqZWN0OiBbUEFU Q0hdIFJFQURDT05GSUc6IG1ha2UgL3Byb2Mvc2VsZi9mZC8gYSBtYWdpYyBwcmVmaXggdG8gcmVm ZXIgdG8gYSBzcGVjaWZpYwogZmlsZWRlc3JpcHRvciBpbmhlcml0ZWQgZnJvbSB0aGUgcGFyZW50 LgoKU2lnbmVkLW9mZi1ieTogUm9ubmllIFNhaGxiZXJnIDxyb25uaWVzYWhsYmVyZ0BnbWFpbC5j b20+Ci0tLQogcWVtdS1jb25maWcuYyAgIHwgICAxNiArKysrKysrKysrKysrKy0tCiBxZW11LW9w dGlvbnMuaHggfCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3FlbXUtY29uZmlnLmMgYi9xZW11LWNvbmZpZy5j CmluZGV4IGIwMzAyMDUuLjllNzA5ZDQgMTAwNjQ0Ci0tLSBhL3FlbXUtY29uZmlnLmMKKysrIGIv cWVtdS1jb25maWcuYwpAQCAtNzcwLDggKzc3MCwyMCBAQCBvdXQ6CiAKIGludCBxZW11X3JlYWRf Y29uZmlnX2ZpbGUoY29uc3QgY2hhciAqZmlsZW5hbWUpCiB7Ci0gICAgRklMRSAqZiA9IGZvcGVu KGZpbGVuYW1lLCAiciIpOwotICAgIGludCByZXQ7CisgICAgRklMRSAqZjsKKyAgICBpbnQgcmV0 LCBmZDsKKyAgICBjaGFyICpwdHIgPSBOVUxMOworCisgICAgaWYgKHN0cm5jbXAoZmlsZW5hbWUs ICIvcHJvYy9zZWxmL2ZkLyIsIDE0KSkgeworICAgICAgICBmID0gZm9wZW4oZmlsZW5hbWUsICJy Iik7CisgICAgfSBlbHNlIHsKKyAgICAgICAgZXJybm8gPSAwOworICAgICAgICBmZCA9IHN0cnRv bChmaWxlbmFtZSArIDE0LCAmcHRyLCAxMCk7CisgICAgICAgIGlmIChlcnJubyAhPSAwIHx8IHB0 ciA9PSBmaWxlbmFtZSArIDE0IHx8ICpwdHIgIT0gJ1wwJykgeworICAgICAgICAgICAgcmV0dXJu IC1FSU5WQUw7CisgICAgICAgIH0KKyAgICAgICAgZiA9IGZkb3BlbihmZCwgInIiKTsKKyAgICB9 CiAKICAgICBpZiAoZiA9PSBOVUxMKSB7CiAgICAgICAgIHJldHVybiAtZXJybm87CmRpZmYgLS1n aXQgYS9xZW11LW9wdGlvbnMuaHggYi9xZW11LW9wdGlvbnMuaHgKaW5kZXggM2EwN2FlOC4uZTU0 YWY1OCAxMDA2NDQKLS0tIGEvcWVtdS1vcHRpb25zLmh4CisrKyBiL3FlbXUtb3B0aW9ucy5oeApA QCAtMjU3Nyw3ICsyNTc3LDggQEAgREVGKCJyZWFkY29uZmlnIiwgSEFTX0FSRywgUUVNVV9PUFRJ T05fcmVhZGNvbmZpZywKIFNURVhJCiBAaXRlbSAtcmVhZGNvbmZpZyBAdmFye2ZpbGV9CiBAZmlu ZGV4IC1yZWFkY29uZmlnCi1SZWFkIGRldmljZSBjb25maWd1cmF0aW9uIGZyb20gQHZhcntmaWxl fS4KK1JlYWQgZGV2aWNlIGNvbmZpZ3VyYXRpb24gZnJvbSBAdmFye2ZpbGV9LiBVc2UgJy9wcm9j L3NlbGYvZmQvPG4+JyBhcyBmaWxlbmFtZQordG8gcmVhZCBmcm9tIGFuIGV4aXN0aW5nLCBpbmhl cml0ZWQsIGZpbGVkZXNyaXB0b3IuCiBFVEVYSQogREVGKCJ3cml0ZWNvbmZpZyIsIEhBU19BUkcs IFFFTVVfT1BUSU9OX3dyaXRlY29uZmlnLAogICAgICItd3JpdGVjb25maWcgPGZpbGU+XG4iCi0t IAoxLjcuMy4xCgo= --f46d04479529b401df04b76b5c31--