From: "Martin Ågren" <martin.agren@gmail.com>
To: Kevin Daudt <me@ikke.info>
Cc: Git Mailing List <git@vger.kernel.org>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] maintenance: specify explicit stdin for crontab
Date: Tue, 30 Mar 2021 07:41:48 +0200 [thread overview]
Message-ID: <CAN0heSrSNJhy33Wi9Yq8kfnkJEyvQoadyj8joLqHtV+SYPs1sw@mail.gmail.com> (raw)
In-Reply-To: <20210329210928.561586-1-me@ikke.info>
On Mon, 29 Mar 2021 at 23:23, Kevin Daudt <me@ikke.info> wrote:
>
> There are multiple crontab implementations that require stdin for
> editing a crontab to be explicitly specified as '-'.
[...]
> --- a/t/helper/test-crontab.c
> +++ b/t/helper/test-crontab.c
> @@ -17,7 +17,7 @@ int cmd__crontab(int argc, const char **argv)
> if (!from)
> return 0;
> to = stdout;
> - } else if (argc == 2) {
> + } else if ((argc == 3 && !strcmp(argv[2], "-")) || argc == 2) {
> from = stdin;
> to = fopen(argv[1], "w");
Would it make sense to make this
} else if (argc == 3 && !strcmp(argv[2], "-")) {
in order to make this test-tool as picky as possible and to only accept
the kind of usage we want to (well, need to) use? The tests as they
stand would still pass, which I think argues for us not really needing
that "argc == 2".
This would be followed by
} else
return error("unknown arguments");
which wouldn't be super helpful if you forgot the "-", but helpful
enough for an internal test-tool, I guess.
Speaking of usage and hints, there's "Usage: ..." in a comment at the
top of this file. It should probably be updated either way.
Martin
next prev parent reply other threads:[~2021-03-30 5:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 21:09 [PATCH] maintenance: specify explicit stdin for crontab Kevin Daudt
2021-03-30 5:41 ` Martin Ågren [this message]
2021-03-30 12:02 ` Derrick Stolee
2021-03-30 17:12 ` Kevin Daudt
2021-03-30 19:32 ` Derrick Stolee
2021-03-30 17:43 ` Todd Zullinger
2021-03-30 19:38 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSrSNJhy33Wi9Yq8kfnkJEyvQoadyj8joLqHtV+SYPs1sw@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.