From: "Martin Ågren" <martin.agren@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Derrick Stolee" <dstolee@microsoft.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Dr . Adam Nielsen" <admin@in-ici.net>,
"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH 0/3] Documentation: change "folder" to "directory"
Date: Tue, 26 Oct 2021 08:02:44 +0200 [thread overview]
Message-ID: <CAN0heSrco2P9cwhDNkXeO1xNMAr4+Mo1+0Y-UEhF5vgrkBOa3A@mail.gmail.com> (raw)
In-Reply-To: <481447f9-7222-d9fc-269f-2de50299fb09@gmail.com>
Hi Bagas,
On Mon, 25 Oct 2021 at 11:19, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 25/10/21 00.09, Martin Ågren wrote:
> > Martin Ågren (3):
> > git-multi-pack-index.txt: change "folder" to "directory"
> > gitignore.txt: change "folder" to "directory"
> > gitweb.txt: change "folder" to "directory"
> >
>
> The same logical change over three patches, why aren't they be squashed
> into single commit?
Old habit, I guess. :) I tend to find that having multiple patches aids
reviewing. Within reason, obviously. Reviewers don't have to go "I agree
with everything except that particular hunk", but can just say "I agree
with everything except patch two", making tracking things a bit easier.
Similarly, if the patches are all independent (albeit being about the
same topic) and it comes up that a particular patch is not such a good
idea after all because reasons, Junio could just decide to apply a
subset and leave the rest. In this case, the commit message of the third
patch assumes that the first two have already been applied, so they're
not completely independent, but that's about the only interdependency
there is in these.
I'm happy to go either way.
Martin
next prev parent reply other threads:[~2021-10-26 6:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 17:09 [PATCH 0/3] Documentation: change "folder" to "directory" Martin Ågren
2021-10-24 17:09 ` [PATCH 1/3] git-multi-pack-index.txt: " Martin Ågren
2021-10-24 17:09 ` [PATCH 2/3] gitignore.txt: " Martin Ågren
2021-10-24 17:09 ` [PATCH 3/3] gitweb.txt: " Martin Ågren
2021-10-25 9:19 ` [PATCH 0/3] Documentation: " Bagas Sanjaya
2021-10-26 6:02 ` Martin Ågren [this message]
2021-10-27 18:48 ` Junio C Hamano
2021-10-25 15:31 ` Derrick Stolee
2021-10-25 18:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSrco2P9cwhDNkXeO1xNMAr4+Mo1+0Y-UEhF5vgrkBOa3A@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=admin@in-ici.net \
--cc=bagasdotme@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.