From: Mario Six <mario.six@gdsys.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] video_osd: Add ihs_video_out driver
Date: Fri, 25 May 2018 13:20:34 +0200 [thread overview]
Message-ID: <CAN1kZop8dv3Td7XKosZb-j0PUorCxF55fUa2qKRKOWPsyG2qGg@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ1QJKCUtYYpXR8Ew6FK6_OD_Rr7zRuN4XZ=OjN+aq02QA@mail.gmail.com>
Hi Simon,
On Wed, May 23, 2018 at 6:33 PM, Simon Glass <sjg@chromium.org> wrote:
> Hi Mario,
>
> On 23 May 2018 at 06:09, Mario Six <mario.six@gdsys.cc> wrote:
>> Add a driver for IHS OSDs on IHS FPGAs.
>>
>> Signed-off-by: Mario Six <mario.six@gdsys.cc>
>>
>> ---
>>
>> v1 -> v2:
>> * Renamed x and y parameters to col and row
>> * Removed duplicate IHS_VIDEO_OUT definition
>> * Switched error return code of ihs_video_out_set_mem to E2BIG
>> * Dropped blank lines between dev_read_u32_default calls
>> * Documented members of ihs_video_out_priv
>> * Turned printfs into debugs
>> * Don't display OSD until something has been written to it
>> * Made the code a bit more readable
>> * Added binding file
>> * Expanded documentation and help
>> * Switched to display_enable
>> * Switched to regmap usage (instead of fpgamap uclass)
>> * Renamed 'dp_tx' property to 'video_tx'
>>
>> ---
>> .../video/osd/gdsys,ihs_video_out.txt | 22 ++
>> drivers/video/Kconfig | 9 +
>> drivers/video/Makefile | 1 +
>> drivers/video/ihs_video_out.c | 277 +++++++++++++++++++++
>> 4 files changed, 309 insertions(+)
>> create mode 100644 doc/device-tree-bindings/video/osd/gdsys,ihs_video_out.txt
>> create mode 100644 drivers/video/ihs_video_out.c
>>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> You could perhaps s/dev_read_prop/dev_read_string/ to avoid the cast.
> Also is there a binding file for your driver's device-tree node
> somewhere?
>
Sure, no problem, and, no, there isn't. I will write a binding file for v3.
> Regards,
> Simon
>
Best regards,
Mario
next prev parent reply other threads:[~2018-05-25 11:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 12:09 [U-Boot] [PATCH v2 1/5] drivers: Add OSD uclass Mario Six
2018-05-23 12:09 ` [U-Boot] [PATCH v2 2/5] video_osd: Add ihs_video_out driver Mario Six
2018-05-23 16:33 ` Simon Glass
2018-05-25 11:20 ` Mario Six [this message]
2018-05-23 12:09 ` [U-Boot] [PATCH v2 3/5] video_osd: Add osd sandbox driver and tests Mario Six
2018-05-23 16:33 ` Simon Glass
2018-05-25 11:19 ` Mario Six
2018-05-23 12:09 ` [U-Boot] [PATCH v2 4/5] lib: Import hexdump.c from Linux Mario Six
2018-05-23 16:33 ` Simon Glass
2018-05-25 11:22 ` Mario Six
2018-06-04 16:05 ` Alexey Brodkin
2018-06-13 8:24 ` Mario Six
2018-06-13 16:04 ` Alexey Brodkin
2018-05-23 12:09 ` [U-Boot] [PATCH v2 5/5] cmd: Add osd commands Mario Six
2018-05-23 16:33 ` Simon Glass
2018-05-25 11:23 ` Mario Six
2018-05-23 16:33 ` [U-Boot] [PATCH v2 1/5] drivers: Add OSD uclass Simon Glass
2018-05-25 11:25 ` Mario Six
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN1kZop8dv3Td7XKosZb-j0PUorCxF55fUa2qKRKOWPsyG2qGg@mail.gmail.com \
--to=mario.six@gdsys.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.