From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755826AbbDOB4c (ORCPT ); Tue, 14 Apr 2015 21:56:32 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:35623 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753708AbbDOB40 convert rfc822-to-8bit (ORCPT ); Tue, 14 Apr 2015 21:56:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <1426493782-3791-1-git-send-email-vndao@altera.com> Date: Wed, 15 Apr 2015 09:56:23 +0800 Message-ID: Subject: Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver From: Viet Nga Dao To: Brian Norris , David Woodhouse Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , "linux-mtd@lists.infradead.org" , nga_chi86 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Could you please help me to review this patch? Thanks On Mon, Mar 16, 2015 at 4:40 PM, Viet Nga Dao wrote: > On Mon, Mar 16, 2015 at 4:35 PM, Rafał Miłecki wrote: >> On 16 March 2015 at 09:16, wrote: >>> +static struct flash_device flash_devices[] = { >>> + FLASH_ID("epcq16-nonjedec", 2, 0x15), >>> + FLASH_ID("epcq32-nonjedec", 2, 0x16), >>> + FLASH_ID("epcq64-nonjedec", 2, 0x17), >>> + FLASH_ID("epcq128-nonjedec", 2, 0x18), >>> + FLASH_ID("epcq256-nonjedec", 2, 0x19), >>> + FLASH_ID("epcq512-nonjedec", 2, 0x20), >> >> You could probably use EPCQ_OPCODE_ID >> >> >>> + >>> + FLASH_ID("epcs16-nonjedec", 1, 0x14), >>> + FLASH_ID("epcs64-nonjedec", 1, 0x16), >>> + FLASH_ID("epcs128-nonjedec", 1, 0x18), >> >> And EPCS_OPCODE_ID here. >> > Noted >> >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >>> index 43bb552..ad0c274 100644 >>> --- a/drivers/mtd/spi-nor/spi-nor.c >>> +++ b/drivers/mtd/spi-nor/spi-nor.c >>> @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] = { >>> { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, >>> { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, >>> { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, >>> + >>> + /* Altera EPCQ/EPCS Flashes */ >>> + { "epcq16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, >>> + { "epcq32-nonjedec", INFO(0, 0, 0x10000, 64, 0) }, >>> + { "epcq64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, >>> + { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256, 0) }, >>> + { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512, 0) }, >>> + { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) }, >>> + { "epcs16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, >>> + { "epcs64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, >>> + { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256, 0) }, >>> { }, >>> }; >> >> But mostly, I just wanted to say I like your integration with spi-nor. >> Nice work :) >> >> -- >> Rafał > > Thank you. This is all thanks to you and Brian for helpful comments. I > learned a lot :) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wg0-f44.google.com ([74.125.82.44]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YiCZM-00026J-Ba for linux-mtd@lists.infradead.org; Wed, 15 Apr 2015 01:56:49 +0000 Received: by wgso17 with SMTP id o17so31222269wgs.1 for ; Tue, 14 Apr 2015 18:56:25 -0700 (PDT) Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com. [209.85.212.177]) by mx.google.com with ESMTPSA id pv2sm3817390wjc.33.2015.04.14.18.56.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 18:56:24 -0700 (PDT) Received: by widdi4 with SMTP id di4so42995042wid.0 for ; Tue, 14 Apr 2015 18:56:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1426493782-3791-1-git-send-email-vndao@altera.com> Date: Wed, 15 Apr 2015 09:56:23 +0800 Message-ID: Subject: Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver From: Viet Nga Dao To: Brian Norris , David Woodhouse Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "devicetree@vger.kernel.org" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "linux-mtd@lists.infradead.org" , Linux Kernel Mailing List , nga_chi86 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, Could you please help me to review this patch? Thanks On Mon, Mar 16, 2015 at 4:40 PM, Viet Nga Dao wrote: > On Mon, Mar 16, 2015 at 4:35 PM, Rafa=C5=82 Mi=C5=82ecki wrote: >> On 16 March 2015 at 09:16, wrote: >>> +static struct flash_device flash_devices[] =3D { >>> + FLASH_ID("epcq16-nonjedec", 2, 0x15), >>> + FLASH_ID("epcq32-nonjedec", 2, 0x16), >>> + FLASH_ID("epcq64-nonjedec", 2, 0x17), >>> + FLASH_ID("epcq128-nonjedec", 2, 0x18), >>> + FLASH_ID("epcq256-nonjedec", 2, 0x19), >>> + FLASH_ID("epcq512-nonjedec", 2, 0x20), >> >> You could probably use EPCQ_OPCODE_ID >> >> >>> + >>> + FLASH_ID("epcs16-nonjedec", 1, 0x14), >>> + FLASH_ID("epcs64-nonjedec", 1, 0x16), >>> + FLASH_ID("epcs128-nonjedec", 1, 0x18), >> >> And EPCS_OPCODE_ID here. >> > Noted >> >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-no= r.c >>> index 43bb552..ad0c274 100644 >>> --- a/drivers/mtd/spi-nor/spi-nor.c >>> +++ b/drivers/mtd/spi-nor/spi-nor.c >>> @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] = =3D { >>> { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | SPI= _NOR_NO_FR) }, >>> { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | SPI= _NOR_NO_FR) }, >>> { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI= _NOR_NO_FR) }, >>> + >>> + /* Altera EPCQ/EPCS Flashes */ >>> + { "epcq16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, >>> + { "epcq32-nonjedec", INFO(0, 0, 0x10000, 64, 0) }, >>> + { "epcq64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, >>> + { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256, 0) }, >>> + { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512, 0) }, >>> + { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) }, >>> + { "epcs16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, >>> + { "epcs64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, >>> + { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256, 0) }, >>> { }, >>> }; >> >> But mostly, I just wanted to say I like your integration with spi-nor. >> Nice work :) >> >> -- >> Rafa=C5=82 > > Thank you. This is all thanks to you and Brian for helpful comments. I > learned a lot :)