From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH 08/10] pinctrl: single: support pinconf generic Date: Mon, 22 Oct 2012 18:09:36 +0800 Message-ID: References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> <1350551224-12857-8-git-send-email-haojian.zhuang@gmail.com> <20121019191333.GT4730@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121019191333.GT4730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Tony Lindgren Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote: > * Haojian Zhuang [121018 02:08]: >> Add pinconf generic support with POWER SOURCE, BIAS PULL. > ... > >> + case PIN_CONFIG_POWER_SOURCE: >> + if (pcs->psmask == PCS_OFF_DISABLED >> + || pcs->psshift == PCS_OFF_DISABLED) >> + return -ENOTSUPP; >> + data &= pcs->psmask; >> + data = data >> pcs->psshift; >> + *config = data; >> + return 0; >> + break; > > Hmm, only slightly related to this patch, mostly a generic > question to others: Do others have any mux registers with > status bits for things like PIN_CONFIG_POWER_SOURCE? > > I could use PIN_CONFIG_POWER_SOURCE for controlling the PBIAS > for omap MMC. But there's also a status bit that needs to be > checked for that. I think there was some other similar mux > register for USB PHY that has a status register. > > So I'm wondering should the checking for status bit be handled > in the pinctrl consume driver? Or should we have some bindings > for that? > Do you mean that the status register only exists in USB PHY controller or MMC controller? If so, could we use regulator framework in USB PHY or MMC driver? Regards Haojian From mboxrd@z Thu Jan 1 00:00:00 1970 From: haojian.zhuang@gmail.com (Haojian Zhuang) Date: Mon, 22 Oct 2012 18:09:36 +0800 Subject: [PATCH 08/10] pinctrl: single: support pinconf generic In-Reply-To: <20121019191333.GT4730@atomide.com> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> <1350551224-12857-8-git-send-email-haojian.zhuang@gmail.com> <20121019191333.GT4730@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote: > * Haojian Zhuang [121018 02:08]: >> Add pinconf generic support with POWER SOURCE, BIAS PULL. > ... > >> + case PIN_CONFIG_POWER_SOURCE: >> + if (pcs->psmask == PCS_OFF_DISABLED >> + || pcs->psshift == PCS_OFF_DISABLED) >> + return -ENOTSUPP; >> + data &= pcs->psmask; >> + data = data >> pcs->psshift; >> + *config = data; >> + return 0; >> + break; > > Hmm, only slightly related to this patch, mostly a generic > question to others: Do others have any mux registers with > status bits for things like PIN_CONFIG_POWER_SOURCE? > > I could use PIN_CONFIG_POWER_SOURCE for controlling the PBIAS > for omap MMC. But there's also a status bit that needs to be > checked for that. I think there was some other similar mux > register for USB PHY that has a status register. > > So I'm wondering should the checking for status bit be handled > in the pinctrl consume driver? Or should we have some bindings > for that? > Do you mean that the status register only exists in USB PHY controller or MMC controller? If so, could we use regulator framework in USB PHY or MMC driver? Regards Haojian