From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754139AbdDCRYr (ORCPT ); Mon, 3 Apr 2017 13:24:47 -0400 Received: from mail-bl2nam02on0120.outbound.protection.outlook.com ([104.47.38.120]:45036 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753102AbdDCRYp (ORCPT ); Mon, 3 Apr 2017 13:24:45 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=maximintegrated.com; MIME-Version: 1.0 In-Reply-To: <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop> References: <1490922994-19294-1-git-send-email-ryans.lee@maximintegrated.com> <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop> From: Ryan Lee Date: Mon, 3 Apr 2017 10:24:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier To: Rob Herring CC: Liam Girdwood , Mark Brown , , , , Kuninori Morimoto , Arnd Bergmann , , , , , , Axel Lin , , Srinivas Kandagatla , , , , , , Dylan Reid Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [209.85.218.50] X-ClientProxiedBy: MWHPR14CA0024.namprd14.prod.outlook.com (10.173.227.34) To BY2PR11MB0839.namprd11.prod.outlook.com (10.163.112.21) X-MS-Office365-Filtering-Correlation-Id: 30337134-2988-4144-3bf1-08d47ab6510b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:BY2PR11MB0839; X-Microsoft-Exchange-Diagnostics: 1;BY2PR11MB0839;3:+wIqEFSd9DUSkNIZqOT6iAZ0oyJpi984NEsEQZFcL1KiTNSnjpaJkytg6CJ0tCWXWOHcYNRer1OMv6pcMkWbPy9AHUrmFn+KMTCNQKB4fy2xNwKXdMZPavvZoSJJraQubde4ar72XuUwJwZS2X7p3YE8ezQZjsvxx5gfcq0KY2qZdsHWOOw55hmLGkzYGg257bSKe1dlmLDUmS68SSpWdib3RgBx83Hiaih8TMWX1eMT939GUwPbd3b6vV5BSq8r7RcEAEKlokO/qoxpKq+8Dw64Y580SgoNJ1+RK5oqKmTvvDuO3p34T3DdmYttK6QVMhk513AQqc2He8NebmWovbPBMncSJXISpSv7Prx9tTA=;25:a+qu95HZ3IoHCPgrUM/hQ3DO18G5eYeiFD0LO3zVogHJlF6f0oxPabjBEa/Zr/6IB3f+V2pRowDeWhfjWkK9Cb0gOtNH+elII7E8i5N/i/TjS8pXvyhuOLyIgDyDn0DKm9mNpfaBas2sofhuorwVgxyO+cs2+HcNAxZ7Ja/i9dV1dRoXQzb7axzX+b8XlCxZGraTYq6w8UfcJbLoHg5kbD65QladARKIsC/Z6+2Ve4qlYQuhJBlpIzB17UAegEk8a3MTpyVlhpeMZs+Uu/Hw6+bDTq2tZug2Od+9q70hDhylhe0yJbND4UQxo7aAEs3OyPfjSSlnSiYc8ZUTSqINndvn7+db3jGRH1kJA+blxfdtMDxxA9KEjiKwQaSjfiT8IBCATOLCsZqx1A/qiDfShPh4GgzGxmvUHR5ygOWNnBHnuQh+XYC5vbLC95uQI2/RXsL3h7wQtYpvlSrZK5rPsw== X-Microsoft-Exchange-Diagnostics: 1;BY2PR11MB0839;31:2CO9dXdNfvxEaCpBJywXNY1eOH9/TdbUzP+AvmISu/d/GsHQUYSOjm8DCR4hSubPNM/XVvRKJL1jZS68IyL5q5Th9JVYfPmkOHkciqJLl1APkALh2k7t3MtdIN4y/f4HOxMzPynLp3FAL2oZvwIBq95V7V0noGf3XfIKNj9hRnRUK6HZLG46RxtTgH1W3C3NUX0ccYV8sPAUYO1NUozP/l9HENEOs+EIM0ib7O/ggd3mXa2bX5NLIWT/ItCVKkp4YMZsoaCL1T+iOR99WBhXxA==;20:SxM800MvtC5q13LoAd9B5MKT/g5qm3FVSxEGqH6qZIve9bnHHyLPbdFenwjdzjP++E4PQSCz1LOKH459teqUDke6s8rekQ8IDtEGbPZmmJ1lsx+ID9gcxCEAFkDxSThoigeat+PDmm9EAKky3k3vtOusNLTM3QC2Qv/avI3qvKYMi2s3131hhs71JRZn1J4DNbiCN46QOuB214vb/XazasnWw7jC/kKI3zDyKmKO1ltVLkbEe574tZc2EZrlxC7Ow/Qb2/HkDZ1TTZjpFRBEn3tdmzOW7s0inES9GAbH86c7QesHyd5RPT1PncjzAvMmJuyQVyMdBhIxMbgn63i7jtDFMSXWBqKOeNxt5DGEv+D3O1I0wGxt7BqRN6UUoJI0ltedPOAbmeCtnmStJ29SdFfRqjJRoUz7lluRbxRlgdBn4jRfYsNhWFko+ucY07sTnaKZ8+zIXp/FTKPXu1O2JoJEZrZpI7h1CW68VpLoZbgMiKZvhxp5A/AdhuJCFHCa X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(108721460000369); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:BY2PR11MB0839;BCL:0;PCL:0;RULEID:;SRVR:BY2PR11MB0839; X-Microsoft-Exchange-Diagnostics: 1;BY2PR11MB0839;4:Gx4qM24xb61sXYmFH3ZXg6CXRqXslZYb9d6SSZacI5xHe4JqXYZxclHjE4qIv+EAv7vXoLtnufIutxODC9nDvQmzXM+s4CDNdR3jjdXnfmAvNS2hGO4VL+dEoEPy5+JZ2Y2AR0aK92OkU4V7aKQp4+qg4l2CmRRccvb0ObdZcp4hWQLR6cI1gGtMqrQTmIpN/oNzULUsbY/IOZfPbeyoMUWpgVCR1VCtu2dRca8EnT9ePQThhFGOnNj7GfuSHndI+78hHNzR/lujzM/QX8awkYU5Vk1QEBRtBjuHudbjDT3KT2p2os6VqWSogyMVgaDYtAxXfXhpmB4n8QW/NtXhVf3kBmZSIE0bRS62TMNf7c0VwWXXx436ojpxZesjbg7XMVVfKRsavBChcbJRD+0VIOryCIxNVJaI67dfHtYH9IgBmRNuc+MSZsx/Y2pskSfmzDBTIIvelQZhLXAvdYi2OAVouaqLGKwQQUaal/6Iqbl6zf08b/rnQNOkItGXQL7kga+wnIsEfJvI8LmO6Um7ThGcFYffw2VeeEMnzunryXdlD03Slq7Xu5Ijms29JMBFqcn1fanU1aOVmmDdiHpgAzMBxjNphFvbAI5iXTOhMAWOc/7Pais+UWuRP7aIG6ebFBxOXdEEIgsZ9yKVPnrAs5R+x8JVcfldFdKkBLXKoH+iSxi6h2DfuFKvT549IBUhU2RXoX+DrUyHVbg9F3oCbhJcHa7bq3ha7qIiFLozS+6pQq1LF5MD+paophhB8BxhevQH6vJmXcy6SKa0uqbZUEJW9GmY6f2xdtR0Qplbepk= X-Forefront-PRVS: 0266491E90 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(39860400002)(24454002)(377454003)(66066001)(2906002)(9686003)(50466002)(61726006)(229853002)(9896002)(61266001)(55446002)(23676002)(47776003)(53936002)(5820100001)(59536001)(122856001)(54906002)(76176999)(50986999)(93516999)(63696999)(54356999)(498394004)(6246003)(38730400002)(6116002)(107886003)(110136004)(7736002)(3846002)(305945005)(86362001)(2950100002)(53546009)(42186005)(8676002)(81166006)(6862004)(189998001)(4326008)(450100002)(5660300001)(55456009);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR11MB0839;H:mail-oi0-f50.google.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjExTUIwODM5OzIzOjBmOE4rWjMxeGtCQzJHSlhHY283dEVhTFFV?= =?utf-8?B?enUreVNzWUxLZW1TbjBFRlBrUzNLOTQ5TmlBdFFMOW5XMXFsRHNjVDRFbkZR?= =?utf-8?B?ZmhtTTVJdFF1cjgwSVNIWWFjNENJK09vNmhVdGp2SVRiOHowM1Q2aTQ0dWV3?= =?utf-8?B?dVF3UmwyWU9LY3kzdStnZWpNbTNGMVhRU2RYekp3RzY3ZmlSQWJTMVNOOGwy?= =?utf-8?B?SVpieFQzMDh3SjhLMGttRlM5NDFzRGkyRkpFbW94QkZZcnAyQUp3WGtadHRt?= =?utf-8?B?ZXB5M0oyT09EZWdxNGdDcU5RZ09tS1RYTk1zckxIVlc3ZEMzUi9KSGl6bFY0?= =?utf-8?B?UEw5OTVQRnQ4ZVNOSUdoUHQwdXNRaEtPb0dlSU5MTjBmL0lGQTFyTCtDS0pL?= =?utf-8?B?Y2UzVXRZUWJ6ZXhYMDhTWnp0RSs3Uk11cUowS0J0NjZkS3ZYOGNhQWkzd1hK?= =?utf-8?B?WThFbGZlc0h6eFVkM2RJVHhldW1rVHdVUkxhbkpKYUFFTWV6QXVjaGJzR1dR?= =?utf-8?B?aXhTY1I2Y2ZBbjY0WnZiZmVBYkFrVEZMTDFvQmR1ek5yRUovVSthRUVyWHBy?= =?utf-8?B?cWtPWUcyQVJMMWlZNGExUDVjWVVZVk16V3R1akhjOWFwWjR0NGlWTFl3WmZU?= =?utf-8?B?T0RHVURuN2ZnRWZGdmxjNHp4bVRMMW5iVnIvMFFDSFo0cllMTzRndE9YK0ZX?= =?utf-8?B?SzRlRStGVlhqV2VJL0pvWm5zSkUxaG9IU3RhZU9YV0crNk11TE1vUytWZ25Y?= =?utf-8?B?YXJ1WGg0N2ZBZDFKY2o3dWVtc0FCVk05K3RWSFpUYmtZOG9UbStKcmppOGln?= =?utf-8?B?Rjc1ZVAvWnVIOW9QMVhqSmxBeCtaWEpQVzRJTDByMjJnTGdZZVZoRDFKM0R3?= =?utf-8?B?Y1JtQzZpcDdhOGFjK0ExZml1ZEpKbUtWLzQ5VnFSaHZYck1WbTBYcGlxTnFB?= =?utf-8?B?dTg5Yk9LMzhNQW90OG50dFhkMFp6cVRvRkNzK1dMNU1wNE0wc1ZNV2lpbzdT?= =?utf-8?B?dW45eHBlbndEdU9lZUdOVU81a25HVjRYaVJsVk91VEV1VFRnUTdZVGlaeEVJ?= =?utf-8?B?Sy9Kby9MSVd0UUJBTyszMlZGUnpsaXBZczFNV21PT2E0RDdTT0xTeTJ5QkRS?= =?utf-8?B?VHp3SEo4TWF3aGNObnZiY0dnTjA0TGdGVitEV0RqTjc4ZlpvOHdjeXF1Q0w1?= =?utf-8?B?M0VkcjRKc1pTWVd4YUhjT29RZGNibFdsL2FFbzRsMHdDUnB2NzFJM3QvRjFP?= =?utf-8?B?Sm15cWpHZVpqZFVzdzVJYTg0ZEczRVZqUjJTK0IwaERmMnVnSjJjVDVIZXhD?= =?utf-8?B?dWh0dU42V2RibHpERlU2RUFCWFV5UzMweFRab29lbmFJMHF4Vmp6SzRpT1ZU?= =?utf-8?B?bWJJL0k0dExGTjduSU12d1RGc3ZpMkdZRlJxejRyVnVJQ0U3eEh1TnplME12?= =?utf-8?B?K3Vkby9UVEJYOGhDTlRzVHY3OW9nN25HanZBVU5Xbmtwbmo3S1ByRGFSb1lp?= =?utf-8?B?QXFuakF6dWo0enI4RkI1MEZGWi91VGRURHdMMFdtUGZsUE5kK29YT3BBLytk?= =?utf-8?B?dDNQQWRheGVLQVNxNE5YMGQ3YnRRTEFkd3FWMVU5c1ZkZU5Zclh3bW4rSFVK?= =?utf-8?B?aFF4UFNXSjBEZkdiYTYvNEtISmZKY244eDMzcXJnM0d0L2RBbURJeXhaU3pQ?= =?utf-8?B?OFhVeldyU3VhY2t1dnVrU01MMmM2QlEvbjdrZTlzcmNzMHI3ZDlzN3NrdHpK?= =?utf-8?B?ZWh2cktOektOSmdQQVNkdz09?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR11MB0839;6:1cByf3OCFu8jlnRvLBKcDOQNTQbW6T7inDSSlAnXqnnucl/c8xWeEHwxbvi1gBYzH+46lLgsU3xohzTJx255rZTIA9wxssLmblBIpLJ2ktmZ4nczhhH2FALBzRhc/DWZ258IDuWecjQLKQQQNUAE7oo5XHfPwcbQVKMqLme5V4PemZHy9WlzEqhcocdkK3WCENq8kEIQ90f8Y7nuU4lgvGJE4HKQbXQbITsLfObC9b0iLKGRioQER3yeNz7De4Ff0hw2YEisuSzOrrg5qcgN1CtMDo7KqnZ7shZzhUoSEg8iI1TMMcpH9BQi23jA5RZvCPTHSyuhBlYpuW39Ok5FhRqcmrteZsVPi7mpUvkTgU2wNunH82xhBu5eCQUxPNihiV0Bc2vSPrW6DVLQ31eZrOL7HKdOge5sanbj4Eijt8c=;5:ys6fIeddlIcP/InK6eWawibn5b15YlEFjm3CZSYpfJs68pTupEOvsti695k/t6oW4jk1Cex5ilOJIkKu7Nzb69v1XwUwpyOuiRA0jFHcuUoZAAPp0nBDIIT3T2Z9NZjWeVBPffpbnuDRQFYGbdzaJ8myLFse2Eiirvfnub6hqZE=;24:atyHVO9dKzTfntAM8QfWBvY8X6/jMj4jqL1C4X2ih6NKi23LYbiE5ZsCUSu1blxFeWBJP3OpswzaDtdQsnEc9OBkK1EpM1T6T7dHTzdjJlg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR11MB0839;7:DOAiP9Z9FzLIQxdYVttjnu5P0ly0ayoXdpyJJsqxnw2uiDgniE6LvSMWMKv8mt2nNE8phd1+acfKruLu4m/qcWptu6kSDrJVfkfVTPNtD7kDrN8imSwftlEiPffbQiW9CKqXpihSJ4XWj0EJSJOhxapLRr8lj6BYF4YuVSxAMPzaHrxIMMi86Xmex6zkiim9ghbLjHGWbF9X4ICjglf7ZD+A9ieIYrJhILzbirGoRtouqN9MhwQODLfCQNdiwFU48qV5E8FVtnEvXGT/yYORwMV7Wi5vHkP1dnEFiz01o0EPJwA3VEpiVn3j3vWfDsCcDHlX0vdYt/2lbxeuD3YEhQ== X-OriginatorOrg: maximintegrated.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 17:24:42.8389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0839 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring wrote: > On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- >> >> Changes since v4: >> * Removed support for SND_SOC_DAIFMT_CBS_CFM. >> * Fixed coding style for indention. >> * Removed variables if it has only one user. >> * Assigned ch_size directly. >> * Removed oring. >> * Put the return false in the switch statement. >> * Removed 'Monomix Output' and 'Speaker Source' controls. >> * Modified control names per control-names.rst. >> * Moved Revision ID check code to i2c_probe function. >> * Added 'Current Limit' control. >> * Removed 'devm__kfree' function. >> >> Changes since v3: >> * Combined MAX98926 and MAX98927 binding. Kept existing property name. > > This looks fine, but: > >> Changes since v2: >> * Removed local register read/write function to avoid duplication of ASoC core function. >> >> .../devicetree/bindings/sound/max98925.txt | 22 - >> .../devicetree/bindings/sound/max98926.txt | 32 - >> .../devicetree/bindings/sound/max9892x.txt | 41 + >> sound/soc/codecs/Kconfig | 5 + >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/max98927.c | 841 +++++++++++++++++++++ >> sound/soc/codecs/max98927.h | 272 +++++++ >> 7 files changed, 1161 insertions(+), 54 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt >> delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt >> create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt >> mode change 100644 => 100755 sound/soc/codecs/Kconfig >> mode change 100644 => 100755 sound/soc/codecs/Makefile >> create mode 100755 sound/soc/codecs/max98927.c >> create mode 100755 sound/soc/codecs/max98927.h > > These should all be 644 mode. I've changed the mode to 644. Thank you. > > Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Lee Subject: Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier Date: Mon, 3 Apr 2017 10:24:38 -0700 Message-ID: References: <1490922994-19294-1-git-send-email-ryans.lee@maximintegrated.com> <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Liam Girdwood , Mark Brown , mark.rutland-5wv7dgnIgG8@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, Kuninori Morimoto , Arnd Bergmann , ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, bardliao-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org, nh6z-fFIq/eER6g8@public.gmane.org, KCHSU0-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org, Axel Lin , romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Srinivas Kandagatla , oder_chiou-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org, Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dylan Reid List-Id: devicetree@vger.kernel.org On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring wrote: > On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- >> >> Changes since v4: >> * Removed support for SND_SOC_DAIFMT_CBS_CFM. >> * Fixed coding style for indention. >> * Removed variables if it has only one user. >> * Assigned ch_size directly. >> * Removed oring. >> * Put the return false in the switch statement. >> * Removed 'Monomix Output' and 'Speaker Source' controls. >> * Modified control names per control-names.rst. >> * Moved Revision ID check code to i2c_probe function. >> * Added 'Current Limit' control. >> * Removed 'devm__kfree' function. >> >> Changes since v3: >> * Combined MAX98926 and MAX98927 binding. Kept existing property name. > > This looks fine, but: > >> Changes since v2: >> * Removed local register read/write function to avoid duplication of ASoC core function. >> >> .../devicetree/bindings/sound/max98925.txt | 22 - >> .../devicetree/bindings/sound/max98926.txt | 32 - >> .../devicetree/bindings/sound/max9892x.txt | 41 + >> sound/soc/codecs/Kconfig | 5 + >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/max98927.c | 841 +++++++++++++++++++++ >> sound/soc/codecs/max98927.h | 272 +++++++ >> 7 files changed, 1161 insertions(+), 54 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt >> delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt >> create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt >> mode change 100644 => 100755 sound/soc/codecs/Kconfig >> mode change 100644 => 100755 sound/soc/codecs/Makefile >> create mode 100755 sound/soc/codecs/max98927.c >> create mode 100755 sound/soc/codecs/max98927.h > > These should all be 644 mode. I've changed the mode to 644. Thank you. > > Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html