From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 310D2C6FA82 for ; Mon, 5 Sep 2022 00:53:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6655C84382; Mon, 5 Sep 2022 02:53:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fmqfEe1d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B40EA8421E; Mon, 5 Sep 2022 02:53:35 +0200 (CEST) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C231D80517 for ; Mon, 5 Sep 2022 02:53:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rickchen36@gmail.com Received: by mail-io1-xd2d.google.com with SMTP id i77so5836397ioa.7 for ; Sun, 04 Sep 2022 17:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=E6HYohPm9PAqmeF44WBjYkQYx95AasPQCAsSnT9pPgs=; b=fmqfEe1dkPN7r0qT6eNOhEvcSfbKOyoQE/5cXORz8NGK667AReopc3Wd/SWifEsS6A G5yAwcN6m7CmK9U45Ve0yfoF7mKEK2Lounb+herzz4mBRTYxRjQkOK3gSg/+if9VDhX8 AjhjqpOkHH7xlgCOelfb15MBdu2KaC9OhkXDbYTO4ooE2q5TwS10dUf7Jh3OZam54V7J EJx5uOsPV8bMDb1q6sPU9zq4SvV4eU06zmNqGDyCD6Y6B69Vqnq9h6R9k8hfujXj/828 +uc1/o2jyOKxJwYuRllHO6ak279iL1V/PuQ4ia2X3RwhpkChpzEbrXc2lZytIMYRDX9L uaTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=E6HYohPm9PAqmeF44WBjYkQYx95AasPQCAsSnT9pPgs=; b=13TF/7yaClW7Ffqnp6cDKrR60L4m0xQRz682EMkyNsyaR2H56EauKLFek6+5sC31A/ Cl80FtVrIfG0O6OxYEeZIJom1o9LneP0M3XN+TFTFgjyxIgW7HYAGkLPa2vnnYEHl1fZ BbhaJbYdJ5U6S60nfXiu8TtvrtAFNcmap/oy/pNKu6J/AZ6RfI7VrBq/jzv5WLP5b/b9 vihN9Rla50fZaXtJTBs4/DVi+D2lBkO4J5QPY6N+kCHmZP8bP3cEBCG7C6kiLsLCZbx4 BeG6GiQ1NX36tcUBA1yFNl7O383WTmKul7YFn12ZHI3CjL/fTt2i69VEi98LIb9lcyu4 ssQw== X-Gm-Message-State: ACgBeo2e0Q4hmUHDv6YmrctmUcqB0ycS7x79wzXI8bu3y+NLmuTF0hwy IlNdaltZFUuv1tRbm+i0TkgRHFZOgp94oubPLWA= X-Google-Smtp-Source: AA6agR6jhHsNRAL2B6o5bmzMQo8mZL1j+sZ0QdJGkPcSVUBvOg05oUXbrzPEZfeYnzrsY4frNTu2O/9EJtQKWqjptVk= X-Received: by 2002:a05:6638:25d3:b0:34a:1590:6b8a with SMTP id u19-20020a05663825d300b0034a15906b8amr25818582jat.303.1662339208099; Sun, 04 Sep 2022 17:53:28 -0700 (PDT) MIME-Version: 1.0 References: <20220902074010.1171646-1-saproj@gmail.com> In-Reply-To: From: Rick Chen Date: Mon, 5 Sep 2022 08:53:17 +0800 Message-ID: Subject: Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment To: saproj@gmail.com Cc: U-Boot Mailing List , jh80.chung@samsung.com, Peng Fan , Masahiro Yamada , Simon Glass , Leo Liang , rick Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > From: Sergei Antonov > Sent: Friday, September 02, 2022 3:40 PM > To: u-boot@lists.denx.de > Cc: jh80.chung@samsung.com; peng.fan@nxp.com; yamada.masahiro@socionext.c= om; sjg@chromium.org; Rick Jian-Zhi Chen(=E9=99=B3=E5=BB=BA=E5=BF=97) ; Sergei Antonov > Subject: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the com= ment > > Get rid of discrepancy beween comment /* 250 ms */ and code which shifts = by 4 thus dividing by 16. > So change code to shift by 2 and make the timeout value 250 ms. > > Signed-off-by: Sergei Antonov > --- > drivers/mmc/ftsdc010_mci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c inde= x 570d54cf9d8f..cabb747fbbdb 100644 > --- a/drivers/mmc/ftsdc010_mci.c > +++ b/drivers/mmc/ftsdc010_mci.c > @@ -30,7 +30,7 @@ > #include > #include > > -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */ > +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */ Reviewed-by: Rick Chen