All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Chen <rickchen36@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/2] sifive: fu540: Enable OF_SEPARATE
Date: Mon, 2 Dec 2019 11:32:40 +0800	[thread overview]
Message-ID: <CAN5B=eLmrCu-ktgeTb4FofNJn0eCfOxU+BU7GUUD0EZZf5eiQQ@mail.gmail.com> (raw)
In-Reply-To: <752D002CFF5D0F4FA35C0100F1D73F3FA46A8F41@ATCPCS16.andestech.com>

Hi Jagon

> From: Jagan Teki [mailto:jagan at amarulasolutions.com]
> Sent: Monday, November 18, 2019 7:30 PM
> To: Rick Jian-Zhi Chen(陳建志)
> Cc: u-boot at lists.denx.de; Jagan Teki
> Subject: [PATCH v4 2/2] sifive: fu540: Enable OF_SEPARATE
>
> Use dts support from U-Boot via OF_SEPARATE instead of depending from opensbi.
>
> This would help to make the necessary changes in drivers and device trees in U-Boot tree itself. This feature would also be helpful to not pass dtb during opensbi builds.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v4:
> - Drop abosolete text
>
>  configs/sifive_fu540_defconfig | 3 ++-
>  doc/board/sifive/fu540.rst     | 5 +----
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/configs/sifive_fu540_defconfig b/configs/sifive_fu540_defconfig index 48865e5f11..979d0a0418 100644
> --- a/configs/sifive_fu540_defconfig
> +++ b/configs/sifive_fu540_defconfig
> @@ -6,6 +6,7 @@ CONFIG_RISCV_SMODE=y
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_FIT=y
>  CONFIG_MISC_INIT_R=y
> +CONFIG_DEFAULT_DEVICE_TREE="hifive-unleashed-a00"
>  CONFIG_DISPLAY_CPUINFO=y
>  CONFIG_DISPLAY_BOARDINFO=y
> -CONFIG_OF_PRIOR_STAGE=y
> +CONFIG_OF_SEPARATE=y
> diff --git a/doc/board/sifive/fu540.rst b/doc/board/sifive/fu540.rst index 7807f5b2c1..dd279f6a03 100644
> --- a/doc/board/sifive/fu540.rst
> +++ b/doc/board/sifive/fu540.rst
> @@ -58,10 +58,7 @@ firmware. We need to compile OpenSBI with below command:
>
>  .. code-block:: none
>
> -    make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<path to u-boot.bin> FW_PAYLOAD_FDT_PATH=<path to hifive-unleashed-a00.dtb from Linux>
> -
> -(Note: Prefer hifive-unleashed-a00.dtb from Linux-5.3 or higher)
> -(Note: Linux-5.2 is also fine but it does not have ethernet DT node)
> +    make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<path to u-boot-dtb.bin>
>
>  More detailed description of steps required to build FW_PAYLOAD firmware  is beyond the scope of this document. Please refer OpenSBI documenation.
> --
> 2.18.0.321.gffc6fa0e3
>

I am trying to prepare a PR, but it encounter a conflict with the
master when applying this patch.
Can you rebase it again ?

Or if you don't mind I can modify your patch directly.

Thanks
Rick

  parent reply	other threads:[~2019-12-02  3:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 11:29 [U-Boot] [PATCH v4 1/2] riscv: dts: Add hifive-unleashed-a00 dts from Linux Jagan Teki
2019-11-18 11:29 ` [U-Boot] [PATCH v4 2/2] sifive: fu540: Enable OF_SEPARATE Jagan Teki
2019-11-18 12:22   ` Bin Meng
2019-11-18 12:36     ` Anup Patel
     [not found]   ` <752D002CFF5D0F4FA35C0100F1D73F3FA46A8F41@ATCPCS16.andestech.com>
2019-12-02  3:32     ` Rick Chen [this message]
2019-12-03 13:51       ` Jagan Teki
2019-11-18 12:22 ` [U-Boot] [PATCH v4 1/2] riscv: dts: Add hifive-unleashed-a00 dts from Linux Bin Meng
2019-11-18 12:31   ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN5B=eLmrCu-ktgeTb4FofNJn0eCfOxU+BU7GUUD0EZZf5eiQQ@mail.gmail.com' \
    --to=rickchen36@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.