From: Etienne Carriere <etienne.carriere@linaro.org>
To: Peng Fan <peng.fan@nxp.com>,
f.fainelli@gmail.com, andre.przywara@arm.com,
linux-kernel@vger.kernel.org,
etienne carriere <etienne.carriere@st.com>
Subject: Re: [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox
Date: Wed, 22 Jan 2020 19:20:01 +0100 [thread overview]
Message-ID: <CAN5uoS-9yUfAT4=a9ys4d_2wxh9nW_RgXd_-3T-zF2r-k-PtOw@mail.gmail.com> (raw)
In-Reply-To: <CAN5uoS_YyPXiqZnNfM32cxeAsK+xuPX9QRK94-DJ6oMQFrZPXQ@mail.gmail.com>
Hello Peng and all,
> From: Peng Fan <peng.fan@nxp.com>
>
> This mailbox driver implements a mailbox which signals transmitted data
> via an ARM smc (secure monitor call) instruction. The mailbox receiver
> is implemented in firmware and can synchronously return data when it
> returns execution to the non-secure world again.
> An asynchronous receive path is not implemented.
> This allows the usage of a mailbox to trigger firmware actions on SoCs
> which either don't have a separate management processor or on which such
> a core is not available. A user of this mailbox could be the SCP
> interface.
>
> Modified from Andre Przywara's v2 patch
> https://lore.kernel.org/patchwork/patch/812999/
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
I've successfully tested your change on my board. It is a stm32mp1
with TZ secure hardening and I run an OP-TEE firmware (possibly a TF-A
sp_min) with a SCMI server for clock and reset. Upstream in progress.
The platform uses 2 instances of your SMC based mailbox device driver
(2 mailboxes). Works nice with your change.
You can add my T-b tag: Tested-by: Etienne Carriere
<etienne.carriere@linaro.org>
FYI, I'll (hopefully soon) post a change proposal in U-Boot ML for an
equvalent 'SMC based mailbox' driver and SCMI agent protocol/device
drivers for clock and reset controllers.
I'm also working on getting this SCMI server upstream in TF-A and
OP-TEE. Your SMC based mailbox driver is a valuable notification
scheme for our SCMI services support in Arm TZ secure world.
Regards,
Etienne
next parent reply other threads:[~2020-01-22 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN5uoS_YyPXiqZnNfM32cxeAsK+xuPX9QRK94-DJ6oMQFrZPXQ@mail.gmail.com>
2020-01-22 18:20 ` Etienne Carriere [this message]
2020-01-27 12:58 ` [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox Peng Fan
2020-01-28 11:38 ` Sudeep Holla
2020-01-29 15:01 ` Etienne Carriere
2020-01-29 16:40 ` Sudeep Holla
2019-12-02 10:14 [PATCH v11 0/2] mailbox: arm: introduce smc triggered mailbox Peng Fan
2019-12-02 10:14 ` [PATCH v11 2/2] mailbox: introduce ARM SMC based mailbox Peng Fan
2019-12-02 10:14 ` Peng Fan
2019-12-03 11:46 ` Sudeep Holla
2019-12-03 11:46 ` Sudeep Holla
2019-12-05 3:24 ` Peng Fan
2019-12-05 3:24 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN5uoS-9yUfAT4=a9ys4d_2wxh9nW_RgXd_-3T-zF2r-k-PtOw@mail.gmail.com' \
--to=etienne.carriere@linaro.org \
--cc=andre.przywara@arm.com \
--cc=etienne.carriere@st.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.