From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A854EC47083 for ; Wed, 2 Jun 2021 08:30:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 787DF61159 for ; Wed, 2 Jun 2021 08:30:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 787DF61159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vq5WZs9N5aakYaj+qQItkOYBSAe1CFKsT5CTlRjoB38=; b=vFPbddu1zUc8e0 AS9TWZe/tRePte6elWuyBHnTZ4qHbhzqFbQ3CvBp3GhAuVBoN0awSUnjV9EMFQ3xoEynb1sF5RdJZ wS3sTUP2RoqIox+83CSmGtUN9KxunZKCsV42bvxvzz+BnpqpiOly7louAqLqzCGG4rA+WCYGqTYOK ef2lcJAc6ffhZK+naMc5YsLZuR5xCwb6n4Cj/i1L/296M/iptJyPs6NGCmu3PNDZuqSgF9Rvmf6OL tJHjJ9DjSA+T87EKlrU6Ki9kIux3uVo1KFczUcUp5IsXMlDvJVSi/vCfMKc58NI5/El6s4N3ezftp AYGQc8Yy6aO471rleegQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loMEr-002e15-KK; Wed, 02 Jun 2021 08:28:34 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loLYa-002OQM-G8 for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 07:44:53 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a11so1732905ejf.3 for ; Wed, 02 Jun 2021 00:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nEoDi+q78zKij3D9Ea/2L+Q6p679Sr9NH9nv1GAlnCE=; b=GP4A6ovmxVkU+v/+k8a2qqVd3T3U0vZ/8hTbg2T6KBMTpkCaf2bUlPlglsVdqwm/QC cAq2nVwRpTluQNuaVKAyqENkjTj+9FCBVFjXVYhDG8cqm4CbCknXIQzNMdGHZDXo2ORP EVaRL1dmldKsbaiuPvT8n2FxRO6fN3blp4j9HGRRkHDyG0FMvM9b6muOv42jU22PGeW1 xOAMjqxgKq5w4uFfNaF4vRu5260ADlj1ay1xPziP4EBnJIlpe14tZ+qj23mNpeq5raWc UTY1sjn2amgkBKzamgdLPupAEhR9MnntOYZAQbJBQfk2xrSsNDquy0EX3QxS+Pfk9nLG S2uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nEoDi+q78zKij3D9Ea/2L+Q6p679Sr9NH9nv1GAlnCE=; b=iBgj8NbmVXCW60j8iayXMrcyeES0MrCmNuNH4VVHyuej8ZQfpJbAmdHmZc2rbBe6Eg Cmo/VBIl2d6eJpUvxzxsxSvU/hcXYKNkpYBGX414J6isQFBtHcCWIIwEvva3bjiM0mxB 8YmIWH0XmVJkcrPu/kfpiMXnrdaq6597l1tM6i+CJGLdYj4tGIEg3zT5/98J7e6hWUSQ v08OQfI5fKP9pyYI+sOn3zYeRc1svm2SxPfZUIjBgESqCD2yLM5lec4Lc4lmdTbjwZbe tKiPG5A3EiwmpRPHxKuf8CWVar8ABzQlqwPlH33RblJlrGz+6U1CZNvAvKpVQt6u+kHB 7ZdA== X-Gm-Message-State: AOAM533w3DwZysouLrEr8yiZDB0KJUSkkJthbBYqfGZShrpIYKeNm9Bf LSswBWZkzUf8+vMYcMMAP91kIpYVs2qvXp0wXXl4kQ== X-Google-Smtp-Source: ABdhPJx3AixMgYXP+NekTpV92aEY5I7C0C/jkdYiwAhR8nvUpCU2hgAlZ2hodrpwgv8yaoBKGxKhQ7hdJYRW25DZy4I= X-Received: by 2002:a17:907:20f7:: with SMTP id rh23mr15208831ejb.414.1622619890847; Wed, 02 Jun 2021 00:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20210601225125.918225-1-sudeep.holla@arm.com> <20210601225125.918225-2-sudeep.holla@arm.com> <20210602073653.x4bon6jbiat2jnqv@bogus> In-Reply-To: <20210602073653.x4bon6jbiat2jnqv@bogus> From: Etienne Carriere Date: Wed, 2 Jun 2021 09:44:40 +0200 Message-ID: Subject: Re: [PATCH 2/2] firmware: arm_scmi: Add compatibility checks for shmem node To: Sudeep Holla Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Cristian Marussi , Kevin Hilman , Neil Armstrong , Jerome Brunet , Florian Fainelli , Jim Quinlan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_004452_582691_D4FCCF74 X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2 Jun 2021 at 09:37, Sudeep Holla wrote: > > On Wed, Jun 02, 2021 at 09:33:03AM +0200, Etienne Carriere wrote: > > Hello Sudeep, > > > > > > On Wed, 2 Jun 2021 at 00:51, Sudeep Holla wrote: > > > > > > The shared memory node used for communication between the firmware and > > > the OS should be compatible with "arm,scmi-shmem". Add the check for the > > > same while parsing the node before fetching the memory regions. > > > > > > Cc: Cristian Marussi > > > Cc: Florian Fainelli > > > Cc: Jim Quinlan > > > Cc: Etienne Carriere > > > Signed-off-by: Sudeep Holla > > > --- > > > drivers/firmware/arm_scmi/mailbox.c | 3 +++ > > > drivers/firmware/arm_scmi/smc.c | 3 +++ > > > 2 files changed, 6 insertions(+) > > > > > > diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c > > > index 4626404be541..e3dcb58314ae 100644 > > > --- a/drivers/firmware/arm_scmi/mailbox.c > > > +++ b/drivers/firmware/arm_scmi/mailbox.c > > > @@ -69,6 +69,9 @@ static int mailbox_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, > > > return -ENOMEM; > > > > > > shmem = of_parse_phandle(cdev->of_node, "shmem", idx); > > > + if (!of_device_is_compatible(shmem, "arm,scmi-shmem")) > > > + return -ENXIO; > > > > Before this change, one could use another type of memory node, like "mmio-sram". > > Is there a strong reason to enforce use of "arm,scmi-shmem" nodes? > > > > No that is for the entire SRAM which still holds and generic on-chip SRAM > driver will take care of that, this is only for the subsections that is > reserved for the scp shmem. The binding has been always there, just the > missing check. When I move to yaml, I realised that and hence the > addition of check. Ok, I understand. True the binding was there but only in the DTS examples snipped. This constraint on the compatible property of the shmem node should be clearly stated in the yaml I think. br, etienne > > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel